[MPTCP] [PATCH v2 0/2] mptcp: disallow setting the MPTCP ULP from userspace

[MPTCP] [PATCH v2 0/2] mptcp: disallow setting the MPTCP ULP from userspace

[Davide Caratti]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

with this series we make

setscokopt(..., IPPROTO_TCP, TCP_ULP, "mptcp", sizeof("mptcp"));

return -1 and set errno to -EOPNOPSUPPORT.

this allows attaching MPTCP ULP only to a TCP socket that has been
created through sock_create_kern().

- Patch 1/2 lets subflow_init() fail with -EOPNOTSUPPORT in case users
  try to setsockopt(..., TCP_ULP) on a TCP socket that has been created
  by a userspace program. I suggest squashing this patch in "mptcp:
  Associate MPTCP context with TCP socket".
- Patch 2/2 includes kselftest code. I suggest squashing it with "mptcp:
  add basic kselftest for mptcp".

Changes since v1:
 - don't redirect the selftest output to /dev/null 
 - test output depends on the value of 'errno', to avoid false negative
   in case kernel is built without CONFIG_MPTCP

Davide Caratti (2):
  mptcp: subflow: disallow setsockopt(... TCP_ULP, "mptcp")
  selftests: test setsockopt(..., TCP_ULP, "mptcp", ...)

 net/mptcp/subflow.c                           |  7 +++
 .../selftests/net/mptcp/mptcp_connect.c       | 52 +++++++++++++++++--
 .../selftests/net/mptcp/mptcp_connect.sh      | 19 +++++++
 3 files changed, 75 insertions(+), 3 deletions(-)

-- 
2.21.0