From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: check ACTHD of all rings
Date: Sun, 27 Nov 2011 18:24:18 +0000 [thread overview]
Message-ID: <d08817$2bru65@azsmga001.ch.intel.com> (raw)
In-Reply-To: <1322416697-20861-1-git-send-email-daniel.vetter@ffwll.ch>
On Sun, 27 Nov 2011 18:58:17 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Otherwise hangcheck spuriously fires when running blitter/bsd-only
> workloads.
>
> Contrary to a similar patch by Ben Widawsky this does not check
> INSTDONE of the other rings. Chris Wilson implied that in a failure to
> detect a hang, most likely because INSTDONE was fluctuating. Thus only
> check ACTHD, which as far as I know is rather reliable. Also, blitter
> and bsd rings can't launch complex tasks from a single instruction
> (like 3D_PRIM on the render with complex or even infinite shaders).
>
> This fixes spurious gpu hang detection when running
> tests/gem_hangcheck_forcewake on snb/ivb.
>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-27 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 17:58 [PATCH] drm/i915: check ACTHD of all rings Daniel Vetter
2011-11-27 18:24 ` Chris Wilson [this message]
2011-11-28 17:09 ` Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='d08817$2bru65@azsmga001.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.