Re: [PATCH v2 4/7] media: rkvdec: Add RK3288 variant

From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Jonas Karlman <jonas@kwiboo.se>,
	Ezequiel Garcia	 <ezequiel@vanguardiasur.com.ar>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	 Mauro Carvalho Chehab	 <mchehab@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: Alex Bee <knaerzche@gmail.com>,
	Sebastian Fricke <sebastian.fricke@collabora.com>,
	linux-media@vger.kernel.org,  linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] media: rkvdec: Add RK3288 variant
Date: Mon, 11 Aug 2025 17:17:53 -0400	[thread overview]
Message-ID: <d1c879392bde10319d9e142db385bb306724b8f4.camel@collabora.com> (raw)
In-Reply-To: <20250810212454.3237486-5-jonas@kwiboo.se>

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

Le dimanche 10 août 2025 à 21:24 +0000, Jonas Karlman a écrit :
> From: Alex Bee <knaerzche@gmail.com>
> 
> Add a RK3288 variant, a version of the Rockchip VDEC IP that only
> support HEVC decoding.
> 
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
> Changes in v2:
> - No change
> ---
>  drivers/media/platform/rockchip/rkvdec/rkvdec.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> index 56807122720e..c20e046205fe 100644
> --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c
> @@ -1222,6 +1222,10 @@ static void rkvdec_watchdog_func(struct work_struct *work)
>  	}
>  }
>  
> +static const struct rkvdec_variant rk3288_rkvdec_variant = {
> +	.capabilities = RKVDEC_CAPABILITY_HEVC,
> +};
> +
>  static const struct rkvdec_variant rk3399_rkvdec_variant = {
>  	.capabilities = RKVDEC_CAPABILITY_HEVC |
>  			RKVDEC_CAPABILITY_H264 |
> @@ -1229,6 +1233,10 @@ static const struct rkvdec_variant rk3399_rkvdec_variant = {
>  };
>  
>  static const struct of_device_id of_rkvdec_match[] = {
> +	{
> +		.compatible = "rockchip,rk3288-vdec",
> +		.data = &rk3288_rkvdec_variant,
> +	},
>  	{
>  		.compatible = "rockchip,rk3399-vdec",
>  		.data = &rk3399_rkvdec_variant,

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]