Re: [PATCH v2 5/7] media: rkvdec: Disable QoS for HEVC and VP9 on RK3328

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

Le mardi 12 août 2025 à 00:22 +0200, Jonas Karlman a écrit :
> > >  #define RKVDEC_CAPABILITY_H264		BIT(1)
> > >  #define RKVDEC_CAPABILITY_VP9		BIT(2)
> > >  
> > > +#define RKVDEC_QUIRK_DISABLE_QOS	BIT(0)
> > 
> > Can you go back in the series, get H264 into bit 0, VP9 into bit 1, and set
> > quirks from bit 16 ? Just worried the whole finding can becomes a mess in
> > many
> > years from now.
> 
> The reason for HEVC in bit 0 is mainly because the first generation was
> HEVC only, this also matches the mode reg values (0=hevc, 1=h264, 2=vp9).
> 
> I can start quirk at bit 16 if you like, not really sure I understand
> why? Do you want to combine capabilities and quirks into one?

My bad, I miss-understood the code. The Quirk bits are seperate, not filling a
gap.

cheers,
Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]