All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Osose Itua <osose.itua@savoirfairelinux.com>, netdev@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	michael.hennerich@analog.com,
	jerome.oufella@savoirfairelinux.com
Subject: Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP Termination Register
Date: Tue, 23 Dec 2025 07:36:30 +0000	[thread overview]
Message-ID: <d1e75d9b-0c49-4c52-a77c-c6fe3918e4d6@linux.dev> (raw)
In-Reply-To: <20251222222210.3651577-2-osose.itua@savoirfairelinux.com>

On 22/12/2025 22:21, Osose Itua wrote:
> The ADIN1200/ADIN1300 provide a control bit that selects between normal
> receive termination and the lowest common mode impedance for 100BASE-TX
> operation. This behavior is controlled through the Low Power Termination
> register (B_100_ZPTM_EN_DIMRX).
> 
> Bit 0 of this register enables normal termination when set (this is the
> default), and selects the lowest common mode impedance when cleared.
> 
> Signed-off-by: Osose Itua <osose.itua@savoirfairelinux.com>
> ---
>   drivers/net/phy/adin.c | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
> index 7fa713ca8d45..e8b778cb191d 100644
> --- a/drivers/net/phy/adin.c
> +++ b/drivers/net/phy/adin.c
> @@ -4,6 +4,7 @@
>    *
>    * Copyright 2019 Analog Devices Inc.
>    */
> +#include <cerrno>

This kind of include is not used in kernel.
You don't need to include anything in this file to have EINVAL defined.

>   #include <linux/kernel.h>
>   #include <linux/bitfield.h>
>   #include <linux/delay.h>
> @@ -89,6 +90,9 @@

  parent reply	other threads:[~2025-12-23  7:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-22 22:21 [PATCH v2 0/2] net: phy: adin: enable configuration of the LP Termination Register Osose Itua
2025-12-22 22:21 ` [PATCH v2 1/2] " Osose Itua
2025-12-23  2:57   ` Subbaraya Sundeep
2025-12-23  7:36   ` Vadim Fedorenko [this message]
2025-12-23  9:36   ` Andrew Lunn
2026-01-07 10:18     ` Nuno Sá
2025-12-23 13:22   ` kernel test robot
2025-12-23 13:33   ` kernel test robot
2025-12-22 22:21 ` [PATCH v2 2/2] dt-bindings: net: adi,adin: document LP Termination property Osose Itua
2025-12-23  9:33   ` Andrew Lunn
2025-12-27 12:29   ` Krzysztof Kozlowski
2026-01-07 10:25     ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1e75d9b-0c49-4c52-a77c-c6fe3918e4d6@linux.dev \
    --to=vadim.fedorenko@linux.dev \
    --cc=devicetree@vger.kernel.org \
    --cc=jerome.oufella@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=netdev@vger.kernel.org \
    --cc=osose.itua@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.