* [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
@ 2021-12-06 17:42 Rob Herring
2021-12-07 8:37 ` Thierry Reding
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rob Herring @ 2021-12-06 17:42 UTC (permalink / raw)
To: Krzysztof Kozlowski, Tony Lindgren, Roger Quadros
Cc: devicetree, Thierry Reding, linux-kernel
With 'unevaluatedProperties' support implemented, the TI GPMC example
has a warning:
Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
The child node definition for GPMC is not a complete binding, so specifying
'unevaluatedProperties: false' for it is not correct and should be
dropped.
Fixup the unnecessary 'allOf' while we're here.
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Roger Quadros <rogerq@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
index 25b42d68f9b3..85d024f01eba 100644
--- a/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml
@@ -119,11 +119,8 @@ patternProperties:
The child device node represents the device connected to the GPMC
bus. The device can be a NAND chip, SRAM device, NOR device
or an ASIC.
+ $ref: "ti,gpmc-child.yaml"
- allOf:
- - $ref: "ti,gpmc-child.yaml"
-
- unevaluatedProperties: false
required:
- compatible
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
2021-12-06 17:42 [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties Rob Herring
@ 2021-12-07 8:37 ` Thierry Reding
2021-12-07 9:12 ` Krzysztof Kozlowski
2021-12-07 12:49 ` Roger Quadros
2 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2021-12-07 8:37 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Tony Lindgren, Roger Quadros, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Mon, Dec 06, 2021 at 11:42:15AM -0600, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>
> The child node definition for GPMC is not a complete binding, so specifying
> 'unevaluatedProperties: false' for it is not correct and should be
> dropped.
>
> Fixup the unnecessary 'allOf' while we're here.
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
2021-12-06 17:42 [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties Rob Herring
2021-12-07 8:37 ` Thierry Reding
@ 2021-12-07 9:12 ` Krzysztof Kozlowski
2021-12-07 15:54 ` Rob Herring
2021-12-07 12:49 ` Roger Quadros
2 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-07 9:12 UTC (permalink / raw)
To: Rob Herring, Tony Lindgren, Roger Quadros
Cc: devicetree, Thierry Reding, linux-kernel
On 06/12/2021 18:42, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>
> The child node definition for GPMC is not a complete binding, so specifying
> 'unevaluatedProperties: false' for it is not correct and should be
> dropped.
>
> Fixup the unnecessary 'allOf' while we're here.
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Looks good. Rob, do you want to take it via your tree or I should handle it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
2021-12-07 9:12 ` Krzysztof Kozlowski
@ 2021-12-07 15:54 ` Rob Herring
2021-12-07 16:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-12-07 15:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Tony Lindgren, Roger Quadros, devicetree, Thierry Reding,
linux-kernel
On Tue, Dec 7, 2021 at 3:12 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 06/12/2021 18:42, Rob Herring wrote:
> > With 'unevaluatedProperties' support implemented, the TI GPMC example
> > has a warning:
> >
> > Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
> >
> > The child node definition for GPMC is not a complete binding, so specifying
> > 'unevaluatedProperties: false' for it is not correct and should be
> > dropped.
> >
> > Fixup the unnecessary 'allOf' while we're here.
> >
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Roger Quadros <rogerq@kernel.org>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
>
> Looks good. Rob, do you want to take it via your tree or I should handle it?
I'll take it given there's also the somewhat related "dt-bindings:
mtd: ti,gpmc-nand: Add missing 'rb-gpios'"
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
2021-12-07 15:54 ` Rob Herring
@ 2021-12-07 16:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-12-07 16:27 UTC (permalink / raw)
To: Rob Herring
Cc: Tony Lindgren, Roger Quadros, devicetree, Thierry Reding,
linux-kernel
On 07/12/2021 16:54, Rob Herring wrote:
> On Tue, Dec 7, 2021 at 3:12 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> On 06/12/2021 18:42, Rob Herring wrote:
>>> With 'unevaluatedProperties' support implemented, the TI GPMC example
>>> has a warning:
>>>
>>> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>>>
>>> The child node definition for GPMC is not a complete binding, so specifying
>>> 'unevaluatedProperties: false' for it is not correct and should be
>>> dropped.
>>>
>>> Fixup the unnecessary 'allOf' while we're here.
>>>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> Cc: Roger Quadros <rogerq@kernel.org>
>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../devicetree/bindings/memory-controllers/ti,gpmc.yaml | 5 +----
>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>
>> Looks good. Rob, do you want to take it via your tree or I should handle it?
>
> I'll take it given there's also the somewhat related "dt-bindings:
> mtd: ti,gpmc-nand: Add missing 'rb-gpios'"
Sure, then:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties
2021-12-06 17:42 [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties Rob Herring
2021-12-07 8:37 ` Thierry Reding
2021-12-07 9:12 ` Krzysztof Kozlowski
@ 2021-12-07 12:49 ` Roger Quadros
2 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2021-12-07 12:49 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Tony Lindgren
Cc: devicetree, Thierry Reding, linux-kernel
On 06/12/2021 19:42, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the TI GPMC example
> has a warning:
>
> Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)
>
> The child node definition for GPMC is not a complete binding, so specifying
> 'unevaluatedProperties: false' for it is not correct and should be
> dropped.
>
> Fixup the unnecessary 'allOf' while we're here.
>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Roger Quadros <rogerq@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
cheers,
-roger
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-07 16:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-06 17:42 [PATCH] dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties Rob Herring
2021-12-07 8:37 ` Thierry Reding
2021-12-07 9:12 ` Krzysztof Kozlowski
2021-12-07 15:54 ` Rob Herring
2021-12-07 16:27 ` Krzysztof Kozlowski
2021-12-07 12:49 ` Roger Quadros
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.