Re: [PATCH v3 14/28] hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisions

["Cédric Le Goater" <clg@kaod.org>]

On 2/13/25 04:35, Jamin Lin wrote:
> Added new definitions for AST2700_A1_SILICON_REV and AST2750_A1_SILICON_REV to
> identify the A1 silicon revisions.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/misc/aspeed_scu.c         | 2 ++
>   include/hw/misc/aspeed_scu.h | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
> index bac1441b06..2d9fe78926 100644
> --- a/hw/misc/aspeed_scu.c
> +++ b/hw/misc/aspeed_scu.c
> @@ -559,6 +559,8 @@ static uint32_t aspeed_silicon_revs[] = {
>       AST2700_A0_SILICON_REV,
>       AST2720_A0_SILICON_REV,
>       AST2750_A0_SILICON_REV,
> +    AST2700_A1_SILICON_REV,
> +    AST2750_A1_SILICON_REV,
>   };
>   
>   bool is_supported_silicon_rev(uint32_t silicon_rev)
> diff --git a/include/hw/misc/aspeed_scu.h b/include/hw/misc/aspeed_scu.h
> index 356be95e45..684b48b722 100644
> --- a/include/hw/misc/aspeed_scu.h
> +++ b/include/hw/misc/aspeed_scu.h
> @@ -54,6 +54,8 @@ struct AspeedSCUState {
>   #define AST2700_A0_SILICON_REV   0x06000103U
>   #define AST2720_A0_SILICON_REV   0x06000203U
>   #define AST2750_A0_SILICON_REV   0x06000003U
> +#define AST2700_A1_SILICON_REV   0x06010103U
> +#define AST2750_A1_SILICON_REV   0x06010003U
>   
>   #define ASPEED_IS_AST2500(si_rev)     ((((si_rev) >> 24) & 0xff) == 0x04)
>