* [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl
@ 2025-03-16 7:57 Peter Korsgaard
2025-03-16 10:54 ` Julien Olivain
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2025-03-16 7:57 UTC (permalink / raw)
To: buildroot; +Cc: Heiko Thiery, Andrey Yurovsky
Fixes http://autobuild.buildroot.net/results/6efc1275d3aac9f0a4c000f3d0911b5a880e495d/
Rauc uses X509_PURPOSE_get_by_id() since rauc-1.3 with commit 375dbb16dd94
("src/signature: add support for codesigning certificate purpose"):
../src/signature.c: In function 'signature_init':
../src/signature.c:97:13: warning: implicit declaration of function 'X509_PURPOSE_get_by_id'; did you mean 'X509_PURPOSE_get_id'? [-Wimplicit-function-declaration]
97 | if (X509_PURPOSE_get_by_id(id) >= 0) {
Which is not provided by LibreSSL:
nm -D target/usr/lib/libcrypto.so | grep X509_PURPOSE_
00000000001377b0 T X509_PURPOSE_get0
0000000000137850 T X509_PURPOSE_get0_name
0000000000137860 T X509_PURPOSE_get0_sname
00000000001377d0 T X509_PURPOSE_get_by_sname
00000000001377a0 T X509_PURPOSE_get_count
0000000000137840 T X509_PURPOSE_get_id
So force the use of libopenssl.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/rauc/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/rauc/Config.in b/package/rauc/Config.in
index af0b99c36b..701ffef76b 100644
--- a/package/rauc/Config.in
+++ b/package/rauc/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_RAUC
depends on BR2_USE_WCHAR # glib2
select BR2_PACKAGE_LIBGLIB2
select BR2_PACKAGE_OPENSSL
+ select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # uses X509_PURPOSE_get_by_id
# uses ENGINE_* API
select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL
select BR2_PACKAGE_SQUASHFS # run-time dependency
--
2.39.5
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl
2025-03-16 7:57 [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl Peter Korsgaard
@ 2025-03-16 10:54 ` Julien Olivain
2025-03-16 19:44 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Julien Olivain @ 2025-03-16 10:54 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: buildroot, Heiko Thiery, Andrey Yurovsky
Hi Peter,
On 16/03/2025 08:57, Peter Korsgaard wrote:
> Fixes
> http://autobuild.buildroot.net/results/6efc1275d3aac9f0a4c000f3d0911b5a880e495d/
>
> Rauc uses X509_PURPOSE_get_by_id() since rauc-1.3 with commit
> 375dbb16dd94
> ("src/signature: add support for codesigning certificate purpose"):
>
> ../src/signature.c: In function 'signature_init':
> ../src/signature.c:97:13: warning: implicit declaration of function
> 'X509_PURPOSE_get_by_id'; did you mean 'X509_PURPOSE_get_id'?
> [-Wimplicit-function-declaration]
> 97 | if (X509_PURPOSE_get_by_id(id) >= 0) {
>
> Which is not provided by LibreSSL:
>
> nm -D target/usr/lib/libcrypto.so | grep X509_PURPOSE_
> 00000000001377b0 T X509_PURPOSE_get0
> 0000000000137850 T X509_PURPOSE_get0_name
> 0000000000137860 T X509_PURPOSE_get0_sname
> 00000000001377d0 T X509_PURPOSE_get_by_sname
> 00000000001377a0 T X509_PURPOSE_get_count
> 0000000000137840 T X509_PURPOSE_get_id
>
> So force the use of libopenssl.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/rauc/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
> index af0b99c36b..701ffef76b 100644
> --- a/package/rauc/Config.in
> +++ b/package/rauc/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_RAUC
> depends on BR2_USE_WCHAR # glib2
> select BR2_PACKAGE_LIBGLIB2
> select BR2_PACKAGE_OPENSSL
> + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # uses
> X509_PURPOSE_get_by_id
If we force libopenssl here...
> # uses ENGINE_* API
> select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL
^~~~~~~~~~~~~~~~~~~~~~~~~
...should we also remove the "if" condition here?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl
2025-03-16 10:54 ` Julien Olivain
@ 2025-03-16 19:44 ` Peter Korsgaard
2025-03-24 16:21 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2025-03-16 19:44 UTC (permalink / raw)
To: Julien Olivain; +Cc: buildroot, Heiko Thiery, Andrey Yurovsky
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> Hi Peter,
> On 16/03/2025 08:57, Peter Korsgaard wrote:
>> Fixes
>> http://autobuild.buildroot.net/results/6efc1275d3aac9f0a4c000f3d0911b5a880e495d/
>> Rauc uses X509_PURPOSE_get_by_id() since rauc-1.3 with commit
>> 375dbb16dd94
>> ("src/signature: add support for codesigning certificate purpose"):
>> ../src/signature.c: In function 'signature_init':
>> ../src/signature.c:97:13: warning: implicit declaration of function
>> 'X509_PURPOSE_get_by_id'; did you mean 'X509_PURPOSE_get_id'?
>> [-Wimplicit-function-declaration]
>> 97 | if (X509_PURPOSE_get_by_id(id) >= 0) {
>> Which is not provided by LibreSSL:
>> nm -D target/usr/lib/libcrypto.so | grep X509_PURPOSE_
>> 00000000001377b0 T X509_PURPOSE_get0
>> 0000000000137850 T X509_PURPOSE_get0_name
>> 0000000000137860 T X509_PURPOSE_get0_sname
>> 00000000001377d0 T X509_PURPOSE_get_by_sname
>> 00000000001377a0 T X509_PURPOSE_get_count
>> 0000000000137840 T X509_PURPOSE_get_id
>> So force the use of libopenssl.
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> package/rauc/Config.in | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
>> index af0b99c36b..701ffef76b 100644
>> --- a/package/rauc/Config.in
>> +++ b/package/rauc/Config.in
>> @@ -5,6 +5,7 @@ config BR2_PACKAGE_RAUC
>> depends on BR2_USE_WCHAR # glib2
>> select BR2_PACKAGE_LIBGLIB2
>> select BR2_PACKAGE_OPENSSL
>> + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # uses
>> X509_PURPOSE_get_by_id
> If we force libopenssl here...
>> # uses ENGINE_* API
>> select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> ...should we also remove the "if" condition here?
Ahh yes, we can.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl
2025-03-16 19:44 ` Peter Korsgaard
@ 2025-03-24 16:21 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2025-03-24 16:21 UTC (permalink / raw)
To: Julien Olivain; +Cc: buildroot, Heiko Thiery, Andrey Yurovsky
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
>> Hi Peter,
>> On 16/03/2025 08:57, Peter Korsgaard wrote:
>>> Fixes
>>> http://autobuild.buildroot.net/results/6efc1275d3aac9f0a4c000f3d0911b5a880e495d/
>>> Rauc uses X509_PURPOSE_get_by_id() since rauc-1.3 with commit
>>> 375dbb16dd94
>>> ("src/signature: add support for codesigning certificate purpose"):
>>> ../src/signature.c: In function 'signature_init':
>>> ../src/signature.c:97:13: warning: implicit declaration of function
>>> 'X509_PURPOSE_get_by_id'; did you mean 'X509_PURPOSE_get_id'?
>>> [-Wimplicit-function-declaration]
>>> 97 | if (X509_PURPOSE_get_by_id(id) >= 0) {
>>> Which is not provided by LibreSSL:
>>> nm -D target/usr/lib/libcrypto.so | grep X509_PURPOSE_
>>> 00000000001377b0 T X509_PURPOSE_get0
>>> 0000000000137850 T X509_PURPOSE_get0_name
>>> 0000000000137860 T X509_PURPOSE_get0_sname
>>> 00000000001377d0 T X509_PURPOSE_get_by_sname
>>> 00000000001377a0 T X509_PURPOSE_get_count
>>> 0000000000137840 T X509_PURPOSE_get_id
>>> So force the use of libopenssl.
>>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>>> ---
>>> package/rauc/Config.in | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/package/rauc/Config.in b/package/rauc/Config.in
>>> index af0b99c36b..701ffef76b 100644
>>> --- a/package/rauc/Config.in
>>> +++ b/package/rauc/Config.in
>>> @@ -5,6 +5,7 @@ config BR2_PACKAGE_RAUC
>>> depends on BR2_USE_WCHAR # glib2
>>> select BR2_PACKAGE_LIBGLIB2
>>> select BR2_PACKAGE_OPENSSL
>>> + select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # uses
>>> X509_PURPOSE_get_by_id
>> If we force libopenssl here...
>>> # uses ENGINE_* API
>>> select BR2_PACKAGE_LIBOPENSSL_ENGINES if BR2_PACKAGE_LIBOPENSSL
>> ^~~~~~~~~~~~~~~~~~~~~~~~~
>> ...should we also remove the "if" condition here?
> Ahh yes, we can.
> Committed with that fixed, thanks.
Committed to 2024.11.x, thanks. The function was dropped (by accident?)
by libressl 3.9, so 2024.02.x is not affected.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-24 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-16 7:57 [Buildroot] [PATCH] package/rauc: needs libopenssl, not libressl Peter Korsgaard
2025-03-16 10:54 ` Julien Olivain
2025-03-16 19:44 ` Peter Korsgaard
2025-03-24 16:21 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.