All of lore.kernel.org
 help / color / mirror / Atom feed
From: periyasa@codeaurora.org
To: John Crispin <john@phrozen.org>
Cc: linux-wireless-owner@vger.kernel.org,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Kalle Valo <kvalo@codeaurora.org>,
	Shashidhar Lakkavalli <slakkavalli@datto.com>
Subject: Re: [RESEND] ath11k: add tx hw 802.11 encapusaltion offloading support
Date: Thu, 23 Jan 2020 15:15:26 +0530	[thread overview]
Message-ID: <d4c4c85868ad02bb4b65b7de0f31f264@codeaurora.org> (raw)
In-Reply-To: <20200122142930.19239-1-john@phrozen.org>

> This patch adds support for ethernet rxtx mode to the driver. The 
> feature
> is enabled via a new module parameter. If enabled to driver will enable
> the feature on a per vif basis if all other requirements were met.
> 
> Signed-off-by: Shashidhar Lakkavalli <slakkavalli@datto.com>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  drivers/net/wireless/ath/ath11k/core.h  |  5 +++
>  drivers/net/wireless/ath/ath11k/dp_tx.c | 16 ++++++++--
>  drivers/net/wireless/ath/ath11k/mac.c   | 41 ++++++++++++++++++++-----
>  3 files changed, 52 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
> b/drivers/net/wireless/ath/ath11k/mac.c
> index 556eef9881a7..f56adba5f838 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -33,6 +33,10 @@
>  	.max_power              = 30, \
>  }
> 
> +static unsigned int ath11k_ethernet_mode;
> +module_param_named(ethernet_mode, ath11k_ethernet_mode, uint, 0644);
> +MODULE_PARM_DESC(ethernet_mode, "Use ethernet frame datapath");
> +

Shall we have a generic module parameter instead of a dedicated module 
parameter for ethernet mode?
so that we can extend this module parameter for raw mode also like below

/* 0 - Nativi wifi
  * 1 - Ethernet mode
  */
static unsigned int ath11k_mode;
module_param_named(mode, ath11k_mode, uint, 0644);
MODULE_PARM_DESC(mode, "Use for rxtx frame datapath");

- Karthikeyan

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: periyasa@codeaurora.org
To: John Crispin <john@phrozen.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Shashidhar Lakkavalli <slakkavalli@datto.com>,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [RESEND] ath11k: add tx hw 802.11 encapusaltion offloading support
Date: Thu, 23 Jan 2020 15:15:26 +0530	[thread overview]
Message-ID: <d4c4c85868ad02bb4b65b7de0f31f264@codeaurora.org> (raw)
In-Reply-To: <20200122142930.19239-1-john@phrozen.org>

> This patch adds support for ethernet rxtx mode to the driver. The 
> feature
> is enabled via a new module parameter. If enabled to driver will enable
> the feature on a per vif basis if all other requirements were met.
> 
> Signed-off-by: Shashidhar Lakkavalli <slakkavalli@datto.com>
> Signed-off-by: John Crispin <john@phrozen.org>
> ---
>  drivers/net/wireless/ath/ath11k/core.h  |  5 +++
>  drivers/net/wireless/ath/ath11k/dp_tx.c | 16 ++++++++--
>  drivers/net/wireless/ath/ath11k/mac.c   | 41 ++++++++++++++++++++-----
>  3 files changed, 52 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c
> b/drivers/net/wireless/ath/ath11k/mac.c
> index 556eef9881a7..f56adba5f838 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -33,6 +33,10 @@
>  	.max_power              = 30, \
>  }
> 
> +static unsigned int ath11k_ethernet_mode;
> +module_param_named(ethernet_mode, ath11k_ethernet_mode, uint, 0644);
> +MODULE_PARM_DESC(ethernet_mode, "Use ethernet frame datapath");
> +

Shall we have a generic module parameter instead of a dedicated module 
parameter for ethernet mode?
so that we can extend this module parameter for raw mode also like below

/* 0 - Nativi wifi
  * 1 - Ethernet mode
  */
static unsigned int ath11k_mode;
module_param_named(mode, ath11k_mode, uint, 0644);
MODULE_PARM_DESC(mode, "Use for rxtx frame datapath");

- Karthikeyan

  reply	other threads:[~2020-01-23  9:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 14:29 [RESEND] ath11k: add tx hw 802.11 encapusaltion offloading support John Crispin
2020-01-22 14:29 ` John Crispin
2020-01-23  9:45 ` periyasa [this message]
2020-01-23  9:45   ` periyasa
2020-01-26 11:28 ` Kalle Valo
2020-01-26 11:28 ` Kalle Valo
2020-01-26 13:13 ` Justin Capella
2020-01-26 13:13   ` Justin Capella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c4c85868ad02bb4b65b7de0f31f264@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=slakkavalli@datto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.