Re: [PATCH v3 2/3] arm: handle CCSIDR_EL1 as a demuxed register

[Sebastian Ott <sebott@redhat.com>]

Hey Eric,

On Mon, 29 Jun 2026, Eric Auger wrote:
> On 6/22/26 3:56 PM, Sebastian Ott wrote:
>> From: Cornelia Huck <cohuck@redhat.com>
>>
>> Move handling of CCSIDR_EL1 over to the new *_IDREG_DEMUX
>> infrastructure.
>>
>> Tested-by: Alireza Sanaee <alireza.sanaee@huawei.com>
>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>> Signed-off-by: Sebastian Ott <sebott@redhat.com>
>> ---
>>  hw/arm/virt.c                 | 23 ++++++------
>>  hw/intc/armv7m_nvic.c         |  2 +-
>>  target/arm/cpu-max.c          |  6 ++--
>>  target/arm/cpu-sysregs.h.inc  |  1 +
>>  target/arm/cpu.h              |  6 ----
>>  target/arm/cpu64.c            |  6 ++--
>>  target/arm/helper.c           |  2 +-
>>  target/arm/tcg/cpu32-system.c | 26 +++++++-------
>>  target/arm/tcg/cpu64.c        | 68 +++++++++++++++++------------------
>>  9 files changed, 68 insertions(+), 72 deletions(-)
>>
>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>> index d8d27f2ef6..ab2b566e69 100644
>> --- a/hw/arm/virt.c
>> +++ b/hw/arm/virt.c
>> @@ -307,21 +307,22 @@ void set_cpu_cache(CPUCoreCaches *cpu_cache, enum CacheType cache_type,
>>
> I think you would gain in readibility to use a local variable
> ccsdir = GET_IDREG_DEMUX(&armcpu->isar, CCSIDR_EL1, bank_index);

Indeed, thanks!
Sebastian