[PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[Sergey Shtylyov]

Here are 3 patches against the 'for-next' branch of Martin Petersen's 'scsi.git' repo.
I'm trying to clean up and improve the driver comments...

[1/3] aha1542: clarify 'struct ccb' comments
[2/3] aha1542: kill trailing whitespace
[3/3] aha1542: fix multi-line comment style

[PATCH 1/3] aha1542: clarify 'struct ccb' comments

[Sergey Shtylyov]

This driver's original authors did pretty bad job of documenting the
Command Control Block (CCB) structure -- especially its 2nd byte, where
the bit numbers were completely left out.  Let's sync up the 'struct ccb'
comments to the Adaptec AHA-154xA manual I have...

Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

---
 drivers/scsi/aha1542.h |   33 +++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 14 deletions(-)

Index: scsi/drivers/scsi/aha1542.h
===================================================================
--- scsi.orig/drivers/scsi/aha1542.h
+++ scsi/drivers/scsi/aha1542.h
@@ -78,23 +78,28 @@ static inline void any2scsi(u8 *p, u32 v
 #define MAX_CDB 12
 #define MAX_SENSE 14
 
-struct ccb {		/* Command Control Block 5.3 */
-	u8 op;		/* Command Control Block Operation Code */
-	u8 idlun;	/* op=0,2:Target Id, op=1:Initiator Id */
-			/* Outbound data transfer, length is checked*/
-			/* Inbound data transfer, length is checked */
-			/* Logical Unit Number */
+/* Command Control Block (CCB), 5.3 */
+struct ccb {
+	u8 op;		/* Command Control Block Operation Code: */
+			/* 0x00: SCSI Initiator CCB, 0x01: SCSI Target CCB, */
+			/* 0x02: SCSI Initiator CCB with Scatter/Gather, */
+			/* 0x81: SCSI Bus Device Reset CCB */
+	u8 idlun;	/* Address and Direction Control: */
+			/* Bits 7-5: op=0, 2: Target ID, op=1: Initiator ID */
+			/* Bit	4: Outbound data transfer, length is checked */
+			/* Bit	3:  Inbound data transfer, length is checked */
+			/* Bits 2-0: Logical Unit Number */
 	u8 cdblen;	/* SCSI Command Length */
-	u8 rsalen;	/* Request Sense Allocation Length/Disable */
-	u8 datalen[3];	/* Data Length (msb, .., lsb) */
-	u8 dataptr[3];	/* Data Pointer */
-	u8 linkptr[3];	/* Link Pointer */
+	u8 rsalen;	/* Request Sense Allocation Length/Disable Auto Sense */
+	u8 datalen[3];	/* Data Length  (MSB, ..., LSB) */
+	u8 dataptr[3];	/* Data Pointer (MSB, ..., LSB) */
+	u8 linkptr[3];	/* Link Pointer (MSB, ..., LSB) */
 	u8 commlinkid;	/* Command Linking Identifier */
-	u8 hastat;	/* Host Adapter Status (HASTAT) */
-	u8 tarstat;	/* Target Device Status */
+	u8 hastat;	/* Host  Adapter Status (HASTAT) */
+	u8 tarstat;	/* Target Device Status (TARSTAT) */
 	u8 reserved[2];
-	u8 cdb[MAX_CDB+MAX_SENSE];	/* SCSI Command Descriptor Block */
-					/* REQUEST SENSE */
+	u8 cdb[MAX_CDB + MAX_SENSE];	/* SCSI Command Descriptor Block */
+					/* followed by the Auto Sense data */
 };
 
 #define AHA1542_REGION_SIZE 4

Re: [PATCH 1/3] aha1542: clarify 'struct ccb' comments

[Hannes Reinecke]

On 1/10/21 5:46 PM, Sergey Shtylyov wrote:
> This driver's original authors did pretty bad job of documenting the
> Command Control Block (CCB) structure -- especially its 2nd byte, where
> the bit numbers were completely left out.  Let's sync up the 'struct ccb'
> comments to the Adaptec AHA-154xA manual I have...
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
> ---
>   drivers/scsi/aha1542.h |   33 +++++++++++++++++++--------------
>   1 file changed, 19 insertions(+), 14 deletions(-)
> 
> Index: scsi/drivers/scsi/aha1542.h
> ===================================================================
> --- scsi.orig/drivers/scsi/aha1542.h
> +++ scsi/drivers/scsi/aha1542.h
> @@ -78,23 +78,28 @@ static inline void any2scsi(u8 *p, u32 v
>   #define MAX_CDB 12
>   #define MAX_SENSE 14
>   
> -struct ccb {		/* Command Control Block 5.3 */
> -	u8 op;		/* Command Control Block Operation Code */
> -	u8 idlun;	/* op=0,2:Target Id, op=1:Initiator Id */
> -			/* Outbound data transfer, length is checked*/
> -			/* Inbound data transfer, length is checked */
> -			/* Logical Unit Number */
> +/* Command Control Block (CCB), 5.3 */
> +struct ccb {
> +	u8 op;		/* Command Control Block Operation Code: */
> +			/* 0x00: SCSI Initiator CCB, 0x01: SCSI Target CCB, */
> +			/* 0x02: SCSI Initiator CCB with Scatter/Gather, */
> +			/* 0x81: SCSI Bus Device Reset CCB */
> +	u8 idlun;	/* Address and Direction Control: */
> +			/* Bits 7-5: op=0, 2: Target ID, op=1: Initiator ID */
> +			/* Bit	4: Outbound data transfer, length is checked */
> +			/* Bit	3:  Inbound data transfer, length is checked */
> +			/* Bits 2-0: Logical Unit Number */
>   	u8 cdblen;	/* SCSI Command Length */
> -	u8 rsalen;	/* Request Sense Allocation Length/Disable */
> -	u8 datalen[3];	/* Data Length (msb, .., lsb) */
> -	u8 dataptr[3];	/* Data Pointer */
> -	u8 linkptr[3];	/* Link Pointer */
> +	u8 rsalen;	/* Request Sense Allocation Length/Disable Auto Sense */
> +	u8 datalen[3];	/* Data Length  (MSB, ..., LSB) */
> +	u8 dataptr[3];	/* Data Pointer (MSB, ..., LSB) */
> +	u8 linkptr[3];	/* Link Pointer (MSB, ..., LSB) */
>   	u8 commlinkid;	/* Command Linking Identifier */
> -	u8 hastat;	/* Host Adapter Status (HASTAT) */
> -	u8 tarstat;	/* Target Device Status */
> +	u8 hastat;	/* Host  Adapter Status (HASTAT) */
> +	u8 tarstat;	/* Target Device Status (TARSTAT) */
>   	u8 reserved[2];
> -	u8 cdb[MAX_CDB+MAX_SENSE];	/* SCSI Command Descriptor Block */
> -					/* REQUEST SENSE */
> +	u8 cdb[MAX_CDB + MAX_SENSE];	/* SCSI Command Descriptor Block */
> +					/* followed by the Auto Sense data */
>   };
>   
>   #define AHA1542_REGION_SIZE 4
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

[PATCH 2/3] aha1542: kill trailing whitespace

[Sergey Shtylyov]

Some source lines (mostly the comments) in this driver end with spaces, as
reported by 'scripts/checkpatch.pl' -- let's trim these lines.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

---
 drivers/scsi/aha1542.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Index: scsi/drivers/scsi/aha1542.c
===================================================================
--- scsi.orig/drivers/scsi/aha1542.c
+++ scsi/drivers/scsi/aha1542.c
@@ -894,9 +894,9 @@ static int aha1542_dev_reset(struct scsi
 	ccb[mbo].linkptr[0] = ccb[mbo].linkptr[1] = ccb[mbo].linkptr[2] = 0;
 	ccb[mbo].commlinkid = 0;
 
-	/* 
-	 * Now tell the 1542 to flush all pending commands for this 
-	 * target 
+	/*
+	 * Now tell the 1542 to flush all pending commands for this
+	 * target
 	 */
 	aha1542_outb(sh->io_port, CMD_START_SCSI);
 	spin_unlock_irqrestore(sh->host_lock, flags);
@@ -915,7 +915,7 @@ static int aha1542_reset(struct scsi_cmn
 	int i;
 
 	spin_lock_irqsave(sh->host_lock, flags);
-	/* 
+	/*
 	 * This does a scsi reset for all devices on the bus.
 	 * In principle, we could also reset the 1542 - should
 	 * we do this?  Try this first, and we can add that later
@@ -939,7 +939,7 @@ static int aha1542_reset(struct scsi_cmn
 	/*
 	 * Now try to pick up the pieces.  For all pending commands,
 	 * free any internal data structures, and basically clear things
-	 * out.  We do not try and restart any commands or anything - 
+	 * out.  We do not try and restart any commands or anything -
 	 * the strategy handler takes care of that crap.
 	 */
 	shost_printk(KERN_WARNING, cmd->device->host, "Sent BUS RESET to scsi host %d\n", cmd->device->host->host_no);
@@ -1008,10 +1008,10 @@ static struct scsi_host_template driver_
 	.eh_bus_reset_handler	= aha1542_bus_reset,
 	.eh_host_reset_handler	= aha1542_host_reset,
 	.bios_param		= aha1542_biosparam,
-	.can_queue		= AHA1542_MAILBOXES, 
+	.can_queue		= AHA1542_MAILBOXES,
 	.this_id		= 7,
 	.sg_tablesize		= 16,
-	.unchecked_isa_dma	= 1, 
+	.unchecked_isa_dma	= 1,
 };
 
 static int aha1542_isa_match(struct device *pdev, unsigned int ndev)

Re: [PATCH 2/3] aha1542: kill trailing whitespace

[Hannes Reinecke]

On 1/10/21 5:48 PM, Sergey Shtylyov wrote:
> Some source lines (mostly the comments) in this driver end with spaces, as
> reported by 'scripts/checkpatch.pl' -- let's trim these lines.
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
> ---
>   drivers/scsi/aha1542.c |   14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

[PATCH 3/3] aha1542: fix multi-line comment style

[Sergey Shtylyov]

Some comments in this driver don't comply with the preferred multi-line
comment style, as reported by 'scripts/checkpatch.pl':

WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line

Fix those comments, along with the (unreported for some reason?) starts
of the multi-line comments not being /* on their own line... 

Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

---
 drivers/scsi/aha1542.c |  119 ++++++++++++++++++++++++++++++-------------------
 1 file changed, 75 insertions(+), 44 deletions(-)

Index: scsi/drivers/scsi/aha1542.c
===================================================================
--- scsi.orig/drivers/scsi/aha1542.c
+++ scsi/drivers/scsi/aha1542.c
@@ -119,8 +119,10 @@ static int aha1542_out(unsigned int base
 	return 0;
 }
 
-/* Only used at boot time, so we do not need to worry about latency as much
-   here */
+/*
+ * Only used at boot time, so we do not need to worry about latency as much
+ * here
+ */
 
 static int aha1542_in(unsigned int base, u8 *buf, int len, int timeout)
 {
@@ -142,35 +144,43 @@ static int makecode(unsigned hosterr, un
 		break;
 
 	case 0x11:		/* Selection time out-The initiator selection or target
-				   reselection was not complete within the SCSI Time out period */
+				 * reselection was not complete within the SCSI Time out period
+				 */
 		hosterr = DID_TIME_OUT;
 		break;
 
 	case 0x12:		/* Data overrun/underrun-The target attempted to transfer more data
-				   than was allocated by the Data Length field or the sum of the
-				   Scatter / Gather Data Length fields. */
+				 * than was allocated by the Data Length field or the sum of the
+				 * Scatter / Gather Data Length fields.
+				 */
 
 	case 0x13:		/* Unexpected bus free-The target dropped the SCSI BSY at an unexpected time. */
 
 	case 0x15:		/* MBO command was not 00, 01 or 02-The first byte of the CB was
-				   invalid. This usually indicates a software failure. */
+				 * invalid. This usually indicates a software failure.
+				 */
 
 	case 0x16:		/* Invalid CCB Operation Code-The first byte of the CCB was invalid.
-				   This usually indicates a software failure. */
+				 * This usually indicates a software failure.
+				 */
 
 	case 0x17:		/* Linked CCB does not have the same LUN-A subsequent CCB of a set
-				   of linked CCB's does not specify the same logical unit number as
-				   the first. */
+				 * of linked CCB's does not specify the same logical unit number as
+				 * the first.
+				 */
 	case 0x18:		/* Invalid Target Direction received from Host-The direction of a
-				   Target Mode CCB was invalid. */
+				 * Target Mode CCB was invalid.
+				 */
 
 	case 0x19:		/* Duplicate CCB Received in Target Mode-More than once CCB was
-				   received to service data transfer between the same target LUN
-				   and initiator SCSI ID in the same direction. */
+				 * received to service data transfer between the same target LUN
+				 * and initiator SCSI ID in the same direction.
+				 */
 
 	case 0x1a:		/* Invalid CCB or Segment List Parameter-A segment list with a zero
-				   length segment or invalid segment list boundaries was received.
-				   A CCB parameter was invalid. */
+				 * length segment or invalid segment list boundaries was received.
+				 * A CCB parameter was invalid.
+				 */
 #ifdef DEBUG
 		printk("Aha1542: %x %x\n", hosterr, scsierr);
 #endif
@@ -178,9 +188,10 @@ static int makecode(unsigned hosterr, un
 		break;
 
 	case 0x14:		/* Target bus phase sequence failure-An invalid bus phase or bus
-				   phase sequence was requested by the target. The host adapter
-				   will generate a SCSI Reset Condition, notifying the host with
-				   a SCRD interrupt */
+				 * phase sequence was requested by the target. The host adapter
+				 * will generate a SCSI Reset Condition, notifying the host with
+				 * a SCRD interrupt
+				 */
 		hosterr = DID_RESET;
 		break;
 	default:
@@ -216,8 +227,10 @@ static int aha1542_test_port(struct Scsi
 	if (inb(INTRFLAGS(sh->io_port)) & INTRMASK)
 		return 0;
 
-	/* Perform a host adapter inquiry instead so we do not need to set
-	   up the mailboxes ahead of time */
+	/*
+	 * Perform a host adapter inquiry instead so we do not need to set
+	 * up the mailboxes ahead of time
+	 */
 
 	aha1542_outb(sh->io_port, CMD_INQUIRY);
 
@@ -292,10 +305,12 @@ static irqreturn_t aha1542_interrupt(int
 	while (1) {
 		flag = inb(INTRFLAGS(sh->io_port));
 
-		/* Check for unusual interrupts.  If any of these happen, we should
-		   probably do something special, but for now just printing a message
-		   is sufficient.  A SCSI reset detected is something that we really
-		   need to deal with in some way. */
+		/*
+		 * Check for unusual interrupts.  If any of these happen, we should
+		 * probably do something special, but for now just printing a message
+		 * is sufficient.  A SCSI reset detected is something that we really
+		 * need to deal with in some way.
+		 */
 		if (flag & ~MBIF) {
 			if (flag & MBOA)
 				printk("MBOF ");
@@ -355,9 +370,11 @@ static irqreturn_t aha1542_interrupt(int
 		}
 		my_done = tmp_cmd->scsi_done;
 		aha1542_free_cmd(tmp_cmd);
-		/* Fetch the sense data, and tuck it away, in the required slot.  The
-		   Adaptec automatically fetches it, and there is no guarantee that
-		   we will still have it in the cdb when we come back */
+		/*
+		 * Fetch the sense data, and tuck it away, in the required slot.  The
+		 * Adaptec automatically fetches it, and there is no guarantee that
+		 * we will still have it in the cdb when we come back
+		 */
 		if (ccb[mbo].tarstat == 2)
 			memcpy(tmp_cmd->sense_buffer, &ccb[mbo].cdb[ccb[mbo].cdblen],
 			       SCSI_SENSE_BUFFERSIZE);
@@ -383,7 +400,8 @@ static irqreturn_t aha1542_interrupt(int
 #endif
 		tmp_cmd->result = errstatus;
 		aha1542->int_cmds[mbo] = NULL;	/* This effectively frees up the mailbox slot, as
-						   far as queuecommand is concerned */
+						 * far as queuecommand is concerned
+						 */
 		my_done(tmp_cmd);
 		number_serviced++;
 	};
@@ -433,8 +451,10 @@ static int aha1542_queuecommand(struct S
 			goto out_free_chain;
 	}
 
-	/* Use the outgoing mailboxes in a round-robin fashion, because this
-	   is how the host adapter will scan for them */
+	/*
+	 * Use the outgoing mailboxes in a round-robin fashion, because this
+	 * is how the host adapter will scan for them
+	 */
 
 	spin_lock_irqsave(sh->host_lock, flags);
 	mbo = aha1542->aha1542_last_mbo_used + 1;
@@ -453,7 +473,8 @@ static int aha1542_queuecommand(struct S
 		panic("Unable to find empty mailbox for aha1542.\n");
 
 	aha1542->int_cmds[mbo] = cmd;	/* This will effectively prevent someone else from
-					   screwing with this cdb. */
+					 * screwing with this cdb.
+					 */
 
 	aha1542->aha1542_last_mbo_used = mbo;
 
@@ -565,8 +586,10 @@ static int aha1542_getconfig(struct Scsi
 		sh->dma_channel = 0;
 		break;
 	case 0:
-		/* This means that the adapter, although Adaptec 1542 compatible, doesn't use a DMA channel.
-		   Currently only aware of the BusLogic BT-445S VL-Bus adapter which needs this. */
+		/*
+		 * This means that the adapter, although Adaptec 1542 compatible, doesn't use a DMA channel.
+		 * Currently only aware of the BusLogic BT-445S VL-Bus adapter which needs this.
+		 */
 		sh->dma_channel = 0xFF;
 		break;
 	default:
@@ -600,8 +623,10 @@ static int aha1542_getconfig(struct Scsi
 	return 0;
 }
 
-/* This function should only be called for 1542C boards - we can detect
-   the special firmware settings and unlock the board */
+/*
+ * This function should only be called for 1542C boards - we can detect
+ * the special firmware settings and unlock the board
+ */
 
 static int aha1542_mbenable(struct Scsi_Host *sh)
 {
@@ -655,10 +680,11 @@ static int aha1542_query(struct Scsi_Hos
 
 	aha1542->bios_translation = BIOS_TRANSLATION_6432;	/* Default case */
 
-	/* For an AHA1740 series board, we ignore the board since there is a
-	   hardware bug which can lead to wrong blocks being returned if the board
-	   is operating in the 1542 emulation mode.  Since there is an extended mode
-	   driver, we simply ignore the board and let the 1740 driver pick it up.
+	/*
+	 * For an AHA1740 series board, we ignore the board since there is a
+	 * hardware bug which can lead to wrong blocks being returned if the board
+	 * is operating in the 1542 emulation mode.  Since there is an extended mode
+	 * driver, we simply ignore the board and let the 1740 driver pick it up.
 	 */
 
 	if (inquiry_result[0] == 0x43) {
@@ -666,8 +692,10 @@ static int aha1542_query(struct Scsi_Hos
 		return 1;
 	};
 
-	/* Always call this - boards that do not support extended bios translation
-	   will ignore the command, and we will set the proper default */
+	/*
+	 * Always call this - boards that do not support extended bios translation
+	 * will ignore the command, and we will set the proper default
+	 */
 
 	aha1542->bios_translation = aha1542_mbenable(sh);
 
@@ -877,8 +905,9 @@ static int aha1542_dev_reset(struct scsi
 		panic("Unable to find empty mailbox for aha1542.\n");
 
 	aha1542->int_cmds[mbo] = cmd;	/* This will effectively
-					   prevent someone else from
-					   screwing with this cdb. */
+					 * prevent someone else from
+					 * screwing with this cdb.
+					 */
 
 	aha1542->aha1542_last_mbo_used = mbo;
 
@@ -1063,8 +1092,10 @@ static int aha1542_pnp_probe(struct pnp_
 
 		io[indx] = pnp_port_start(pdev, 0);
 
-		/* The card can be queried for its DMA, we have
-		   the DMA set up that is enough */
+		/*
+		 * The card can be queried for its DMA, we have
+		 * the DMA set up that is enough
+		 */
 
 		dev_info(&pdev->dev, "ISAPnP found an AHA1535 at I/O 0x%03X", io[indx]);
 	}

Re: [PATCH 3/3] aha1542: fix multi-line comment style

[Hannes Reinecke]

On 1/10/21 5:49 PM, Sergey Shtylyov wrote:
> Some comments in this driver don't comply with the preferred multi-line
> comment style, as reported by 'scripts/checkpatch.pl':
> 
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
> 
> Fix those comments, along with the (unreported for some reason?) starts
> of the multi-line comments not being /* on their own line...
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
> ---
>   drivers/scsi/aha1542.c |  119 ++++++++++++++++++++++++++++++-------------------
>   1 file changed, 75 insertions(+), 44 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[James Bottomley]

On Sun, 2021-01-10 at 19:45 +0300, Sergey Shtylyov wrote:
> Here are 3 patches against the 'for-next' branch of Martin Petersen's
> 'scsi.git' repo.
> I'm trying to clean up and improve the driver comments...

Do you actually have one of these?  The last known working one was
owned by Ondrej Zary (added to cc).  Since they're ISA only and that
hardware is pretty much dead, this class of drivers might be a good
candidate for removal.

James

Re: [PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[Sergey Shtylyov]

On 1/12/21 7:09 PM, James Bottomley wrote:

>> Here are 3 patches against the 'for-next' branch of Martin Petersen's
>> 'scsi.git' repo. I'm trying to clean up and improve the driver comments...
> 
> Do you actually have one of these?  The last known working one was

   Unfortunately, no (I used to play with AHA-154x back in the 90s :-).
   Only have some NCR 5380 cards and 53C810, have the _paper_ manuals for those.. :-)

> owned by Ondrej Zary (added to cc).  Since they're ISA only and that
> hardware is pretty much dead, this class of drivers might be a good
> candidate for removal.

   I saw some recent patch activity with this driver and thought it's still supported...

> James

MBR, Sergei

Re: [PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[Martin K. Petersen]

Sergey,

> Here are 3 patches against the 'for-next' branch of Martin Petersen's
> 'scsi.git' repo.  I'm trying to clean up and improve the driver
> comments...

Typically don't take cleanups but I found the documentation bits
helpful.

Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/3] Improve comments in Adaptec AHA-154x driver

[Martin K. Petersen]

On Sun, 10 Jan 2021 19:45:34 +0300, Sergey Shtylyov wrote:

> Here are 3 patches against the 'for-next' branch of Martin Petersen's 'scsi.git' repo.
> I'm trying to clean up and improve the driver comments...
> 
> [1/3] aha1542: clarify 'struct ccb' comments
> [2/3] aha1542: kill trailing whitespace
> [3/3] aha1542: fix multi-line comment style

Applied to 5.12/scsi-queue, thanks!

[1/3] aha1542: clarify 'struct ccb' comments
      https://git.kernel.org/mkp/scsi/c/5637d5b769ab
[2/3] aha1542: kill trailing whitespace
      https://git.kernel.org/mkp/scsi/c/6075416cc412
[3/3] aha1542: fix multi-line comment style
      https://git.kernel.org/mkp/scsi/c/e4da5feb094c

-- 
Martin K. Petersen	Oracle Linux Engineering