All of lore.kernel.org
 help / color / mirror / Atom feed
From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH v2 2/3] nvmet: Export NVMe namespace attributes
Date: Fri, 14 Jun 2019 16:56:28 -0700	[thread overview]
Message-ID: <d69d61df-c03e-e0db-e9dd-fd367e5a0958@acm.org> (raw)
In-Reply-To: <BYAPR04MB57499B4C1225252183F01ADC86EE0@BYAPR04MB5749.namprd04.prod.outlook.com>

On 6/14/19 10:18 AM, Chaitanya Kulkarni wrote:
> Sorry for not being clear, what I meant is uintXXX_t vs uXX. e.g.
> instead of uint16_t ->u16, uint32_t ->u32. My comment refereed to the
> consistency of the data type and not changing the size of the variable.

Hi Chaitanya,

I think the rule is that uint32_t etc. must be used in uapi header 
files. I'm not sure whether there is a strict rule for other kernel code 
than uapi header files. But since the NVMe code uses u32 etc., I will 
make this patch consistent with the rest of the NVMe code.

Bart.

  parent reply	other threads:[~2019-06-14 23:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 21:06 [PATCH v2 0/3] NVMe 1.4 Identify Namespace Support Bart Van Assche
2019-06-10 21:06 ` [PATCH v2 1/3] nvme: Introduce NVMe 1.4 Identify Namespace fields in struct nvme_id_ns Bart Van Assche
2019-06-10 21:06 ` [PATCH v2 2/3] nvmet: Export NVMe namespace attributes Bart Van Assche
2019-06-14  4:42   ` Chaitanya Kulkarni
2019-06-14 15:31     ` Bart Van Assche
2019-06-14 17:18       ` Chaitanya Kulkarni
2019-06-14 17:43         ` Bart Van Assche
2019-06-14 17:53           ` Chaitanya Kulkarni
2019-06-14 23:56         ` Bart Van Assche [this message]
2019-06-10 21:06 ` [PATCH v2 3/3] nvme: Set physical block size and optimal I/O size according to NVMe 1.4 Bart Van Assche
2019-06-13  1:53   ` Martin K. Petersen
2019-06-13 17:57     ` Bart Van Assche
2019-06-13 23:57       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d69d61df-c03e-e0db-e9dd-fd367e5a0958@acm.org \
    --to=bvanassche@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.