Re: [PATCH 07/16] LoongArch: lib: General routines

["Jiaxun Yang" <jiaxun.yang@flygoat.com>]

在2024年6月16日六月 下午12:01，Heinrich Schuchardt写道：
> On 5/22/24 17:34, Jiaxun Yang wrote:
>> Add some common library routines for the architecture.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>>   arch/loongarch/lib/Makefile      |  7 ++++
>>   arch/loongarch/lib/asm-offsets.c | 66 ++++++++++++++++++++++++++++++++++++
>>   arch/loongarch/lib/boot.c        | 14 ++++++++
>>   arch/loongarch/lib/cache.c       | 73 ++++++++++++++++++++++++++++++++++++++++
>>   arch/loongarch/lib/reset.c       | 14 ++++++++
>>   arch/loongarch/lib/setjmp.S      | 52 ++++++++++++++++++++++++++++
>>   6 files changed, 226 insertions(+)
>>
>> diff --git a/arch/loongarch/lib/Makefile b/arch/loongarch/lib/Makefile
>> index 3dbed94cc624..3c17b9cd85af 100644
>> --- a/arch/loongarch/lib/Makefile
>> +++ b/arch/loongarch/lib/Makefile
>> @@ -3,3 +3,10 @@
>>   # Copyright (C) 2024 Jiaxun yang <jiaxun.yang@flygoat.com>
>>   #
>>
>> +obj-$(CONFIG_CMD_GO) += boot.o
>> +obj-y	+= cache.o
>> +obj-y	+= interrupts.o
>> +ifeq ($(CONFIG_$(SPL_)SYSRESET),)
>> +obj-y	+= reset.o
>> +endif
>> +obj-y	+= setjmp.o
>> diff --git a/arch/loongarch/lib/asm-offsets.c b/arch/loongarch/lib/asm-offsets.c
>> new file mode 100644
>> index 000000000000..e3f4c629b63d
>> --- /dev/null
>> +++ b/arch/loongarch/lib/asm-offsets.c
>> @@ -0,0 +1,66 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Copyright (C) 2024 Jiaxun Yang <jiaxun.yang@flygoat.com>
>> + *
>> + * From arch/x86/lib/asm-offsets.c
>> + *
>> + * This program is used to generate definitions needed by
>> + * assembly language modules.
>> + */
>> +
>> +#include <asm/global_data.h>
>> +#include <asm/ptrace.h>
>> +#include <linux/kbuild.h>
>> +
>> +static void __used output_ptreg_defines(void)
>> +{
>> +	COMMENT("LoongArch pt_regs offsets.");
>> +	OFFSET(PT_R0, pt_regs, regs[0]);
>> +	OFFSET(PT_R1, pt_regs, regs[1]);
>> +	OFFSET(PT_R2, pt_regs, regs[2]);
>> +	OFFSET(PT_R3, pt_regs, regs[3]);
>> +	OFFSET(PT_R4, pt_regs, regs[4]);
>> +	OFFSET(PT_R5, pt_regs, regs[5]);
>> +	OFFSET(PT_R6, pt_regs, regs[6]);
>> +	OFFSET(PT_R7, pt_regs, regs[7]);
>> +	OFFSET(PT_R8, pt_regs, regs[8]);
>> +	OFFSET(PT_R9, pt_regs, regs[9]);
>> +	OFFSET(PT_R10, pt_regs, regs[10]);
>> +	OFFSET(PT_R11, pt_regs, regs[11]);
>> +	OFFSET(PT_R12, pt_regs, regs[12]);
>> +	OFFSET(PT_R13, pt_regs, regs[13]);
>> +	OFFSET(PT_R14, pt_regs, regs[14]);
>> +	OFFSET(PT_R15, pt_regs, regs[15]);
>> +	OFFSET(PT_R16, pt_regs, regs[16]);
>> +	OFFSET(PT_R17, pt_regs, regs[17]);
>> +	OFFSET(PT_R18, pt_regs, regs[18]);
>> +	OFFSET(PT_R19, pt_regs, regs[19]);
>> +	OFFSET(PT_R20, pt_regs, regs[20]);
>> +	OFFSET(PT_R21, pt_regs, regs[21]);
>> +	OFFSET(PT_R22, pt_regs, regs[22]);
>> +	OFFSET(PT_R23, pt_regs, regs[23]);
>> +	OFFSET(PT_R24, pt_regs, regs[24]);
>> +	OFFSET(PT_R25, pt_regs, regs[25]);
>> +	OFFSET(PT_R26, pt_regs, regs[26]);
>> +	OFFSET(PT_R27, pt_regs, regs[27]);
>> +	OFFSET(PT_R28, pt_regs, regs[28]);
>> +	OFFSET(PT_R29, pt_regs, regs[29]);
>> +	OFFSET(PT_R30, pt_regs, regs[30]);
>> +	OFFSET(PT_R31, pt_regs, regs[31]);
>> +	OFFSET(PT_CRMD, pt_regs, csr_crmd);
>> +	OFFSET(PT_PRMD, pt_regs, csr_prmd);
>> +	OFFSET(PT_EUEN, pt_regs, csr_euen);
>> +	OFFSET(PT_ECFG, pt_regs, csr_ecfg);
>> +	OFFSET(PT_ESTAT, pt_regs, csr_estat);
>> +	OFFSET(PT_ERA, pt_regs, csr_era);
>> +	OFFSET(PT_BVADDR, pt_regs, csr_badvaddr);
>> +	OFFSET(PT_ORIG_A0, pt_regs, orig_a0);
>> +	DEFINE(PT_SIZE, sizeof(struct pt_regs));
>> +	BLANK();
>> +}
>> +
>> +int main(void)
>> +{
>> +	output_ptreg_defines();
>> +	return 0;
>> +}
>> diff --git a/arch/loongarch/lib/boot.c b/arch/loongarch/lib/boot.c
>> new file mode 100644
>> index 000000000000..327be16bb59f
>> --- /dev/null
>> +++ b/arch/loongarch/lib/boot.c
>> @@ -0,0 +1,14 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Copyright (C) 2024 Jiaxun Yang <jiaxun.yang@flygoat.com>
>> + */
>> +
>> +#include <asm/u-boot.h>
>> +
>> +unsigned long do_go_exec(ulong (*entry)(int, char * const []),
>> +			 int argc, char *const argv[])
>> +{
>> +	cleanup_before_linux();
>> +
>> +	return entry(argc, argv);
>> +}
>> diff --git a/arch/loongarch/lib/cache.c b/arch/loongarch/lib/cache.c
>> new file mode 100644
>> index 000000000000..54566edef8a3
>> --- /dev/null
>> +++ b/arch/loongarch/lib/cache.c
>> @@ -0,0 +1,73 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Copyright (C) 2024 Jiaxun Yang <jiaxun.yang@flygoat.com>
>> + */
>> +
>> +#include <cpu_func.h>
>> +#include <asm/cache.h>
>> +#include <asm/loongarch.h>
>> +
>> +void invalidate_icache_all(void)
>> +{
>> +	asm volatile ("\tibar 0\n"::);
>
> According to
> https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#_dbar
> this is not invalidating the instruction cache.
>
> After loading an image into memory and before executing it we must
> invalidate the instruction cache to ensure that the newly loaded code is
> executed.
>
> I guess you want to use CACOP here.

Yes, I haven't thought about that yet :-(
As this series is only concerning QEMU machine, I left all cache stuff blank.

I'll add it to future TODOs.

Thanks
- Jiaxun

>
>> +}
>> +
>> +__weak void flush_dcache_all(void)
>
> In cmd/cache.c we have another __weak implementation. How is the linke:w
> meant to know which one to use?
>
> I guess we need to fix cmd/cache.c. But that is beyond the scope of this
> series.
>
>> +{
>> +	asm volatile ("\tdbar 0\n"::);
>
> CACOP?
>
> Best regards
>
> Heinrich
>

-- 
- Jiaxun