All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] runqueue: Don't defer setscene tasks behind already completed tasks
@ 2026-11-15 22:09 Mark Hatle
  2026-11-16 13:32 ` [bitbake-devel] " Richard Purdie
  2026-11-17 11:50 ` Richard Purdie
  0 siblings, 2 replies; 4+ messages in thread
From: Mark Hatle @ 2026-11-15 22:09 UTC (permalink / raw)
  To: bitbake-devel

When a task completes, the first setscene task deferred against it is
released and any others are re-deferred behind that task. If the released
task had already completed (e.g. its setscene was skipped due to a valid
stamp), it never completes again, so the re-deferred tasks are never
released. Setscene then can't finish until the deadlock fallback forces
each one, printing "Runqueue deadlocked on deferred tasks".

This shows up with three or more multiconfigs sharing a task hash. Skip
already completed tasks when picking the new blocker.

AI-Generated: Uses GitHub Copilot
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
---
 lib/bb/runqueue.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index ef95eb46b..2a6b099b8 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -2112,6 +2112,10 @@ class RunQueueExecute:
                     bb.debug(1, "Deferred task %s now buildable" % t)
                     del self.sq_deferred[t]
                     update_scenequeue_data([t], self.sqdata, self.rqdata, self.rq, self.cooker, self.stampcache, self, summary=False)
+                    # A task which already completed will never complete again so must
+                    # not become the new blocker, else the remaining tasks never get released
+                    if t in self.runq_complete:
+                        continue
                     found = t
                 else:
                     bb.debug(1, "Deferring %s after %s" % (t, found))
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17 11:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15 22:09 [PATCH] runqueue: Don't defer setscene tasks behind already completed tasks Mark Hatle
2026-11-16 13:32 ` [bitbake-devel] " Richard Purdie
2026-11-16 14:16   ` Mark Hatle
2026-11-17 11:50 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.