From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
"Emilio G . Cota" <cota@braap.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [Qemu-arm] [PATCH 3/6] accel/tcg: Handle get_page_addr_code() returning -1 in tb_check_watchpoint()
Date: Tue, 10 Jul 2018 11:27:48 -0700 [thread overview]
Message-ID: <e24ed93f-e386-ec00-0d83-1bd5b68db0e0@twiddle.net> (raw)
In-Reply-To: <20180710160013.26559-4-peter.maydell@linaro.org>
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> When we support execution from non-RAM MMIO regions, get_page_addr_code()
> will return -1 to indicate that there is no RAM at the requested address.
> Handle this in tb_check_watchpoint() -- if the exception happened for a
> PC which doesn't correspond to RAM then there is no need to invalidate
> any TBs, because the one-instruction TB will not have been cached.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> accel/tcg/translate-all.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Emilio G . Cota" <cota@braap.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"KONRAD Frederic" <frederic.konrad@adacore.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] accel/tcg: Handle get_page_addr_code() returning -1 in tb_check_watchpoint()
Date: Tue, 10 Jul 2018 11:27:48 -0700 [thread overview]
Message-ID: <e24ed93f-e386-ec00-0d83-1bd5b68db0e0@twiddle.net> (raw)
In-Reply-To: <20180710160013.26559-4-peter.maydell@linaro.org>
On 07/10/2018 09:00 AM, Peter Maydell wrote:
> When we support execution from non-RAM MMIO regions, get_page_addr_code()
> will return -1 to indicate that there is no RAM at the requested address.
> Handle this in tb_check_watchpoint() -- if the exception happened for a
> PC which doesn't correspond to RAM then there is no need to invalidate
> any TBs, because the one-instruction TB will not have been cached.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> accel/tcg/translate-all.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-07-10 18:28 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 16:00 [Qemu-arm] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 16:00 ` [Qemu-arm] [PATCH 1/6] accel/tcg: Pass read access type through to io_readx() Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 18:19 ` Richard Henderson
2018-07-10 18:19 ` Richard Henderson
2018-07-11 14:06 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-11 14:06 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-07-10 16:00 ` [Qemu-devel] [PATCH 2/6] accel/tcg: Handle get_page_addr_code() returning -1 in hashtable lookups Peter Maydell
2018-07-10 16:00 ` Peter Maydell
2018-07-10 18:23 ` [Qemu-arm] " Richard Henderson
2018-07-10 18:23 ` [Qemu-devel] " Richard Henderson
2018-07-13 16:44 ` [Qemu-arm] " Emilio G. Cota
2018-07-13 16:44 ` [Qemu-devel] " Emilio G. Cota
2018-07-10 16:00 ` [Qemu-arm] [PATCH 3/6] accel/tcg: Handle get_page_addr_code() returning -1 in tb_check_watchpoint() Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 18:27 ` Richard Henderson [this message]
2018-07-10 18:27 ` Richard Henderson
2018-07-10 16:00 ` [Qemu-arm] [PATCH 4/6] accel/tcg: tb_gen_code(): Create single-insn TB for execution from non-RAM Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 18:30 ` [Qemu-arm] " Richard Henderson
2018-07-10 18:30 ` [Qemu-devel] " Richard Henderson
2018-07-13 16:41 ` [Qemu-arm] " Emilio G. Cota
2018-07-13 16:41 ` [Qemu-devel] " Emilio G. Cota
2018-07-10 16:00 ` [Qemu-arm] [PATCH 5/6] accel/tcg: Return -1 for execution from MMIO regions in get_page_addr_code() Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 18:33 ` [Qemu-arm] " Richard Henderson
2018-07-10 18:33 ` [Qemu-devel] " Richard Henderson
2018-07-11 14:36 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-11-14 17:19 ` [Qemu-arm] [Qemu-devel] " Thomas Huth
2018-11-14 17:19 ` Thomas Huth
2018-11-15 7:32 ` [Qemu-arm] " Richard Henderson
2018-11-15 7:32 ` Richard Henderson
2018-11-15 13:53 ` Peter Maydell
2018-11-15 13:53 ` Peter Maydell
2018-11-15 16:00 ` Richard Henderson
2018-11-15 16:00 ` Richard Henderson
2018-07-10 16:00 ` [Qemu-arm] [PATCH 6/6] target/arm: Allow execution from small regions Peter Maydell
2018-07-10 16:00 ` [Qemu-devel] " Peter Maydell
2018-07-10 18:34 ` [Qemu-arm] " Richard Henderson
2018-07-10 18:34 ` [Qemu-devel] " Richard Henderson
2018-07-11 15:09 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-11 15:09 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-07-11 4:21 ` [Qemu-arm] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions Philippe Mathieu-Daudé
2018-07-11 4:21 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-07-12 16:37 ` Peter Maydell
2018-07-12 16:37 ` Peter Maydell
2018-07-13 15:13 ` Peter Maydell
2018-07-13 15:13 ` [Qemu-devel] " Peter Maydell
2018-07-16 12:30 ` KONRAD Frederic
2018-07-16 12:30 ` [Qemu-devel] " KONRAD Frederic
2018-07-16 13:02 ` Peter Maydell
2018-07-16 13:02 ` Peter Maydell
2018-07-23 14:57 ` [Qemu-arm] " Cédric Le Goater
2018-07-23 14:57 ` [Qemu-devel] " Cédric Le Goater
2018-07-23 15:17 ` Peter Maydell
2018-07-23 15:17 ` Peter Maydell
2018-07-23 15:51 ` [Qemu-arm] " Cédric Le Goater
2018-07-23 15:51 ` [Qemu-devel] " Cédric Le Goater
2018-07-23 15:11 ` [Qemu-arm] " Cédric Le Goater
2018-07-23 15:11 ` [Qemu-devel] " Cédric Le Goater
2018-07-24 12:23 ` [Qemu-arm] " Peter Maydell
2018-07-24 12:23 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e24ed93f-e386-ec00-0d83-1bd5b68db0e0@twiddle.net \
--to=rth@twiddle.net \
--cc=clg@kaod.org \
--cc=cota@braap.org \
--cc=frederic.konrad@adacore.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.