Re: [PATCH v3 04/10] dt-bindings: pinctrl: samsung: Add compatible for ARTPEC-8 SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 01/09/2025 05:41, Ravi Patel wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 31 August 2025 18:55
>> To: Ravi Patel <ravi.patel@samsung.com>; jesper.nilsson@axis.com; mturquette@baylibre.com; sboyd@kernel.org; robh@kernel.org;
>> krzk+dt@kernel.org; conor+dt@kernel.org; s.nawrocki@samsung.com; cw00.choi@samsung.com; alim.akhtar@samsung.com;
>> linus.walleij@linaro.org; tomasz.figa@gmail.com; catalin.marinas@arm.com; will@kernel.org; arnd@arndb.de
>> Cc: ksk4725@coasia.com; kenkim@coasia.com; pjsin865@coasia.com; gwk1013@coasia.com; hgkim05@coasia.com;
>> mingyoungbo@coasia.com; smn1196@coasia.com; pankaj.dubey@samsung.com; shradha.t@samsung.com; inbaraj.e@samsung.com;
>> swathi.ks@samsung.com; hrishikesh.d@samsung.com; dj76.yang@samsung.com; hypmean.kim@samsung.com; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-arm-kernel@axis.com; linux-
>> clk@vger.kernel.org; devicetree@vger.kernel.org; linux-gpio@vger.kernel.org; soc@lists.linux.dev
>> Subject: Re: [PATCH v3 04/10] dt-bindings: pinctrl: samsung: Add compatible for ARTPEC-8 SoC
>>
>> On 25/08/2025 13:44, Ravi Patel wrote:
>>> From: SeonGu Kang <ksk4725@coasia.com>
>>>
>>> Document the compatible string for ARTPEC-8 SoC pinctrl block,
>>> which is similar to other Samsung SoC pinctrl blocks.
>>>
>>> Signed-off-by: SeonGu Kang <ksk4725@coasia.com>
>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
>>> ---
>>>  Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>>
>> No wakeup-eint interrupts here? samsung,pinctrl-wakeup-interrupt.yaml?
> 
> I don't see any use case for external wake-up interrupt here (as of now).

It is more about hardware, not use case. Does this hardware has EINT
wakeup pin banks?

> So wakeup-eint entry is not present in dts and yaml both.



Best regards,
Krzysztof