From: <Lewis.Hanly@microchip.com>
To: <andy.shevchenko@gmail.com>, <linus.walleij@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <Conor.Dooley@microchip.com>,
<brgl@bgdev.pl>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <palmer@dabbelt.com>,
<maz@kernel.org>, <Daire.McNamara@microchip.com>
Subject: Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Mon, 5 Sep 2022 10:46:19 +0000 [thread overview]
Message-ID: <e46a88a8b6b60e56db82c3a42f7ba38068aadecf.camel@microchip.com> (raw)
In-Reply-To: <CAHp75Vc4cMGBdJpOsRMDLWU+6+eYwbsF3-Mz40-KazLGhwkHMA@mail.gmail.com>
On Thu, 2022-09-01 at 00:04 +0300, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Mon, Aug 22, 2022 at 2:30 PM Linus Walleij <
> linus.walleij@linaro.org> wrote:
> > On Mon, Aug 15, 2022 at 2:08 PM <lewis.hanly@microchip.com> wrote:
>
> ...
>
> > This looks like textbook example of a driver that can use
> > CONFIG_GPIO_GENERIC
> > See e.g. drivers/gpio/gpio-ftgpio010.c for an example
> > of how to use bgpio_init() to set up the helper library to handle
> > the GPIO side of things and combine it with an irqchip.
> > You get get/set_multiple() for free with this approach.
> > Also see documentation for bgpio_init() in
> > drivers/gpio/gpio-mmio.c.
>
> I would also suggest looking at gpio-regmap.c.
Thanks Andy I will review the regmap.c file
>
> --
> With Best Regards,
> Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: <Lewis.Hanly@microchip.com>
To: <andy.shevchenko@gmail.com>, <linus.walleij@linaro.org>
Cc: <linux-riscv@lists.infradead.org>, <Conor.Dooley@microchip.com>,
<brgl@bgdev.pl>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <palmer@dabbelt.com>,
<maz@kernel.org>, <Daire.McNamara@microchip.com>
Subject: Re: [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support
Date: Mon, 5 Sep 2022 10:46:19 +0000 [thread overview]
Message-ID: <e46a88a8b6b60e56db82c3a42f7ba38068aadecf.camel@microchip.com> (raw)
In-Reply-To: <CAHp75Vc4cMGBdJpOsRMDLWU+6+eYwbsF3-Mz40-KazLGhwkHMA@mail.gmail.com>
On Thu, 2022-09-01 at 00:04 +0300, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
>
> On Mon, Aug 22, 2022 at 2:30 PM Linus Walleij <
> linus.walleij@linaro.org> wrote:
> > On Mon, Aug 15, 2022 at 2:08 PM <lewis.hanly@microchip.com> wrote:
>
> ...
>
> > This looks like textbook example of a driver that can use
> > CONFIG_GPIO_GENERIC
> > See e.g. drivers/gpio/gpio-ftgpio010.c for an example
> > of how to use bgpio_init() to set up the helper library to handle
> > the GPIO side of things and combine it with an irqchip.
> > You get get/set_multiple() for free with this approach.
> > Also see documentation for bgpio_init() in
> > drivers/gpio/gpio-mmio.c.
>
> I would also suggest looking at gpio-regmap.c.
Thanks Andy I will review the regmap.c file
>
> --
> With Best Regards,
> Andy Shevchenko
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-05 10:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 12:08 [PATCH v6 0/1] Add Polarfire SoC GPIO support lewis.hanly
2022-08-15 12:08 ` lewis.hanly
2022-08-15 12:08 ` [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support lewis.hanly
2022-08-15 12:08 ` lewis.hanly
2022-08-15 16:18 ` Conor.Dooley
2022-08-15 16:18 ` Conor.Dooley
2022-08-22 11:28 ` Linus Walleij
2022-08-22 11:28 ` Linus Walleij
2022-08-30 4:50 ` Lewis.Hanly
2022-08-30 4:50 ` Lewis.Hanly
2022-08-31 13:19 ` Linus Walleij
2022-08-31 13:19 ` Linus Walleij
2022-09-05 10:45 ` Lewis.Hanly
2022-09-05 10:45 ` Lewis.Hanly
2022-09-06 13:09 ` Linus Walleij
2022-09-06 13:09 ` Linus Walleij
2022-08-31 21:04 ` Andy Shevchenko
2022-08-31 21:04 ` Andy Shevchenko
2022-09-05 10:46 ` Lewis.Hanly [this message]
2022-09-05 10:46 ` Lewis.Hanly
2022-08-15 12:16 ` [PATCH v6 0/1] Add Polarfire SoC GPIO support Marc Zyngier
2022-08-15 12:16 ` Marc Zyngier
-- strict thread matches above, loose matches on Subject: below --
2022-08-18 11:08 [PATCH v6 1/1] gpio: mpfs: add polarfire soc gpio support kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46a88a8b6b60e56db82c3a42f7ba38068aadecf.camel@microchip.com \
--to=lewis.hanly@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.