* [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling
@ 2026-10-08 10:00 Andrzej Kacprowski
2026-10-08 10:31 ` Wachowski, Karol
2026-10-08 15:46 ` Jeff Hugo
0 siblings, 2 replies; 4+ messages in thread
From: Andrzej Kacprowski @ 2026-10-08 10:00 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, jeff.hugo, karol.wachowski, lizhi.hou,
dawid.osuchowski, Andrzej Kacprowski
In FW_TEST mode, boot the firmware but skip the ready wait and all
subsequent firmware communication. The firmware test reports its
results through the firmware log.
Disable driver timeouts in this mode so timeout handling does not
interrupt the firmware test.
Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_drv.c | 3 +++
drivers/accel/ivpu/ivpu_hw.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index 6b71edf566e7..8c3fb0f01a31 100644
--- a/drivers/accel/ivpu/ivpu_drv.c
+++ b/drivers/accel/ivpu/ivpu_drv.c
@@ -539,6 +539,9 @@ int ivpu_boot(struct ivpu_device *vdev)
ivpu_hw_irq_enable(vdev);
ivpu_ipc_enable(vdev);
+ if (ivpu_test_mode & IVPU_TEST_MODE_FW_TEST)
+ return 0;
+
if (!ivpu_fw_is_warm_boot(vdev)) {
ret = ivpu_pm_dct_init(vdev);
if (ret)
diff --git a/drivers/accel/ivpu/ivpu_hw.c b/drivers/accel/ivpu/ivpu_hw.c
index 59a5de8d9270..8b63140e3160 100644
--- a/drivers/accel/ivpu/ivpu_hw.c
+++ b/drivers/accel/ivpu/ivpu_hw.c
@@ -94,7 +94,7 @@ static void wa_init(struct ivpu_device *vdev)
static void timeouts_init(struct ivpu_device *vdev)
{
- if (ivpu_test_mode & IVPU_TEST_MODE_DISABLE_TIMEOUTS) {
+ if (ivpu_test_mode & (IVPU_TEST_MODE_DISABLE_TIMEOUTS | IVPU_TEST_MODE_FW_TEST)) {
/* in milliseconds, negative value disables the timeout */
vdev->timeout.boot = -1;
vdev->timeout.jsm = -1;
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling
2026-10-08 10:00 [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling Andrzej Kacprowski
@ 2026-10-08 10:31 ` Wachowski, Karol
2026-10-08 15:46 ` Jeff Hugo
1 sibling, 0 replies; 4+ messages in thread
From: Wachowski, Karol @ 2026-10-08 10:31 UTC (permalink / raw)
To: Andrzej Kacprowski, dri-devel
Cc: oded.gabbay, jeff.hugo, lizhi.hou, dawid.osuchowski
On 08-Oct-26 12:00, Andrzej Kacprowski wrote:
> In FW_TEST mode, boot the firmware but skip the ready wait and all
> subsequent firmware communication. The firmware test reports its
> results through the firmware log.
>
> Disable driver timeouts in this mode so timeout handling does not
> interrupt the firmware test.
>
> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_drv.c | 3 +++
> drivers/accel/ivpu/ivpu_hw.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index 6b71edf566e7..8c3fb0f01a31 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -539,6 +539,9 @@ int ivpu_boot(struct ivpu_device *vdev)
> ivpu_hw_irq_enable(vdev);
> ivpu_ipc_enable(vdev);
>
> + if (ivpu_test_mode & IVPU_TEST_MODE_FW_TEST)
> + return 0;
> +
> if (!ivpu_fw_is_warm_boot(vdev)) {
> ret = ivpu_pm_dct_init(vdev);
> if (ret)
> diff --git a/drivers/accel/ivpu/ivpu_hw.c b/drivers/accel/ivpu/ivpu_hw.c
> index 59a5de8d9270..8b63140e3160 100644
> --- a/drivers/accel/ivpu/ivpu_hw.c
> +++ b/drivers/accel/ivpu/ivpu_hw.c
> @@ -94,7 +94,7 @@ static void wa_init(struct ivpu_device *vdev)
>
> static void timeouts_init(struct ivpu_device *vdev)
> {
> - if (ivpu_test_mode & IVPU_TEST_MODE_DISABLE_TIMEOUTS) {
> + if (ivpu_test_mode & (IVPU_TEST_MODE_DISABLE_TIMEOUTS | IVPU_TEST_MODE_FW_TEST)) {
> /* in milliseconds, negative value disables the timeout */
> vdev->timeout.boot = -1;
> vdev->timeout.jsm = -1;
Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling
2026-10-08 10:00 [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling Andrzej Kacprowski
2026-10-08 10:31 ` Wachowski, Karol
@ 2026-10-08 15:46 ` Jeff Hugo
2026-10-09 6:20 ` Wachowski, Karol
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Hugo @ 2026-10-08 15:46 UTC (permalink / raw)
To: Andrzej Kacprowski, dri-devel
Cc: oded.gabbay, karol.wachowski, lizhi.hou, dawid.osuchowski
On 10/8/2026 4:00 AM, Andrzej Kacprowski wrote:
> In FW_TEST mode, boot the firmware but skip the ready wait and all
> subsequent firmware communication. The firmware test reports its
> results through the firmware log.
>
> Disable driver timeouts in this mode so timeout handling does not
> interrupt the firmware test.
>
> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling
2026-10-08 15:46 ` Jeff Hugo
@ 2026-10-09 6:20 ` Wachowski, Karol
0 siblings, 0 replies; 4+ messages in thread
From: Wachowski, Karol @ 2026-10-09 6:20 UTC (permalink / raw)
To: Jeff Hugo, Andrzej Kacprowski, dri-devel
Cc: oded.gabbay, lizhi.hou, dawid.osuchowski
On 08-Oct-26 17:46, Jeff Hugo wrote:
> On 10/8/2026 4:00 AM, Andrzej Kacprowski wrote:
>> In FW_TEST mode, boot the firmware but skip the ready wait and all
>> subsequent firmware communication. The firmware test reports its
>> results through the firmware log.
>>
>> Disable driver timeouts in this mode so timeout handling does not
>> interrupt the firmware test.
>>
>> Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@linux.intel.com>
>
> Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Thanks, applied to drm-misc-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-09 6:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-08 10:00 [PATCH v3] accel/ivpu: Improve IVPU_TEST_MODE_FW_TEST handling Andrzej Kacprowski
2026-10-08 10:31 ` Wachowski, Karol
2026-10-08 15:46 ` Jeff Hugo
2026-10-09 6:20 ` Wachowski, Karol
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.