* [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
@ 2026-06-16 5:50 Enlin Mu
2026-06-16 5:59 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Enlin Mu @ 2026-06-16 5:50 UTC (permalink / raw)
To: tglx, linux-kernel, enlin.mu, enlin.mu; +Cc: linux-hardening
Accelerate the entropy pool initialization process
Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
---
kernel/irq/chip.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index de754db414d1..cbbd7e7d1156 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
trace_irq_handler_entry(irq, action);
res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
trace_irq_handler_exit(irq, action, res);
+ add_interrupt_randomness(irq);
} else {
bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 5:50 [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler Enlin Mu
@ 2026-06-16 5:59 ` Greg KH
2026-06-16 6:26 ` enlin.mu
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2026-06-16 5:59 UTC (permalink / raw)
To: Enlin Mu; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On Tue, Jun 16, 2026 at 01:50:42PM +0800, Enlin Mu wrote:
> Accelerate the entropy pool initialization process
How? Please explain.
> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
> ---
> kernel/irq/chip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> index de754db414d1..cbbd7e7d1156 100644
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
> trace_irq_handler_entry(irq, action);
> res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
> trace_irq_handler_exit(irq, action, res);
> + add_interrupt_randomness(irq);
Are you sure this does anything measurable?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 5:59 ` Greg KH
@ 2026-06-16 6:26 ` enlin.mu
2026-06-16 6:48 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: enlin.mu @ 2026-06-16 6:26 UTC (permalink / raw)
To: Greg KH; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
Hi KH
hardware: raspberrypi 5
other patch(These two locations impact the entropy pool acceleration.
comment them out temporarily):
acer@raspberrypi:linux $ git diff drivers/of/fdt.c
drivers/char/hw_random/iproc-rng200.c
diff --git a/drivers/char/hw_random/iproc-rng200.c
b/drivers/char/hw_random/iproc-rng200.c
index 33bc28f429f6..af105faa88c6 100644
--- a/drivers/char/hw_random/iproc-rng200.c
+++ b/drivers/char/hw_random/iproc-rng200.c
@@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
};
static const struct of_device_id iproc_rng200_of_match[] = {
- { .compatible = "brcm,bcm2711-rng200", },
- { .compatible = "brcm,bcm7211-rng200", },
- { .compatible = "brcm,bcm7278-rng200", },
- { .compatible = "brcm,iproc-rng200", },
+ { .compatible = "brcm,bcm2711-rng2000", },
+ { .compatible = "brcm,bcm7211-rng2000", },
+ { .compatible = "brcm,bcm7278-rng2000", },
+ { .compatible = "brcm,iproc-rng2000", },
{},
};
MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 331646d667b9..13308d58785d 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
if (rng_seed && l > 0) {
- add_bootloader_randomness(rng_seed, l);
+ //add_bootloader_randomness(rng_seed, l);
/* try to clear seed so it won't be found. */
fdt_nop_property(initial_boot_params, node, "rng-seed");
acer@raspberrypi:linux $
Before testing:
acer@raspberrypi:linux $ dmesg | grep rng
[ 3.360898] random: crng init done
After testing:
acer@raspberrypi:~ $ dmesg | grep rng
[ 2.808880] random: crng init done
On 2026/6/16 13:59, Greg KH wrote:
> On Tue, Jun 16, 2026 at 01:50:42PM +0800, Enlin Mu wrote:
>> Accelerate the entropy pool initialization process
>
> How? Please explain.
>
>> Signed-off-by: Enlin Mu <enlin.mu@linux.dev>
>> ---
>> kernel/irq/chip.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
>> index de754db414d1..cbbd7e7d1156 100644
>> --- a/kernel/irq/chip.c
>> +++ b/kernel/irq/chip.c
>> @@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
>> trace_irq_handler_entry(irq, action);
>> res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
>> trace_irq_handler_exit(irq, action, res);
>> + add_interrupt_randomness(irq);
>
> Are you sure this does anything measurable?
>
> thanks,
>
> greg k-h
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 6:26 ` enlin.mu
@ 2026-06-16 6:48 ` Greg KH
2026-06-16 7:17 ` enlin.mu
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2026-06-16 6:48 UTC (permalink / raw)
To: enlin.mu; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
> Hi KH
>
> hardware: raspberrypi 5
>
> other patch(These two locations impact the entropy pool acceleration.
> comment them out temporarily):
> acer@raspberrypi:linux $ git diff drivers/of/fdt.c
> drivers/char/hw_random/iproc-rng200.c
> diff --git a/drivers/char/hw_random/iproc-rng200.c
> b/drivers/char/hw_random/iproc-rng200.c
> index 33bc28f429f6..af105faa88c6 100644
> --- a/drivers/char/hw_random/iproc-rng200.c
> +++ b/drivers/char/hw_random/iproc-rng200.c
> @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
> };
>
> static const struct of_device_id iproc_rng200_of_match[] = {
> - { .compatible = "brcm,bcm2711-rng200", },
> - { .compatible = "brcm,bcm7211-rng200", },
> - { .compatible = "brcm,bcm7278-rng200", },
> - { .compatible = "brcm,iproc-rng200", },
> + { .compatible = "brcm,bcm2711-rng2000", },
> + { .compatible = "brcm,bcm7211-rng2000", },
> + { .compatible = "brcm,bcm7278-rng2000", },
> + { .compatible = "brcm,iproc-rng2000", },
What is this change for?
> {},
> };
> MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 331646d667b9..13308d58785d 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
>
> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
> if (rng_seed && l > 0) {
> - add_bootloader_randomness(rng_seed, l);
> + //add_bootloader_randomness(rng_seed, l);
Why did you comment this out?
>
> /* try to clear seed so it won't be found. */
> fdt_nop_property(initial_boot_params, node, "rng-seed");
> acer@raspberrypi:linux $
>
> Before testing:
> acer@raspberrypi:linux $ dmesg | grep rng
> [ 3.360898] random: crng init done
>
>
> After testing:
> acer@raspberrypi:~ $ dmesg | grep rng
> [ 2.808880] random: crng init done
I think people have talked about irq "randomness" lots of time in the
past, you need to provide lots of real documentation about why this time
it is somehow "different".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 6:48 ` Greg KH
@ 2026-06-16 7:17 ` enlin.mu
2026-06-16 7:24 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: enlin.mu @ 2026-06-16 7:17 UTC (permalink / raw)
To: Greg KH; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On 2026/6/16 14:48, Greg KH wrote:
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
>> Hi KH
>>
>> hardware: raspberrypi 5
>>
>> other patch(These two locations impact the entropy pool acceleration.
>> comment them out temporarily):
>> acer@raspberrypi:linux $ git diff drivers/of/fdt.c
>> drivers/char/hw_random/iproc-rng200.c
>> diff --git a/drivers/char/hw_random/iproc-rng200.c
>> b/drivers/char/hw_random/iproc-rng200.c
>> index 33bc28f429f6..af105faa88c6 100644
>> --- a/drivers/char/hw_random/iproc-rng200.c
>> +++ b/drivers/char/hw_random/iproc-rng200.c
>> @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
>> };
>>
>> static const struct of_device_id iproc_rng200_of_match[] = {
>> - { .compatible = "brcm,bcm2711-rng200", },
>> - { .compatible = "brcm,bcm7211-rng200", },
>> - { .compatible = "brcm,bcm7278-rng200", },
>> - { .compatible = "brcm,iproc-rng200", },
>> + { .compatible = "brcm,bcm2711-rng2000", },
>> + { .compatible = "brcm,bcm7211-rng2000", },
>> + { .compatible = "brcm,bcm7278-rng2000", },
>> + { .compatible = "brcm,iproc-rng2000", },
>
> What is this change for?
This driver accelerates the initialization of the entropy pool. If this
dirver is added, the optimization effect of my patch will no longer be
clearly observable.
>
>
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>> index 331646d667b9..13308d58785d 100644
>> --- a/drivers/of/fdt.c
>> +++ b/drivers/of/fdt.c
>> @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
>>
>> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>> if (rng_seed && l > 0) {
>> - add_bootloader_randomness(rng_seed, l);
>> + //add_bootloader_randomness(rng_seed, l);
>
> Why did you comment this out?
Before the kernel boots, the Raspberry Pi bootloader injects the
rng-seed property into the kernel's Device Tree to accelerate entropy pool
initialization. Therefore, I need to temporarily comment this out
to avoid interfering with the testing of my current patch.
>
>
>>
>> /* try to clear seed so it won't be found. */
>> fdt_nop_property(initial_boot_params, node, "rng-seed");
>> acer@raspberrypi:linux $
>>
>> Before testing:
>> acer@raspberrypi:linux $ dmesg | grep rng
>> [ 3.360898] random: crng init done
>>
>>
>> After testing:
>> acer@raspberrypi:~ $ dmesg | grep rng
>> [ 2.808880] random: crng init done
>
> I think people have talked about irq "randomness" lots of time in the
> past, you need to provide lots of real documentation about why this time
> it is somehow "different".
The test results shown above are just from a single run. Based on
multipe test runs, the overall performance gain is approximately 0.3 to
0.5 seconds.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 7:17 ` enlin.mu
@ 2026-06-16 7:24 ` Greg KH
2026-06-16 7:40 ` enlin.mu
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2026-06-16 7:24 UTC (permalink / raw)
To: enlin.mu; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On Tue, Jun 16, 2026 at 03:17:00PM +0800, enlin.mu wrote:
>
>
> On 2026/6/16 14:48, Greg KH wrote:
> > A: http://en.wikipedia.org/wiki/Top_post
> > Q: Were do I find info about this thing called top-posting?
> > A: Because it messes up the order in which people normally read text.
> > Q: Why is top-posting such a bad thing?
> > A: Top-posting.
> > Q: What is the most annoying thing in e-mail?
> >
> > A: No.
> > Q: Should I include quotations after my reply?
> >
> > http://daringfireball.net/2007/07/on_top
> >
> > On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
> > > Hi KH
> > >
> > > hardware: raspberrypi 5
> > >
> > > other patch(These two locations impact the entropy pool acceleration.
> > > comment them out temporarily):
> > > acer@raspberrypi:linux $ git diff drivers/of/fdt.c
> > > drivers/char/hw_random/iproc-rng200.c
> > > diff --git a/drivers/char/hw_random/iproc-rng200.c
> > > b/drivers/char/hw_random/iproc-rng200.c
> > > index 33bc28f429f6..af105faa88c6 100644
> > > --- a/drivers/char/hw_random/iproc-rng200.c
> > > +++ b/drivers/char/hw_random/iproc-rng200.c
> > > @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
> > > };
> > >
> > > static const struct of_device_id iproc_rng200_of_match[] = {
> > > - { .compatible = "brcm,bcm2711-rng200", },
> > > - { .compatible = "brcm,bcm7211-rng200", },
> > > - { .compatible = "brcm,bcm7278-rng200", },
> > > - { .compatible = "brcm,iproc-rng200", },
> > > + { .compatible = "brcm,bcm2711-rng2000", },
> > > + { .compatible = "brcm,bcm7211-rng2000", },
> > > + { .compatible = "brcm,bcm7278-rng2000", },
> > > + { .compatible = "brcm,iproc-rng2000", },
> >
> > What is this change for?
> This driver accelerates the initialization of the entropy pool. If this
> dirver is added, the optimization effect of my patch will no longer be
> clearly observable.
Great, obviously your patch is not needed!
>
> >
> >
> > > {},
> > > };
> > > MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
> > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> > > index 331646d667b9..13308d58785d 100644
> > > --- a/drivers/of/fdt.c
> > > +++ b/drivers/of/fdt.c
> > > @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
> > >
> > > rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
> > > if (rng_seed && l > 0) {
> > > - add_bootloader_randomness(rng_seed, l);
> > > + //add_bootloader_randomness(rng_seed, l);
> >
> > Why did you comment this out?
> Before the kernel boots, the Raspberry Pi bootloader injects the rng-seed
> property into the kernel's Device Tree to accelerate entropy pool
> initialization. Therefore, I need to temporarily comment this out
> to avoid interfering with the testing of my current patch.
Again, that seems like the correct fix, don't change the common code
path of all systems just because you don't want to accept the changes
that have already been made for your platform to resolve this very
issue!
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 7:24 ` Greg KH
@ 2026-06-16 7:40 ` enlin.mu
2026-06-16 7:49 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: enlin.mu @ 2026-06-16 7:40 UTC (permalink / raw)
To: Greg KH; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On 2026/6/16 15:24, Greg KH wrote:
> On Tue, Jun 16, 2026 at 03:17:00PM +0800, enlin.mu wrote:
>>
>>
>> On 2026/6/16 14:48, Greg KH wrote:
>>> A: http://en.wikipedia.org/wiki/Top_post
>>> Q: Were do I find info about this thing called top-posting?
>>> A: Because it messes up the order in which people normally read text.
>>> Q: Why is top-posting such a bad thing?
>>> A: Top-posting.
>>> Q: What is the most annoying thing in e-mail?
>>>
>>> A: No.
>>> Q: Should I include quotations after my reply?
>>>
>>> http://daringfireball.net/2007/07/on_top
>>>
>>> On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
>>>> Hi KH
>>>>
>>>> hardware: raspberrypi 5
>>>>
>>>> other patch(These two locations impact the entropy pool acceleration.
>>>> comment them out temporarily):
>>>> acer@raspberrypi:linux $ git diff drivers/of/fdt.c
>>>> drivers/char/hw_random/iproc-rng200.c
>>>> diff --git a/drivers/char/hw_random/iproc-rng200.c
>>>> b/drivers/char/hw_random/iproc-rng200.c
>>>> index 33bc28f429f6..af105faa88c6 100644
>>>> --- a/drivers/char/hw_random/iproc-rng200.c
>>>> +++ b/drivers/char/hw_random/iproc-rng200.c
>>>> @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
>>>> };
>>>>
>>>> static const struct of_device_id iproc_rng200_of_match[] = {
>>>> - { .compatible = "brcm,bcm2711-rng200", },
>>>> - { .compatible = "brcm,bcm7211-rng200", },
>>>> - { .compatible = "brcm,bcm7278-rng200", },
>>>> - { .compatible = "brcm,iproc-rng200", },
>>>> + { .compatible = "brcm,bcm2711-rng2000", },
>>>> + { .compatible = "brcm,bcm7211-rng2000", },
>>>> + { .compatible = "brcm,bcm7278-rng2000", },
>>>> + { .compatible = "brcm,iproc-rng2000", },
>>>
>>> What is this change for?
>> This driver accelerates the initialization of the entropy pool. If this
>> dirver is added, the optimization effect of my patch will no longer be
>> clearly observable.
>
> Great, obviously your patch is not needed!
>
>>
>>>
>>>
>>>> {},
>>>> };
>>>> MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
>>>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>>>> index 331646d667b9..13308d58785d 100644
>>>> --- a/drivers/of/fdt.c
>>>> +++ b/drivers/of/fdt.c
>>>> @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
>>>>
>>>> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>>>> if (rng_seed && l > 0) {
>>>> - add_bootloader_randomness(rng_seed, l);
>>>> + //add_bootloader_randomness(rng_seed, l);
>>>
>>> Why did you comment this out?
>> Before the kernel boots, the Raspberry Pi bootloader injects the rng-seed
>> property into the kernel's Device Tree to accelerate entropy pool
>> initialization. Therefore, I need to temporarily comment this out
>> to avoid interfering with the testing of my current patch.
>
> Again, that seems like the correct fix, don't change the common code
> path of all systems just because you don't want to accept the changes
> that have already been made for your platform to resolve this very
> issue!
I think there might be a misunderstanding. The code below adds entropy
pool initialization, but this logic is missing in the PPI interrupt
handler. I believe this was simply an accidental omission.
---------------------------
irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
{
irqreturn_t retval;
retval = __handle_irq_event_percpu(desc);
add_interrupt_randomness(desc->irq_data.irq);
if (!irq_settings_no_debug(desc))
note_interrupt(desc, retval);
return retval;
}
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 7:40 ` enlin.mu
@ 2026-06-16 7:49 ` Greg KH
2026-06-16 8:16 ` enlin.mu
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2026-06-16 7:49 UTC (permalink / raw)
To: enlin.mu; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On Tue, Jun 16, 2026 at 03:40:10PM +0800, enlin.mu wrote:
>
>
> On 2026/6/16 15:24, Greg KH wrote:
> > On Tue, Jun 16, 2026 at 03:17:00PM +0800, enlin.mu wrote:
> > >
> > >
> > > On 2026/6/16 14:48, Greg KH wrote:
> > > > A: http://en.wikipedia.org/wiki/Top_post
> > > > Q: Were do I find info about this thing called top-posting?
> > > > A: Because it messes up the order in which people normally read text.
> > > > Q: Why is top-posting such a bad thing?
> > > > A: Top-posting.
> > > > Q: What is the most annoying thing in e-mail?
> > > >
> > > > A: No.
> > > > Q: Should I include quotations after my reply?
> > > >
> > > > http://daringfireball.net/2007/07/on_top
> > > >
> > > > On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
> > > > > Hi KH
> > > > >
> > > > > hardware: raspberrypi 5
> > > > >
> > > > > other patch(These two locations impact the entropy pool acceleration.
> > > > > comment them out temporarily):
> > > > > acer@raspberrypi:linux $ git diff drivers/of/fdt.c
> > > > > drivers/char/hw_random/iproc-rng200.c
> > > > > diff --git a/drivers/char/hw_random/iproc-rng200.c
> > > > > b/drivers/char/hw_random/iproc-rng200.c
> > > > > index 33bc28f429f6..af105faa88c6 100644
> > > > > --- a/drivers/char/hw_random/iproc-rng200.c
> > > > > +++ b/drivers/char/hw_random/iproc-rng200.c
> > > > > @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
> > > > > };
> > > > >
> > > > > static const struct of_device_id iproc_rng200_of_match[] = {
> > > > > - { .compatible = "brcm,bcm2711-rng200", },
> > > > > - { .compatible = "brcm,bcm7211-rng200", },
> > > > > - { .compatible = "brcm,bcm7278-rng200", },
> > > > > - { .compatible = "brcm,iproc-rng200", },
> > > > > + { .compatible = "brcm,bcm2711-rng2000", },
> > > > > + { .compatible = "brcm,bcm7211-rng2000", },
> > > > > + { .compatible = "brcm,bcm7278-rng2000", },
> > > > > + { .compatible = "brcm,iproc-rng2000", },
> > > >
> > > > What is this change for?
> > > This driver accelerates the initialization of the entropy pool. If this
> > > dirver is added, the optimization effect of my patch will no longer be
> > > clearly observable.
> >
> > Great, obviously your patch is not needed!
> >
> > >
> > > >
> > > >
> > > > > {},
> > > > > };
> > > > > MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
> > > > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> > > > > index 331646d667b9..13308d58785d 100644
> > > > > --- a/drivers/of/fdt.c
> > > > > +++ b/drivers/of/fdt.c
> > > > > @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
> > > > >
> > > > > rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
> > > > > if (rng_seed && l > 0) {
> > > > > - add_bootloader_randomness(rng_seed, l);
> > > > > + //add_bootloader_randomness(rng_seed, l);
> > > >
> > > > Why did you comment this out?
> > > Before the kernel boots, the Raspberry Pi bootloader injects the rng-seed
> > > property into the kernel's Device Tree to accelerate entropy pool
> > > initialization. Therefore, I need to temporarily comment this out
> > > to avoid interfering with the testing of my current patch.
> >
> > Again, that seems like the correct fix, don't change the common code
> > path of all systems just because you don't want to accept the changes
> > that have already been made for your platform to resolve this very
> > issue!
>
> I think there might be a misunderstanding. The code below adds entropy pool
> initialization, but this logic is missing in the PPI interrupt handler. I
> believe this was simply an accidental omission.
> ---------------------------
> irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
> {
> irqreturn_t retval;
>
> retval = __handle_irq_event_percpu(desc);
>
> add_interrupt_randomness(desc->irq_data.irq);
>
> if (!irq_settings_no_debug(desc))
> note_interrupt(desc, retval);
> return retval;
Look back at your original patch. It contained none of this
information...
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler
2026-06-16 7:49 ` Greg KH
@ 2026-06-16 8:16 ` enlin.mu
0 siblings, 0 replies; 9+ messages in thread
From: enlin.mu @ 2026-06-16 8:16 UTC (permalink / raw)
To: Greg KH; +Cc: tglx, linux-kernel, enlin.mu, linux-hardening
On 2026/6/16 15:49, Greg KH wrote:
> On Tue, Jun 16, 2026 at 03:40:10PM +0800, enlin.mu wrote:
>>
>>
>> On 2026/6/16 15:24, Greg KH wrote:
>>> On Tue, Jun 16, 2026 at 03:17:00PM +0800, enlin.mu wrote:
>>>>
>>>>
>>>> On 2026/6/16 14:48, Greg KH wrote:
>>>>> A: http://en.wikipedia.org/wiki/Top_post
>>>>> Q: Were do I find info about this thing called top-posting?
>>>>> A: Because it messes up the order in which people normally read text.
>>>>> Q: Why is top-posting such a bad thing?
>>>>> A: Top-posting.
>>>>> Q: What is the most annoying thing in e-mail?
>>>>>
>>>>> A: No.
>>>>> Q: Should I include quotations after my reply?
>>>>>
>>>>> http://daringfireball.net/2007/07/on_top
>>>>>
>>>>> On Tue, Jun 16, 2026 at 02:26:18PM +0800, enlin.mu wrote:
>>>>>> Hi KH
>>>>>>
>>>>>> hardware: raspberrypi 5
>>>>>>
>>>>>> other patch(These two locations impact the entropy pool acceleration.
>>>>>> comment them out temporarily):
>>>>>> acer@raspberrypi:linux $ git diff drivers/of/fdt.c
>>>>>> drivers/char/hw_random/iproc-rng200.c
>>>>>> diff --git a/drivers/char/hw_random/iproc-rng200.c
>>>>>> b/drivers/char/hw_random/iproc-rng200.c
>>>>>> index 33bc28f429f6..af105faa88c6 100644
>>>>>> --- a/drivers/char/hw_random/iproc-rng200.c
>>>>>> +++ b/drivers/char/hw_random/iproc-rng200.c
>>>>>> @@ -296,10 +296,10 @@ static const struct dev_pm_ops iproc_rng200_pm_ops = {
>>>>>> };
>>>>>>
>>>>>> static const struct of_device_id iproc_rng200_of_match[] = {
>>>>>> - { .compatible = "brcm,bcm2711-rng200", },
>>>>>> - { .compatible = "brcm,bcm7211-rng200", },
>>>>>> - { .compatible = "brcm,bcm7278-rng200", },
>>>>>> - { .compatible = "brcm,iproc-rng200", },
>>>>>> + { .compatible = "brcm,bcm2711-rng2000", },
>>>>>> + { .compatible = "brcm,bcm7211-rng2000", },
>>>>>> + { .compatible = "brcm,bcm7278-rng2000", },
>>>>>> + { .compatible = "brcm,iproc-rng2000", },
>>>>>
>>>>> What is this change for?
>>>> This driver accelerates the initialization of the entropy pool. If this
>>>> dirver is added, the optimization effect of my patch will no longer be
>>>> clearly observable.
>>>
>>> Great, obviously your patch is not needed!
>>>
>>>>
>>>>>
>>>>>
>>>>>> {},
>>>>>> };
>>>>>> MODULE_DEVICE_TABLE(of, iproc_rng200_of_match);
>>>>>> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
>>>>>> index 331646d667b9..13308d58785d 100644
>>>>>> --- a/drivers/of/fdt.c
>>>>>> +++ b/drivers/of/fdt.c
>>>>>> @@ -1100,7 +1100,7 @@ int __init early_init_dt_scan_chosen(char *cmdline)
>>>>>>
>>>>>> rng_seed = of_get_flat_dt_prop(node, "rng-seed", &l);
>>>>>> if (rng_seed && l > 0) {
>>>>>> - add_bootloader_randomness(rng_seed, l);
>>>>>> + //add_bootloader_randomness(rng_seed, l);
>>>>>
>>>>> Why did you comment this out?
>>>> Before the kernel boots, the Raspberry Pi bootloader injects the rng-seed
>>>> property into the kernel's Device Tree to accelerate entropy pool
>>>> initialization. Therefore, I need to temporarily comment this out
>>>> to avoid interfering with the testing of my current patch.
>>>
>>> Again, that seems like the correct fix, don't change the common code
>>> path of all systems just because you don't want to accept the changes
>>> that have already been made for your platform to resolve this very
>>> issue!
>>
>> I think there might be a misunderstanding. The code below adds entropy pool
>> initialization, but this logic is missing in the PPI interrupt handler. I
>> believe this was simply an accidental omission.
>> ---------------------------
>> irqreturn_t handle_irq_event_percpu(struct irq_desc *desc)
>> {
>> irqreturn_t retval;
>>
>> retval = __handle_irq_event_percpu(desc);
>>
>> add_interrupt_randomness(desc->irq_data.irq);
>>
>> if (!irq_settings_no_debug(desc))
>> note_interrupt(desc, retval);
>> return retval;
>
> Look back at your original patch. It contained none of this
> information...
My apologies. I mistakenly assumed the context was obvious, but I
realize now that it should have been explicitly documented in the
original patch. I will send a v2 patch immediately with all this
information added to the commit message.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-06-16 8:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 5:50 [PATCH] genirq: Add the entropy pool function to the PPI interrupt handler Enlin Mu
2026-06-16 5:59 ` Greg KH
2026-06-16 6:26 ` enlin.mu
2026-06-16 6:48 ` Greg KH
2026-06-16 7:17 ` enlin.mu
2026-06-16 7:24 ` Greg KH
2026-06-16 7:40 ` enlin.mu
2026-06-16 7:49 ` Greg KH
2026-06-16 8:16 ` enlin.mu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.