From: Chao Yu <chao@kernel.org>
To: Sun Ke <sunke32@huawei.com>, xiang@kernel.org
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, yinxin.x@bytedance.com
Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio
Date: Mon, 5 Sep 2022 23:10:35 +0800 [thread overview]
Message-ID: <ef807497-6394-8274-71ce-ace51db31398@kernel.org> (raw)
In-Reply-To: <20220815034829.3940803-1-sunke32@huawei.com>
On 2022/8/15 11:48, Sun Ke wrote:
> If erofs_fscache_alloc_request fail and then goto out, it will return 0.
> it should return a negative error code instead of 0.
>
> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead")
> Signed-off-by: Sun Ke <sunke32@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Sun Ke <sunke32@huawei.com>, xiang@kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org, yinxin.x@bytedance.com
Subject: Re: [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio
Date: Mon, 5 Sep 2022 23:10:35 +0800 [thread overview]
Message-ID: <ef807497-6394-8274-71ce-ace51db31398@kernel.org> (raw)
In-Reply-To: <20220815034829.3940803-1-sunke32@huawei.com>
On 2022/8/15 11:48, Sun Ke wrote:
> If erofs_fscache_alloc_request fail and then goto out, it will return 0.
> it should return a negative error code instead of 0.
>
> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache readpage/readahead")
> Signed-off-by: Sun Ke <sunke32@huawei.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2022-09-05 15:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 3:48 [PATCH] erofs: fix error return code in erofs_fscache_meta_read_folio and erofs_fscache_read_folio Sun Ke
2022-08-15 3:48 ` Sun Ke via Linux-erofs
2022-08-15 4:03 ` Gao Xiang
2022-08-15 4:03 ` Gao Xiang
2022-08-15 12:14 ` JeffleXu
2022-08-15 12:14 ` JeffleXu
2022-08-16 5:16 ` Gao Xiang
2022-08-16 5:16 ` Gao Xiang
2022-08-17 1:44 ` Sun Ke
2022-08-17 1:44 ` Sun Ke via Linux-erofs
2022-08-17 2:41 ` Gao Xiang
2022-08-17 2:41 ` Gao Xiang
2022-08-17 2:48 ` Sun Ke
2022-08-17 2:48 ` Sun Ke via Linux-erofs
2022-09-05 15:10 ` Chao Yu [this message]
2022-09-05 15:10 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef807497-6394-8274-71ce-ace51db31398@kernel.org \
--to=chao@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunke32@huawei.com \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.