All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
To: Brian Cain <brian.cain@oss.qualcomm.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Subject: Re: [PATCH 6/8] hexagon: raise imprecise exception for multi-TLB matches
Date: Thu, 3 Sep 2026 12:37:49 -0700	[thread overview]
Message-ID: <f1f68463-810a-4374-9e65-fe6d2c5d9ecd@oss.qualcomm.com> (raw)
In-Reply-To: <20260903185622.3234171-7-brian.cain@oss.qualcomm.com>

On 9/3/2026 11:56 AM, Brian Cain wrote:
> The TLB walk stopped at the first matching entry, so instruction and data
> translations did not detect a second valid mapping for the same VA and ASID.
> 
> Scan the remaining entries after selecting the translation.  On a second
> match, retain the first entry for the access but record
> HEX_CAUSE_IMPRECISE_MULTI_TLB_MATCH as a pending imprecise exception.
> 
> Move that exception out of the synchronous TLB-fill result and check for it
> after every packet, rather than only packets containing tlbp.  This delivers
> the architectural imprecise exception after an ordinary memory access and
> avoids treating it as a precise permission fault.  Clear the pending state
> when starting a new translation and after delivering the exception.
> 
> The v0.2.14 mmu_multi_tlb systest uncovered this bug.
> 
> Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
> ---
>  hw/hexagon/hexagon_tlb.c   | 10 ++++++++++
>  target/hexagon/hex_mmu.c   | 12 +++++++++---
>  target/hexagon/hexswi.c    |  1 +
>  target/hexagon/translate.c | 22 ++++++++--------------
>  4 files changed, 28 insertions(+), 17 deletions(-)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>


  reply	other threads:[~2026-09-03 19:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 18:56 [PATCH 0/8] hexagon: fixes for tlb, badva Brian Cain
2026-09-03 18:56 ` [PATCH 1/8] hw/hexagon: register the V68N_1024 machine Brian Cain
2026-09-03 19:36   ` Pierrick Bouvier
2026-09-03 18:56 ` [PATCH 2/8] target/hexagon: read BADVA as an alias of BADVA0/1 Brian Cain
2026-09-03 19:36   ` Pierrick Bouvier
2026-09-03 18:56 ` [PATCH 3/8] target/hexagon: kick vCPU when re-asserting interrupts Brian Cain
2026-09-03 19:36   ` Pierrick Bouvier
2026-09-04 13:30   ` Philippe Mathieu-Daudé
2026-09-03 18:56 ` [PATCH 4/8] hw/intc: name the L2VIC edge trigger check Brian Cain
2026-09-03 19:37   ` Pierrick Bouvier
2026-09-04 13:31   ` Philippe Mathieu-Daudé
2026-09-03 18:56 ` [PATCH 5/8] target/hexagon: assert guest register pair alignment Brian Cain
2026-09-03 19:37   ` Pierrick Bouvier
2026-09-04 13:32   ` Philippe Mathieu-Daudé
2026-09-03 18:56 ` [PATCH 6/8] hexagon: raise imprecise exception for multi-TLB matches Brian Cain
2026-09-03 19:37   ` Pierrick Bouvier [this message]
2026-09-03 18:56 ` [PATCH 7/8] tests/functional/hexagon: add tests, update to v0.2.14 Brian Cain
2026-09-03 19:38   ` Pierrick Bouvier
2026-09-03 18:56 ` [PATCH 8/8] tests/functional/hexagon: update arch tests " Brian Cain
2026-09-03 19:38   ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1f68463-810a-4374-9e65-fe6d2c5d9ecd@oss.qualcomm.com \
    --to=pierrick.bouvier@oss.qualcomm.com \
    --cc=brian.cain@oss.qualcomm.com \
    --cc=philmd@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.