From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Cc: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
Date: Wed, 6 May 2020 20:05:27 +0300 [thread overview]
Message-ID: <f288e704-2fdb-d548-9f5b-8016412dfd3f@gmail.com> (raw)
In-Reply-To: <20200506164133.GB19296-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
06.05.2020 19:41, Sam Ravnborg пишет:
> On Sat, Apr 18, 2020 at 08:06:59PM +0300, Dmitry Osipenko wrote:
>> When graph isn't defined in a device-tree, the of_graph_get_remote_node()
>> prints a noisy error message, telling that port node is not found. This is
>> undesirable behaviour in our case because absence of a panel/bridge graph
>> is a valid case. Let's check presence of the local port in a device-tree
>> before proceeding with parsing the graph.
>>
>> Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Thank you again for taking a look at these patches!
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
Date: Wed, 6 May 2020 20:05:27 +0300 [thread overview]
Message-ID: <f288e704-2fdb-d548-9f5b-8016412dfd3f@gmail.com> (raw)
In-Reply-To: <20200506164133.GB19296@ravnborg.org>
06.05.2020 19:41, Sam Ravnborg пишет:
> On Sat, Apr 18, 2020 at 08:06:59PM +0300, Dmitry Osipenko wrote:
>> When graph isn't defined in a device-tree, the of_graph_get_remote_node()
>> prints a noisy error message, telling that port node is not found. This is
>> undesirable behaviour in our case because absence of a panel/bridge graph
>> is a valid case. Let's check presence of the local port in a device-tree
>> before proceeding with parsing the graph.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you again for taking a look at these patches!
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-tegra@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence
Date: Wed, 6 May 2020 20:05:27 +0300 [thread overview]
Message-ID: <f288e704-2fdb-d548-9f5b-8016412dfd3f@gmail.com> (raw)
In-Reply-To: <20200506164133.GB19296@ravnborg.org>
06.05.2020 19:41, Sam Ravnborg пишет:
> On Sat, Apr 18, 2020 at 08:06:59PM +0300, Dmitry Osipenko wrote:
>> When graph isn't defined in a device-tree, the of_graph_get_remote_node()
>> prints a noisy error message, telling that port node is not found. This is
>> undesirable behaviour in our case because absence of a panel/bridge graph
>> is a valid case. Let's check presence of the local port in a device-tree
>> before proceeding with parsing the graph.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thank you again for taking a look at these patches!
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-06 17:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 17:06 [PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-04-18 17:06 ` Dmitry Osipenko
2020-04-18 17:06 ` Dmitry Osipenko
2020-04-18 17:06 ` [PATCH v5 1/6] of_graph: add of_graph_get_local_port() Dmitry Osipenko
2020-04-18 17:06 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-2-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-30 14:10 ` Rob Herring
2020-04-30 14:10 ` Rob Herring
2020-04-30 14:10 ` Rob Herring
2020-05-06 16:32 ` Sam Ravnborg
2020-05-06 16:32 ` Sam Ravnborg
2020-05-06 16:32 ` Sam Ravnborg
2020-05-11 20:27 ` Rob Herring
2020-05-11 20:27 ` Rob Herring
2020-04-18 17:06 ` [PATCH v5 2/6] drm/of: Make drm_of_find_panel_or_bridge() to check graph's presence Dmitry Osipenko
2020-04-18 17:06 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-06 16:41 ` Sam Ravnborg
2020-05-06 16:41 ` Sam Ravnborg
2020-05-06 16:41 ` Sam Ravnborg
[not found] ` <20200506164133.GB19296-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-05-06 17:05 ` Dmitry Osipenko [this message]
2020-05-06 17:05 ` Dmitry Osipenko
2020-05-06 17:05 ` Dmitry Osipenko
2020-04-18 17:07 ` [PATCH v5 3/6] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko
2020-04-18 17:07 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-06 16:42 ` Sam Ravnborg
2020-05-06 16:42 ` Sam Ravnborg
2020-05-06 16:42 ` Sam Ravnborg
2020-04-18 17:07 ` [PATCH v5 4/6] drm/tegra: output: Support DRM bridges Dmitry Osipenko
2020-04-18 17:07 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-5-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-06 16:43 ` Sam Ravnborg
2020-05-06 16:43 ` Sam Ravnborg
2020-05-06 16:43 ` Sam Ravnborg
2020-04-18 17:07 ` [PATCH v5 5/6] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko
2020-04-18 17:07 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-6-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-05-06 16:45 ` Sam Ravnborg
2020-05-06 16:45 ` Sam Ravnborg
2020-05-06 16:45 ` Sam Ravnborg
[not found] ` <20200418170703.1583-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-18 17:07 ` [PATCH v5 6/6] drm/tegra: output: rgb: Wrap directly-connected panel into DRM bridge Dmitry Osipenko
2020-04-18 17:07 ` Dmitry Osipenko
2020-04-18 17:07 ` Dmitry Osipenko
[not found] ` <20200418170703.1583-7-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-04-25 17:02 ` Sam Ravnborg
2020-04-25 17:02 ` Sam Ravnborg
2020-04-25 17:02 ` Sam Ravnborg
[not found] ` <20200425170237.GA20498-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
2020-04-25 21:51 ` Dmitry Osipenko
2020-04-25 21:51 ` Dmitry Osipenko
2020-04-25 21:51 ` Dmitry Osipenko
2020-05-24 18:41 ` [PATCH v5 0/6] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-05-24 18:41 ` Dmitry Osipenko
2020-05-24 18:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f288e704-2fdb-d548-9f5b-8016412dfd3f@gmail.com \
--to=digetx-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.