All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: jean.pihet@newoldbits.com, linux-omap@vger.kernel.org
Cc: khilman@deeprootsystems.com,
	linux-arm-kernel@lists.infradead.org,
	Jean Pihet-XID <j-pihet@ti.com>
Subject: RE: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
Date: Fri, 17 Dec 2010 10:35:47 +0530	[thread overview]
Message-ID: <f3afb9340d4f1d0c8d2936d9faea79c8@mail.gmail.com> (raw)
In-Reply-To: <1292521858-3810-1-git-send-email-j-pihet@ti.com>

Jean,

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of jean.pihet@newoldbits.com
> Sent: Thursday, December 16, 2010 11:21 PM
> To: linux-omap@vger.kernel.org
> Cc: khilman@deeprootsystems.com; linux-arm-kernel@lists.infradead.org;
> Jean Pihet
> Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
>
> From: Jean Pihet <j-pihet@ti.com>
>
> This patch only contains clean-ups and cosmetic changes,
> no functional change.
>
> Clean-up of the ASM sleep code, for better readability and
> easier maintenance.
>
> Applies on top of Nishant's latest idle path errata fixes step 2,
> cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2
>
Thanks for cleanup. Have few minor comments on these patches.

> Jean Pihet (7):
>   OMAP2+: use global values for the SRAM PA addresses
>   OMAP3: remove hardcoded values from the ASM sleep code
>   OMAP3: re-organize the ASM sleep code
>   OMAP3: rework of the ASM sleep code execution paths
>   OMAP3: add comments for low power code errata
>   OMAP3: ASM sleep code format rework
>   OMAP3: remove unused code from the ASM sleep code
>
>  arch/arm/mach-omap2/control.c   |   10 +-
>  arch/arm/mach-omap2/control.h   |    2 +
>  arch/arm/mach-omap2/pm.h        |    1 -
>  arch/arm/mach-omap2/pm34xx.c    |    4 +-
>  arch/arm/mach-omap2/sdrc.h      |    7 +
>  arch/arm/mach-omap2/sleep34xx.S |  714
+++++++++++++++++++++-------------
> -----
>  arch/arm/plat-omap/sram.c       |    7 +-
>  7 files changed, 401 insertions(+), 344 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
Date: Fri, 17 Dec 2010 10:35:47 +0530	[thread overview]
Message-ID: <f3afb9340d4f1d0c8d2936d9faea79c8@mail.gmail.com> (raw)
In-Reply-To: <1292521858-3810-1-git-send-email-j-pihet@ti.com>

Jean,

> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of jean.pihet at newoldbits.com
> Sent: Thursday, December 16, 2010 11:21 PM
> To: linux-omap at vger.kernel.org
> Cc: khilman at deeprootsystems.com; linux-arm-kernel at lists.infradead.org;
> Jean Pihet
> Subject: [PATCH 0/7 v4] OMAP3: clean up ASM sleep code
>
> From: Jean Pihet <j-pihet@ti.com>
>
> This patch only contains clean-ups and cosmetic changes,
> no functional change.
>
> Clean-up of the ASM sleep code, for better readability and
> easier maintenance.
>
> Applies on top of Nishant's latest idle path errata fixes step 2,
> cf. http://marc.info/?l=linux-omap&m=129139584919242&w=2
>
Thanks for cleanup. Have few minor comments on these patches.

> Jean Pihet (7):
>   OMAP2+: use global values for the SRAM PA addresses
>   OMAP3: remove hardcoded values from the ASM sleep code
>   OMAP3: re-organize the ASM sleep code
>   OMAP3: rework of the ASM sleep code execution paths
>   OMAP3: add comments for low power code errata
>   OMAP3: ASM sleep code format rework
>   OMAP3: remove unused code from the ASM sleep code
>
>  arch/arm/mach-omap2/control.c   |   10 +-
>  arch/arm/mach-omap2/control.h   |    2 +
>  arch/arm/mach-omap2/pm.h        |    1 -
>  arch/arm/mach-omap2/pm34xx.c    |    4 +-
>  arch/arm/mach-omap2/sdrc.h      |    7 +
>  arch/arm/mach-omap2/sleep34xx.S |  714
+++++++++++++++++++++-------------
> -----
>  arch/arm/plat-omap/sram.c       |    7 +-
>  7 files changed, 401 insertions(+), 344 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-12-17  5:05 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 17:50 [PATCH 0/7 v4] OMAP3: clean up ASM sleep code jean.pihet
2010-12-16 17:50 ` jean.pihet at newoldbits.com
2010-12-16 17:50 ` [PATCH 1/7] OMAP3: remove unused code from the " jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-16 17:50 ` [PATCH 2/7] OMAP2+: use global values for the SRAM PA addresses jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-17  4:48   ` Santosh Shilimkar
2010-12-17  4:48     ` Santosh Shilimkar
2010-12-17 10:13     ` Jean Pihet
2010-12-17 10:13       ` Jean Pihet
2010-12-16 17:50 ` [PATCH 3/7] OMAP3: remove hardcoded values from the ASM sleep code jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-16 17:50 ` [PATCH 4/7] OMAP3: re-organize " jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-16 17:50 ` [PATCH 5/7] OMAP3: rework of the ASM sleep code execution paths jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-17  5:04   ` Santosh Shilimkar
2010-12-17  5:04     ` Santosh Shilimkar
2010-12-17 10:14     ` Jean Pihet
2010-12-17 10:14       ` Jean Pihet
2010-12-16 17:50 ` [PATCH 6/7] OMAP3: add comments for low power code errata jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-16 17:50 ` [PATCH 7/7] OMAP3: ASM sleep code format rework jean.pihet
2010-12-16 17:50   ` jean.pihet at newoldbits.com
2010-12-17  5:09   ` Santosh Shilimkar
2010-12-17  5:09     ` Santosh Shilimkar
2010-12-17 10:16     ` Jean Pihet
2010-12-17 10:16       ` Jean Pihet
2010-12-16 18:26 ` [PATCH 0/7 v4] OMAP3: clean up ASM sleep code Tony Lindgren
2010-12-16 18:26   ` Tony Lindgren
2010-12-17  5:05 ` Santosh Shilimkar [this message]
2010-12-17  5:05   ` Santosh Shilimkar
2010-12-17 10:18   ` Jean Pihet
2010-12-17 10:18     ` Jean Pihet
2010-12-17 10:20     ` Santosh Shilimkar
2010-12-17 10:20       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3afb9340d4f1d0c8d2936d9faea79c8@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.