All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-clk@vger.kernel.org
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Michael Turquette <mturquette@baylibre.com>,
	NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX
Date: Mon, 27 Feb 2023 14:53:08 +0100	[thread overview]
Message-ID: <f4fd60db-9924-cb2c-71bb-1ac3b53305e8@denx.de> (raw)
In-Reply-To: <3160821.5fSG56mABF@steina-w>

On 2/27/23 10:08, Alexander Stein wrote:

[...]

>> +			sdma2: dma-controller@30e10000 {
>> +				compatible = "fsl,imx8mp-sdma",
> "fsl,imx8mq-sdma";
>> +				reg = <0x30e10000 0x10000>;
>> +				interrupts = <GIC_SPI 103
> IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&audio_blk_ctrl
> IMX8MP_CLK_AUDIOMIX_SDMA2_ROOT>,
>> +					 <&clk
> IMX8MP_CLK_AUDIO_ROOT>;
>> +				clock-names = "ipg", "ahb";
>> +				#dma-cells = <3>;
>> +				fsl,sdma-ram-script-name = "imx/sdma/
> sdma-imx7d.bin";
>> +			};
>> +
>> +			audio_blk_ctrl: blk-ctrl@30e20000 {
> 
> Shouldn't the node name be 'clock-controller@30e20000' as mentioned in the
> bindings?
> But for the whole series:
> Testes-by: Alexander Stein <alexander.stein@ew.tq-group.com>

It should be clock-controller indeed, fixed in V5, thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-clk@vger.kernel.org
Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Marco Felsch <m.felsch@pengutronix.de>,
	Michael Turquette <mturquette@baylibre.com>,
	NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX
Date: Mon, 27 Feb 2023 14:53:08 +0100	[thread overview]
Message-ID: <f4fd60db-9924-cb2c-71bb-1ac3b53305e8@denx.de> (raw)
In-Reply-To: <3160821.5fSG56mABF@steina-w>

On 2/27/23 10:08, Alexander Stein wrote:

[...]

>> +			sdma2: dma-controller@30e10000 {
>> +				compatible = "fsl,imx8mp-sdma",
> "fsl,imx8mq-sdma";
>> +				reg = <0x30e10000 0x10000>;
>> +				interrupts = <GIC_SPI 103
> IRQ_TYPE_LEVEL_HIGH>;
>> +				clocks = <&audio_blk_ctrl
> IMX8MP_CLK_AUDIOMIX_SDMA2_ROOT>,
>> +					 <&clk
> IMX8MP_CLK_AUDIO_ROOT>;
>> +				clock-names = "ipg", "ahb";
>> +				#dma-cells = <3>;
>> +				fsl,sdma-ram-script-name = "imx/sdma/
> sdma-imx7d.bin";
>> +			};
>> +
>> +			audio_blk_ctrl: blk-ctrl@30e20000 {
> 
> Shouldn't the node name be 'clock-controller@30e20000' as mentioned in the
> bindings?
> But for the whole series:
> Testes-by: Alexander Stein <alexander.stein@ew.tq-group.com>

It should be clock-controller indeed, fixed in V5, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-02-27 14:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 17:11 [PATCH v4 1/5] clk: Introduce devm_clk_hw_register_gate_parent_data() Marek Vasut
2023-02-23 17:11 ` Marek Vasut
2023-02-23 17:11 ` [PATCH v4 2/5] clk: imx: imx8mp: Add audiomix block control Marek Vasut
2023-02-23 17:11   ` Marek Vasut
2023-02-24 16:38   ` Luca Ceresoli
2023-02-24 16:38     ` Luca Ceresoli
2023-02-23 17:11 ` [PATCH v4 3/5] dt-bindings: clock: " Marek Vasut
2023-02-23 17:11   ` Marek Vasut
2023-02-23 17:11 ` [PATCH v4 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Marek Vasut
2023-02-23 17:11   ` Marek Vasut
2023-02-27  9:08   ` Alexander Stein
2023-02-27  9:08     ` Alexander Stein
2023-02-27 11:38     ` Adam Ford
2023-02-27 11:38       ` Adam Ford
2023-02-27 12:00       ` Alexander Stein
2023-02-27 12:00         ` Alexander Stein
2023-02-27 13:53     ` Marek Vasut [this message]
2023-02-27 13:53       ` Marek Vasut
2023-02-23 17:11 ` [PATCH v4 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2023-02-23 17:11   ` Marek Vasut
2023-02-23 17:28   ` Fabio Estevam
2023-02-23 17:28     ` Fabio Estevam
2023-02-23 17:39     ` Marek Vasut
2023-02-23 17:39       ` Marek Vasut
2023-02-24 12:59   ` Marco Felsch
2023-02-24 12:59     ` Marco Felsch
2023-02-24  0:24 ` [PATCH v4 1/5] clk: Introduce devm_clk_hw_register_gate_parent_data() Adam Ford
2023-02-24  0:24   ` Adam Ford
2023-02-27  8:38 ` Alexander Stein
2023-02-27  8:38   ` Alexander Stein
2023-02-27 13:47   ` Marek Vasut
2023-02-27 13:47     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4fd60db-9924-cb2c-71bb-1ac3b53305e8@denx.de \
    --to=marex@denx.de \
    --cc=abelvesa@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.stach@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=m.felsch@pengutronix.de \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.