Re: [PATCH v3 22/23] drm/xe/gt: Report 'pagefault' errors using SIGID

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2197 bytes --]


On 30-07-2026 08:51 pm, Michal Wajdeczko wrote:
> Report 'Queue full/Unsuccessful response' pagefault errors using
> xe_log() helpers.
>
> Signed-off-by: Michal Wajdeczko<michal.wajdeczko@intel.com>
> Cc: Rodrigo Vivi<rodrigo.vivi@intel.com>
> Cc: Matthew Brost<matthew.brost@intel.com>
> Cc: Daniele Ceraolo Spurio<daniele.ceraolospurio@intel.com>
> Cc: Aravind Iddamsetty<aravind.iddamsetty@intel.com>
> Cc: Mallesh Koujalagi<mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pagefault.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
> index dd3c068e1a39..e78c855759e1 100644
> --- a/drivers/gpu/drm/xe/xe_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_pagefault.c
> @@ -14,6 +14,7 @@
>   #include "xe_gt_types.h"
>   #include "xe_gt_stats.h"
>   #include "xe_hw_engine.h"
> +#include "xe_log.h"
>   #include "xe_pagefault.h"
>   #include "xe_pagefault_types.h"
>   #include "xe_svm.h" @@ -309,8 +310,7 @@ static void xe_pagefault_queue_work(struct 
> work_struct *w) xe_pagefault_save_to_vm(gt_to_xe(pf.gt), &pf); if 
> (!(pf.consumer.access_type & XE_PAGEFAULT_ACCESS_PREFETCH)) { 
> xe_pagefault_print(&pf); - xe_gt_info(pf.gt, "Fault response: Unsuccessful %pe\n",
> -					   ERR_PTR(err));
> +				xe_log_err(pf.gt, PAGEFAULT, err, "Fault response: Unsuccessful\n");

Drop Fault in message, otherwise "Page Fault:  Fault response: Unsuccessful"

Thanks,

-/Mallesh

>   			} else {
>   				xe_gt_stats_incr(pf.gt, XE_GT_STATS_ID_INVALID_PREFETCH_PAGEFAULT_COUNT, 1);
>   				xe_gt_dbg(pf.gt, "Prefetch Fault response: Unsuccessful %pe\n",
> @@ -487,9 +487,9 @@ int xe_pagefault_handler(struct xe_device *xe, struct xe_pagefault *pf)
>   			pf_queue->size;
>   		queue_work(xe->usm.pf_wq, &pf_queue->worker);
>   	} else {
> -		drm_warn(&xe->drm,
> -			 "PageFault Queue (%d) full, shouldn't be possible\n",
> -			 pf->consumer.asid % XE_PAGEFAULT_QUEUE_COUNT);
> +		xe_log_err(xe, PAGEFAULT, -ENOSPC,
> +			   "Queue (%d) full, shouldn't be possible\n",
> +			   pf->consumer.asid % XE_PAGEFAULT_QUEUE_COUNT);
>   	}
>   	spin_unlock_irqrestore(&pf_queue->lock, flags);
>   

[-- Attachment #2: Type: text/html, Size: 3669 bytes --]