From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>, "Conor Dooley" <conor@kernel.org>
Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver
Date: Tue, 28 Feb 2023 21:16:38 +0800 [thread overview]
Message-ID: <f9e380f6-334f-11fa-1118-8d6c3c9befaf@starfivetech.com> (raw)
In-Reply-To: <Y/3hVlp/YPnWHDCX@wendy>
On 2023/2/28 19:11, Conor Dooley wrote:
> On Tue, Feb 28, 2023 at 11:57:58AM +0100, Krzysztof Kozlowski wrote:
>> On 28/02/2023 11:51, Conor Dooley wrote:
>> > On Tue, Feb 28, 2023 at 11:36:49AM +0100, Emil Renner Berthing wrote:
>> >> On Tue, 28 Feb 2023 at 10:44, Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
>> >>> On 2023/2/26 22:14, Emil Renner Berthing wrote:
>> >>>> On Mon, 20 Feb 2023 at 09:21, Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
>> >
>> >>> So the dt-bingdings need to rename, and which one could be better,
>> >>> 'starfive,jh71x0-wdt.yaml' or 'starfive,jh-wdt.yaml'?
>> >>
>> >> Sure, starfive,jh71x0-wdt.yaml sounds good to me.
>> >
>> > I feel like a common comment I see from the dt folks is to not put
>> > wildcards in filenames & just pick the first compatible.
>> > I could very well be wrong on that front though...
>>
>> First compatible is a bit better, unless you are sure this will cover
>> all such compatibles now and in the future. For many bindings the
>> family/wildcards were fine in filename.
>
> Ahh cool, good to know what the specific policy is - thanks!
If this watchdog driver is improved to also support JH7100 in next patch,
it seems more reasonable to rename the dt-bingdings to 'starfive,jh71x0-wdt.yaml'.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Xingyu Wu <xingyu.wu@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-watchdog@vger.kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Samin Guo <samin.guo@starfivetech.com>,
<linux-kernel@vger.kernel.org>, "Conor Dooley" <conor@kernel.org>
Subject: Re: [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver
Date: Tue, 28 Feb 2023 21:16:38 +0800 [thread overview]
Message-ID: <f9e380f6-334f-11fa-1118-8d6c3c9befaf@starfivetech.com> (raw)
In-Reply-To: <Y/3hVlp/YPnWHDCX@wendy>
On 2023/2/28 19:11, Conor Dooley wrote:
> On Tue, Feb 28, 2023 at 11:57:58AM +0100, Krzysztof Kozlowski wrote:
>> On 28/02/2023 11:51, Conor Dooley wrote:
>> > On Tue, Feb 28, 2023 at 11:36:49AM +0100, Emil Renner Berthing wrote:
>> >> On Tue, 28 Feb 2023 at 10:44, Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
>> >>> On 2023/2/26 22:14, Emil Renner Berthing wrote:
>> >>>> On Mon, 20 Feb 2023 at 09:21, Xingyu Wu <xingyu.wu@starfivetech.com> wrote:
>> >
>> >>> So the dt-bingdings need to rename, and which one could be better,
>> >>> 'starfive,jh71x0-wdt.yaml' or 'starfive,jh-wdt.yaml'?
>> >>
>> >> Sure, starfive,jh71x0-wdt.yaml sounds good to me.
>> >
>> > I feel like a common comment I see from the dt folks is to not put
>> > wildcards in filenames & just pick the first compatible.
>> > I could very well be wrong on that front though...
>>
>> First compatible is a bit better, unless you are sure this will cover
>> all such compatibles now and in the future. For many bindings the
>> family/wildcards were fine in filename.
>
> Ahh cool, good to know what the specific policy is - thanks!
If this watchdog driver is improved to also support JH7100 in next patch,
it seems more reasonable to rename the dt-bingdings to 'starfive,jh71x0-wdt.yaml'.
next prev parent reply other threads:[~2023-02-28 13:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:19 [PATCH v3 0/2] Add watchdog driver for StarFive JH7110 RISC-V SoC Xingyu Wu
2023-02-20 8:19 ` Xingyu Wu
2023-02-20 8:19 ` [PATCH v3 1/2] dt-bindings: watchdog: Add watchdog for StarFive JH7110 Xingyu Wu
2023-02-20 8:19 ` Xingyu Wu
2023-02-20 11:46 ` Krzysztof Kozlowski
2023-02-20 11:46 ` Krzysztof Kozlowski
2023-02-20 8:19 ` [PATCH v3 2/2] drivers: watchdog: Add StarFive Watchdog driver Xingyu Wu
2023-02-20 8:19 ` Xingyu Wu
2023-02-23 18:23 ` Guenter Roeck
2023-02-23 18:23 ` Guenter Roeck
2023-02-24 7:42 ` Xingyu Wu
2023-02-24 7:42 ` Xingyu Wu
2023-02-24 15:18 ` Guenter Roeck
2023-02-24 15:18 ` Guenter Roeck
2023-02-27 6:26 ` Xingyu Wu
2023-02-27 6:26 ` Xingyu Wu
2023-02-27 6:36 ` Guenter Roeck
2023-02-27 6:36 ` Guenter Roeck
2023-02-27 6:45 ` Xingyu Wu
2023-02-27 6:45 ` Xingyu Wu
2023-02-27 14:50 ` Guenter Roeck
2023-02-27 14:50 ` Guenter Roeck
2023-02-28 2:07 ` Xingyu Wu
2023-02-28 2:07 ` Xingyu Wu
2023-02-26 14:14 ` Emil Renner Berthing
2023-02-26 14:14 ` Emil Renner Berthing
2023-02-26 14:33 ` Conor Dooley
2023-02-26 14:33 ` Conor Dooley
2023-02-27 1:47 ` Xingyu Wu
2023-02-27 1:47 ` Xingyu Wu
2023-02-28 9:44 ` Xingyu Wu
2023-02-28 9:44 ` Xingyu Wu
2023-02-28 10:36 ` Emil Renner Berthing
2023-02-28 10:36 ` Emil Renner Berthing
2023-02-28 10:51 ` Conor Dooley
2023-02-28 10:51 ` Conor Dooley
2023-02-28 10:57 ` Krzysztof Kozlowski
2023-02-28 10:57 ` Krzysztof Kozlowski
2023-02-28 11:11 ` Conor Dooley
2023-02-28 11:11 ` Conor Dooley
2023-02-28 13:16 ` Xingyu Wu [this message]
2023-02-28 13:16 ` Xingyu Wu
2023-02-28 14:03 ` Krzysztof Kozlowski
2023-02-28 14:03 ` Krzysztof Kozlowski
2023-02-28 15:10 ` Guenter Roeck
2023-02-28 15:10 ` Guenter Roeck
2023-02-28 15:32 ` Emil Renner Berthing
2023-02-28 15:32 ` Emil Renner Berthing
2023-03-01 3:40 ` Xingyu Wu
2023-03-01 3:40 ` Xingyu Wu
2023-02-28 14:59 ` Guenter Roeck
2023-02-28 14:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e380f6-334f-11fa-1118-8d6c3c9befaf@starfivetech.com \
--to=xingyu.wu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.