From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>, Baole Ni <baolex.ni@intel.com>
Cc: dmitry.torokhov@gmail.com, hal.rosenstock@gmail.com,
dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
haibo.chen@freescale.com, andrey.gelman@compulab.co.il,
javier@osg.samsung.com, chuansheng.liu@intel.com
Subject: Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:51:54 -0500 [thread overview]
Message-ID: <f9e839e7-dcbb-00c9-eb52-45813dc864e2@ti.com> (raw)
In-Reply-To: <20160802143150.GC10376@sirena.org.uk>
On 08/02/2016 09:31 AM, Mark Brown wrote:
> On Tue, Aug 02, 2016 at 06:57:11PM +0800, Baole Ni wrote:
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
>
> Please split these up and send them independently to the relevant
> maintainers with sensible subject lines - a single 1000+ patch series is
> far too large and you're CCing random people so it's hard to tell which
> patches are relevant (for example the batch I'm replying to here are for
> the input subsystem which I don't maintain so I'm not 100% sure why I'm
> being copied here).
>
> With this sort of thing it's often best to send one series per directory
> or something similar.
>
I would recommend just adding whatever script you used to find all of
these to patchcheck or coccinelle, then let people familiar with each
subsystem make and submit the fix-ups for each subsystem. You won't get
1000+ patches to your name, but the work still gets done and you avoid
bothering a lot of people.
(I got about several of these for files I've never touched :/)
Thanks,
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>, Baole Ni <baolex.ni@intel.com>
Cc: <dmitry.torokhov@gmail.com>, <hal.rosenstock@gmail.com>,
<dledford@redhat.com>, <sean.hefty@intel.com>, <bp@alien8.de>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<haibo.chen@freescale.com>, <andrey.gelman@compulab.co.il>,
<javier@osg.samsung.com>, <chuansheng.liu@intel.com>
Subject: Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:51:54 -0500 [thread overview]
Message-ID: <f9e839e7-dcbb-00c9-eb52-45813dc864e2@ti.com> (raw)
In-Reply-To: <20160802143150.GC10376@sirena.org.uk>
On 08/02/2016 09:31 AM, Mark Brown wrote:
> On Tue, Aug 02, 2016 at 06:57:11PM +0800, Baole Ni wrote:
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
>
> Please split these up and send them independently to the relevant
> maintainers with sensible subject lines - a single 1000+ patch series is
> far too large and you're CCing random people so it's hard to tell which
> patches are relevant (for example the batch I'm replying to here are for
> the input subsystem which I don't maintain so I'm not 100% sure why I'm
> being copied here).
>
> With this sort of thing it's often best to send one series per directory
> or something similar.
>
I would recommend just adding whatever script you used to find all of
these to patchcheck or coccinelle, then let people familiar with each
subsystem make and submit the fix-ups for each subsystem. You won't get
1000+ patches to your name, but the work still gets done and you avoid
bothering a lot of people.
(I got about several of these for files I've never touched :/)
Thanks,
Andrew
next prev parent reply other threads:[~2016-08-02 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:57 [PATCH 0290/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 14:31 ` Mark Brown
2016-08-02 14:51 ` Andrew F. Davis [this message]
2016-08-02 14:51 ` Andrew F. Davis
2016-08-02 17:27 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e839e7-dcbb-00c9-eb52-45813dc864e2@ti.com \
--to=afd@ti.com \
--cc=andrey.gelman@compulab.co.il \
--cc=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=chuansheng.liu@intel.com \
--cc=dledford@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=haibo.chen@freescale.com \
--cc=hal.rosenstock@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.