Re: [PATCH 0/3] Add debugfs support to show scalable mode DMAR table

[Lu Baolu <baolu.lu@linux.intel.com>]

Hi Sai,

On 5/10/19 2:41 AM, Sai Praneeth Prakhya wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
> 
> Presently, "/sys/kernel/debug/iommu/intel/dmar_translation_struct" file dumps
> only legacy DMAR table which consists of root table and context table. Scalable
> mode DMAR table adds PASID directory and PASID table. Hence, add support to dump
> these tables as well.
> 
> Directly extending the present dumping format for PASID tables will make the
> output look clumsy. Hence, the first patch modifies the present format to a
> tabular format. The second patch introduces macros that are used during PASID
> table walk and the third patch actually adds support to dump scalable mode DMAR
> table.
> 
> Sai Praneeth (3):
>    iommu/vt-d: Modify the format of intel DMAR tables dump
>    iommu/vt-d: Introduce macros useful for dumping DMAR table
>    iommu/vt-d: Add debugfs support to show scalable mode DMAR table
>      internals

This patch set looks good to me in general. One minor suggestion is that
the author name and signed-of-by name should be consistent for all
patches.

Best regards,
Lu Baolu

> 
>   drivers/iommu/intel-iommu-debugfs.c | 132 +++++++++++++++++++++++++++++-------
>   drivers/iommu/intel-pasid.c         |  17 -----
>   drivers/iommu/intel-pasid.h         |  26 +++++++
>   3 files changed, 134 insertions(+), 41 deletions(-)
> 
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Ashok Raj <ashok.raj@intel.com>
> Cc: Lu Baolu <baolu.lu@linux.intel.com>
> Cc: Sohil Mehta <sohil.mehta@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu