From: Krzysztof Kozlowski <krzk@kernel.org>
To: Quentin Schulz <quentin.schulz@cherry.de>,
Jason Yang <jason98166@gmail.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Guochun Huang <hero.huang@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Michael Riesch <michael.riesch@collabora.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type
Date: Wed, 18 Nov 2026 11:08:06 +0100 [thread overview]
Message-ID: <fceee6fa-2bfb-4676-b5ac-80e1bae8d4f4@kernel.org> (raw)
In-Reply-To: <fe324e43-50c4-4f0e-9bb0-57ea7172530b@cherry.de>
On 18/11/2026 10:28, Quentin Schulz wrote:
> Hi Krzysztof,
>
> On 11/18/26 9:16 AM, Krzysztof Kozlowski wrote:
>> On 18/11/2026 06:55, Jason Yang wrote:
>>> The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter
>>> for DSI and a receiver for CSI-2, and the DSI host and the CSI-2 host
>>> can use the transmitter and the receiver at the same time. The single
>>> cell of this binding selects the mode and refers to the transmitter, so
>>> the receiver cannot be described.
>>>
>>> Change the cell to select the transmitter or the receiver. The
>>> transmitter and the receiver cannot operate in different modes [1], so
>>> the optional phy-type property of the PHY node sets the mode for the
>>> whole block, D-PHY by default:
>>>
>>> /* the MIPI DSI host, driving the transmitter */
>>> phys = <&mipidcphy0 PHY_DIRECTION_TX>;
>>>
>>> /* the MIPI CSI-2 host, driving the receiver */
>>> phys = <&mipidcphy0 PHY_DIRECTION_RX>;
>>>
>>> For C-PHY the consumers stay the same and the PHY node gets:
>>>
>>> phy-type = <PHY_TYPE_CPHY>;
>>>
>>> Existing DTs on a newer kernel: PHY_TYPE_DPHY and PHY_TYPE_CPHY remain
>>> valid as deprecated values. They select the transmitter and imply
>>> phy-type = <PHY_TYPE_DPHY> or <PHY_TYPE_CPHY> respectively, so nothing
>>> changes for them.
>>>
>>> New DTs on an older kernel: an ABI break. The older kernel ignores
>>> phy-type and takes any cell value as the mode of the block. A DSI node
>>> with PHY_DIRECTION_TX therefore gets no display, and a CSI-2 node with
>>> PHY_DIRECTION_RX gets no camera.
>>>
>>> [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support
>>> operate in the same PHY mode."
>>>
>>> Suggested-by: Michael Riesch <michael.riesch@collabora.com>
>>> Link: https://lore.kernel.org/r/94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com
>>> Signed-off-by: Jason Yang <jason98166@gmail.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
>>> Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI
>>
>> Please drop the tag, this did not happen. In the future, please add only
>> applicable tags. Otherwise share how this code was executed and tested
>> on the actual hardware (make process, like building code, is obviously
>> not testing).
>>
>
> What did not happen? I tested the v6, on the reported hardware, on the
> reported two DCPHYs, see
> https://lore.kernel.org/all/840285d6-a8a6-4777-8d38-6758ccbc7723@cherry.de/
I comment in a specific place in a specific patch. The testing of this
patch did not happen, which I explained why.
>
> If you're complaining about the Tested-by being given to a dt-binding
> patch, it was provided as an answer to the cover-letter, and the
I know. Tag was applied blindly and that I ask to correct.
> contributor is clearly using b4 considering the last few lines from the
> cover letter (base-commit/change-id lines). b4 trailers -u applies the
> tags given to the cover letter to all patches in the series, so if
> there's someone to blame here, it's me for adding it as an answer to the
> cover letter. So now the question is, do you want me to add a Tested-by:
> to each individual patches of long series when I technically built and
The comment was not to you. I responded to the contributor and I expect
the contributor to act, not you.
> tested only based on the last patch of the series, which is only a DTS
> patch adding the nodes to the RK3588 DTSI? In that case, I cannot
> provide Tested-by for patches before the last, as it can simply not work
> at all until the last (actually all of them, except the bindings) patch
> is applied.
>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Quentin Schulz <quentin.schulz@cherry.de>,
Jason Yang <jason98166@gmail.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Guochun Huang <hero.huang@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Michael Riesch <michael.riesch@collabora.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type
Date: Wed, 18 Nov 2026 11:08:06 +0100 [thread overview]
Message-ID: <fceee6fa-2bfb-4676-b5ac-80e1bae8d4f4@kernel.org> (raw)
In-Reply-To: <fe324e43-50c4-4f0e-9bb0-57ea7172530b@cherry.de>
On 18/11/2026 10:28, Quentin Schulz wrote:
> Hi Krzysztof,
>
> On 11/18/26 9:16 AM, Krzysztof Kozlowski wrote:
>> On 18/11/2026 06:55, Jason Yang wrote:
>>> The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter
>>> for DSI and a receiver for CSI-2, and the DSI host and the CSI-2 host
>>> can use the transmitter and the receiver at the same time. The single
>>> cell of this binding selects the mode and refers to the transmitter, so
>>> the receiver cannot be described.
>>>
>>> Change the cell to select the transmitter or the receiver. The
>>> transmitter and the receiver cannot operate in different modes [1], so
>>> the optional phy-type property of the PHY node sets the mode for the
>>> whole block, D-PHY by default:
>>>
>>> /* the MIPI DSI host, driving the transmitter */
>>> phys = <&mipidcphy0 PHY_DIRECTION_TX>;
>>>
>>> /* the MIPI CSI-2 host, driving the receiver */
>>> phys = <&mipidcphy0 PHY_DIRECTION_RX>;
>>>
>>> For C-PHY the consumers stay the same and the PHY node gets:
>>>
>>> phy-type = <PHY_TYPE_CPHY>;
>>>
>>> Existing DTs on a newer kernel: PHY_TYPE_DPHY and PHY_TYPE_CPHY remain
>>> valid as deprecated values. They select the transmitter and imply
>>> phy-type = <PHY_TYPE_DPHY> or <PHY_TYPE_CPHY> respectively, so nothing
>>> changes for them.
>>>
>>> New DTs on an older kernel: an ABI break. The older kernel ignores
>>> phy-type and takes any cell value as the mode of the block. A DSI node
>>> with PHY_DIRECTION_TX therefore gets no display, and a CSI-2 node with
>>> PHY_DIRECTION_RX gets no camera.
>>>
>>> [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support
>>> operate in the same PHY mode."
>>>
>>> Suggested-by: Michael Riesch <michael.riesch@collabora.com>
>>> Link: https://lore.kernel.org/r/94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com
>>> Signed-off-by: Jason Yang <jason98166@gmail.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
>>> Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI
>>
>> Please drop the tag, this did not happen. In the future, please add only
>> applicable tags. Otherwise share how this code was executed and tested
>> on the actual hardware (make process, like building code, is obviously
>> not testing).
>>
>
> What did not happen? I tested the v6, on the reported hardware, on the
> reported two DCPHYs, see
> https://lore.kernel.org/all/840285d6-a8a6-4777-8d38-6758ccbc7723@cherry.de/
I comment in a specific place in a specific patch. The testing of this
patch did not happen, which I explained why.
>
> If you're complaining about the Tested-by being given to a dt-binding
> patch, it was provided as an answer to the cover-letter, and the
I know. Tag was applied blindly and that I ask to correct.
> contributor is clearly using b4 considering the last few lines from the
> cover letter (base-commit/change-id lines). b4 trailers -u applies the
> tags given to the cover letter to all patches in the series, so if
> there's someone to blame here, it's me for adding it as an answer to the
> cover letter. So now the question is, do you want me to add a Tested-by:
> to each individual patches of long series when I technically built and
The comment was not to you. I responded to the contributor and I expect
the contributor to act, not you.
> tested only based on the last patch of the series, which is only a DTS
> patch adding the nodes to the RK3588 DTSI? In that case, I cannot
> provide Tested-by for patches before the last, as it can simply not work
> at all until the last (actually all of them, except the bindings) patch
> is applied.
>
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Quentin Schulz <quentin.schulz@cherry.de>,
Jason Yang <jason98166@gmail.com>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Guochun Huang <hero.huang@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Michael Riesch <michael.riesch@collabora.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type
Date: Wed, 18 Nov 2026 11:08:06 +0100 [thread overview]
Message-ID: <fceee6fa-2bfb-4676-b5ac-80e1bae8d4f4@kernel.org> (raw)
In-Reply-To: <fe324e43-50c4-4f0e-9bb0-57ea7172530b@cherry.de>
On 18/11/2026 10:28, Quentin Schulz wrote:
> Hi Krzysztof,
>
> On 11/18/26 9:16 AM, Krzysztof Kozlowski wrote:
>> On 18/11/2026 06:55, Jason Yang wrote:
>>> The Samsung MIPI D-/C-PHY block on RK3588 and RK3576 has a transmitter
>>> for DSI and a receiver for CSI-2, and the DSI host and the CSI-2 host
>>> can use the transmitter and the receiver at the same time. The single
>>> cell of this binding selects the mode and refers to the transmitter, so
>>> the receiver cannot be described.
>>>
>>> Change the cell to select the transmitter or the receiver. The
>>> transmitter and the receiver cannot operate in different modes [1], so
>>> the optional phy-type property of the PHY node sets the mode for the
>>> whole block, D-PHY by default:
>>>
>>> /* the MIPI DSI host, driving the transmitter */
>>> phys = <&mipidcphy0 PHY_DIRECTION_TX>;
>>>
>>> /* the MIPI CSI-2 host, driving the receiver */
>>> phys = <&mipidcphy0 PHY_DIRECTION_RX>;
>>>
>>> For C-PHY the consumers stay the same and the PHY node gets:
>>>
>>> phy-type = <PHY_TYPE_CPHY>;
>>>
>>> Existing DTs on a newer kernel: PHY_TYPE_DPHY and PHY_TYPE_CPHY remain
>>> valid as deprecated values. They select the transmitter and imply
>>> phy-type = <PHY_TYPE_DPHY> or <PHY_TYPE_CPHY> respectively, so nothing
>>> changes for them.
>>>
>>> New DTs on an older kernel: an ABI break. The older kernel ignores
>>> phy-type and takes any cell value as the mode of the block. A DSI node
>>> with PHY_DIRECTION_TX therefore gets no display, and a CSI-2 node with
>>> PHY_DIRECTION_RX gets no camera.
>>>
>>> [1] RK3588 TRM: section 22.1 (overview): "The TX and RX only support
>>> operate in the same PHY mode."
>>>
>>> Suggested-by: Michael Riesch <michael.riesch@collabora.com>
>>> Link: https://lore.kernel.org/r/94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com
>>> Signed-off-by: Jason Yang <jason98166@gmail.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
>>> Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI
>>
>> Please drop the tag, this did not happen. In the future, please add only
>> applicable tags. Otherwise share how this code was executed and tested
>> on the actual hardware (make process, like building code, is obviously
>> not testing).
>>
>
> What did not happen? I tested the v6, on the reported hardware, on the
> reported two DCPHYs, see
> https://lore.kernel.org/all/840285d6-a8a6-4777-8d38-6758ccbc7723@cherry.de/
I comment in a specific place in a specific patch. The testing of this
patch did not happen, which I explained why.
>
> If you're complaining about the Tested-by being given to a dt-binding
> patch, it was provided as an answer to the cover-letter, and the
I know. Tag was applied blindly and that I ask to correct.
> contributor is clearly using b4 considering the last few lines from the
> cover letter (base-commit/change-id lines). b4 trailers -u applies the
> tags given to the cover letter to all patches in the series, so if
> there's someone to blame here, it's me for adding it as an answer to the
> cover letter. So now the question is, do you want me to add a Tested-by:
> to each individual patches of long series when I technically built and
The comment was not to you. I responded to the contributor and I expect
the contributor to act, not you.
> tested only based on the last patch of the series, which is only a DTS
> patch adding the nodes to the RK3588 DTSI? In that case, I cannot
> provide Tested-by for patches before the last, as it can simply not work
> at all until the last (actually all of them, except the bindings) patch
> is applied.
>
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-18 10:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 5:55 [PATCH v7 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 1/9] dt-bindings: phy: Add PHY_DIRECTION_TX/RX definitions Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 5:55 ` [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 8:16 ` Krzysztof Kozlowski
2026-11-18 9:28 ` Quentin Schulz
2026-11-18 9:28 ` Quentin Schulz
2026-11-18 9:28 ` Quentin Schulz
2026-11-18 10:08 ` Krzysztof Kozlowski [this message]
2026-11-18 10:08 ` Krzysztof Kozlowski
2026-11-18 10:08 ` Krzysztof Kozlowski
2026-11-18 10:30 ` Quentin Schulz
2026-11-18 10:30 ` Quentin Schulz
2026-11-18 10:30 ` Quentin Schulz
2026-11-18 5:55 ` [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 6:02 ` sashiko-bot
2026-11-18 6:02 ` sashiko-bot
2026-11-18 5:55 ` [PATCH v7 4/9] phy: rockchip-samsung-dcphy: Always write the rate-dependent registers Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 5/9] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 6:07 ` sashiko-bot
2026-11-18 6:07 ` sashiko-bot
2026-11-18 5:55 ` [PATCH v7 6/9] phy: rockchip-samsung-dcphy: Name the transmitter helpers and ops Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 7/9] phy: rockchip-samsung-dcphy: Support the new phy-type and direction binding Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 8/9] phy: rockchip-samsung-dcphy: Add MIPI D-PHY receiver support Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 9/9] arm64: dts: rockchip: add the dcphy mipi csi-2 receiver nodes to rk3588 Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fceee6fa-2bfb-4676-b5ac-80e1bae8d4f4@kernel.org \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hero.huang@rock-chips.com \
--cc=jason98166@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mani@kernel.org \
--cc=michael.riesch@collabora.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.