From: sashiko-bot@kernel.org
To: "Jason Yang" <jason98166@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
Date: Wed, 18 Nov 2026 06:02:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-220195@kernel.org> (raw)
In-Reply-To: <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] phy: rockchip-samsung-dcphy: missing Fixes trailer for PLL lock
unwind
--
commit 6c4b17f61ef61ed9fbe1eb97449b228aaba3f155
Author: Jason Yang <jason98166@gmail.com>
> phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
>
> samsung_mipi_dphy_power_on() returns on a PLL lock timeout with PLL_EN
> set and m_phy_rst still asserted, and the PHY core does not call
> power_off after a failed power_on.
>
> Today the APB reset at the start of the next power_on cleans this up.
>
> A later change moves that reset to runtime resume, so the leftover
> PLL_EN would stay set, and regmap_update_bits() would not even write
> it again.
>
> Unwind the power-on before returning the error.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/linux-phy/sashiko-outbox-174059@kernel.org/
> Signed-off-by: Jason Yang <jason98166@gmail.com>
> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
> Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI
[Severity: Low]
This fixes the incomplete error path in samsung_mipi_dphy_power_on().
Should this include:
Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com?part=3
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Jason Yang" <jason98166@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
Date: Wed, 18 Nov 2026 06:02:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-220195@kernel.org> (raw)
In-Reply-To: <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] phy: rockchip-samsung-dcphy: missing Fixes trailer for PLL lock
unwind
--
commit 6c4b17f61ef61ed9fbe1eb97449b228aaba3f155
Author: Jason Yang <jason98166@gmail.com>
> phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure
>
> samsung_mipi_dphy_power_on() returns on a PLL lock timeout with PLL_EN
> set and m_phy_rst still asserted, and the PHY core does not call
> power_off after a failed power_on.
>
> Today the APB reset at the start of the next power_on cleans this up.
>
> A later change moves that reset to runtime resume, so the leftover
> PLL_EN would stay set, and regmap_update_bits() would not even write
> it again.
>
> Unwind the power-on before returning the error.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/linux-phy/sashiko-outbox-174059@kernel.org/
> Signed-off-by: Jason Yang <jason98166@gmail.com>
> Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
> Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # RK3588 Tiger CSI1 2-lane IMX219, CSI0 2-lane OV5675+DSI
[Severity: Low]
This fixes the incomplete error path in samsung_mipi_dphy_power_on().
Should this include:
Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com?part=3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-18 6:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 5:55 [PATCH v7 0/9] phy: rockchip-samsung-dcphy: Add the MIPI D-PHY receiver Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 1/9] dt-bindings: phy: Add PHY_DIRECTION_TX/RX definitions Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 2/9] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Select TX or RX, add phy-type Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 6:02 ` sashiko-bot [this message]
2026-11-18 6:02 ` sashiko-bot
2026-11-18 5:55 ` [PATCH v7 4/9] phy: rockchip-samsung-dcphy: Always write the rate-dependent registers Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 5/9] phy: rockchip-samsung-dcphy: Move block-level setup to runtime resume Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 6:07 ` sashiko-bot
2026-11-18 6:07 ` sashiko-bot
2026-11-18 5:55 ` [PATCH v7 6/9] phy: rockchip-samsung-dcphy: Name the transmitter helpers and ops Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 7/9] phy: rockchip-samsung-dcphy: Support the new phy-type and direction binding Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 8/9] phy: rockchip-samsung-dcphy: Add MIPI D-PHY receiver support Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` [PATCH v7 9/9] arm64: dts: rockchip: add the dcphy mipi csi-2 receiver nodes to rk3588 Jason Yang
2026-11-18 5:55 ` Jason Yang
2026-11-18 5:55 ` Jason Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220195@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jason98166@gmail.com \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.