Some review for the stefan/xo-support branch

Some review for the stefan/xo-support branch

[Stefan Schmidt]

Hello.

I just pushed a branch which adds a machine file for the XO, aka OLPC, laptop
and a kernel recipe for it.

This allows me to build images for the xo machine in Angstrom.

I don't see how these commits could break anything, but as it is my first
machine I would like to get some review/acks before pushing it into the main
tree.

Only three commits:
http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=f5fbcf7e4e0228e10fa2c29f802ea0eaabf7a202
http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=eff435600359d5f13d846be1480de73e8837133d
http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=ed58062633bdba98098044e94ffce9207300e4be

regards
Stefan Schmidt

Re: Some review for the stefan/xo-support branch

[Koen Kooi]

On 22-10-2008 16:10, Stefan Schmidt wrote:
> Hello.
>
> I just pushed a branch which adds a machine file for the XO, aka OLPC, laptop
> and a kernel recipe for it.
>
> This allows me to build images for the xo machine in Angstrom.
>
> I don't see how these commits could break anything, but as it is my first
> machine I would like to get some review/acks before pushing it into the main
> tree.
>
> Only three commits:
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=f5fbcf7e4e0228e10fa2c29f802ea0eaabf7a202
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=eff435600359d5f13d846be1480de73e8837133d
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=ed58062633bdba98098044e94ffce9207300e4be

One comment:

+PV = "2.6-olpc+git${SRCREV}"

That should be:

2.6.34+gitr${SRCREV}

regards,

Koen

Re: Some review for the stefan/xo-support branch

[Stefan Schmidt]

Hello.

On Wed, 2008-10-22 at 18:07, Koen Kooi wrote:
>
> One comment:
>
> +PV = "2.6-olpc+git${SRCREV}"
>
> That should be:
>
> 2.6.34+gitr${SRCREV}

Good point. The newest mainline tag I could find inside the repo was .22

http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=973295dbb4ab499c2c61972d0410ed8385d93447

One of the next steps is to test out how good mainline support is nowadays for
the XOs.

regards
Stefan Schmidt

Re: Some review for the stefan/xo-support branch

[Koen Kooi]

On 23-10-2008 19:38, Stefan Schmidt wrote:
> Hello.
>
> On Wed, 2008-10-22 at 18:07, Koen Kooi wrote:
>> One comment:
>>
>> +PV = "2.6-olpc+git${SRCREV}"
>>
>> That should be:
>>
>> 2.6.34+gitr${SRCREV}
>
> Good point. The newest mainline tag I could find inside the repo was .22

The easiest way is to look at the top-level kernel makefile, that has 
the exact version.

> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=973295dbb4ab499c2c61972d0410ed8385d93447

Looks good!

> One of the next steps is to test out how good mainline support is nowadays for
> the XOs.

Some sugar people are working on expanding the sugar support in OE, you 
can track their work here: 
https://www.develer.com/gitweb/pub?p=users/bernie/beagle-sugar.git;a=summary

They plan to send us polished patches later on.

regards,

Koen

Re: Some review for the stefan/xo-support branch

[Stefan Schmidt]

Hello.

On Thu, 2008-10-23 at 19:56, Koen Kooi wrote:
> On 23-10-2008 19:38, Stefan Schmidt wrote:
>>
>> Good point. The newest mainline tag I could find inside the repo was .22
>
> The easiest way is to look at the top-level kernel makefile, that has  
> the exact version.

That would indeed have been easier. :)

>> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=973295dbb4ab499c2c61972d0410ed8385d93447
>
> Looks good!

So you are through with your review? Anybody else objections about me pushing
this in org.oe.dev?

>> One of the next steps is to test out how good mainline support is nowadays for
>> the XOs.
>
> Some sugar people are working on expanding the sugar support in OE, you  
> can track their work here:  
> https://www.develer.com/gitweb/pub?p=users/bernie/beagle-sugar.git;a=summary
>
> They plan to send us polished patches later on.

Great. With all the other people working on sugar in OE I'll keep my work around
the XO machine support. That way the pieces come together later.

regards
Stefan Schmidt

Re: Some review for the stefan/xo-support branch

[Koen Kooi]

On 24-10-2008 00:18, Stefan Schmidt wrote:
> Hello.
>
> On Thu, 2008-10-23 at 19:56, Koen Kooi wrote:
>> On 23-10-2008 19:38, Stefan Schmidt wrote:
>>> Good point. The newest mainline tag I could find inside the repo was .22
>> The easiest way is to look at the top-level kernel makefile, that has
>> the exact version.
>
> That would indeed have been easier. :)
>
>>> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=973295dbb4ab499c2c61972d0410ed8385d93447
>> Looks good!
>
> So you are through with your review? Anybody else objections about me pushing
> this in org.oe.dev?

The PV was my only comment, the rest looks good enough to go in.

regards,

Koen

Re: Some review for the stefan/xo-support branch

[Stefan Schmidt]

Hello

On Fri, 2008-10-24 at 15:08, Koen Kooi wrote:
> On 24-10-2008 00:18, Stefan Schmidt wrote:
>>
>> On Thu, 2008-10-23 at 19:56, Koen Kooi wrote:
>>> On 23-10-2008 19:38, Stefan Schmidt wrote:
>>>> Good point. The newest mainline tag I could find inside the repo was .22
>>> The easiest way is to look at the top-level kernel makefile, that has
>>> the exact version.
>>
>> That would indeed have been easier. :)
>>
>>>> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=973295dbb4ab499c2c61972d0410ed8385d93447
>>> Looks good!
>>
>> So you are through with your review? Anybody else objections about me pushing
>> this in org.oe.dev?
>
> The PV was my only comment, the rest looks good enough to go in.

OK, thanks. I'm busy tomorrow so I'll put it in tomorrow evening or sunday.
Gives also one more day for last minute comments.

regards
Stefan Schmidt