From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: Please review john_lee/openmoko-merges again
Date: Mon, 22 Dec 2008 13:11:05 +0100 [thread overview]
Message-ID: <gio04p$i9p$1@ger.gmane.org> (raw)
In-Reply-To: <20081222100950.GA2135@buddha.tw.openmoko.com>
On 22-12-08 11:09, John Lee wrote:
> Hi,
>
> I have reduced this to just 5 commits. Most of them should be okay
> except I'm not sure about this one:
>
> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
> Author: Erin Yueh<erin_yueh@openmoko.com>
> Date: Tue Dec 2 13:57:18 2008 +0800
>
> obexpush_1.0.0.bb: add opd_args file to append arguments for starting
> opd
>
> Please review and comment, thank you!
I don't think pointing a daemon to a user homedir is acceptable
behaviour, much less pointing it /home/root.
Would /var/tmp/obexpush be an acceptable path?
regards,
Koen
next prev parent reply other threads:[~2008-12-22 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 10:09 Please review john_lee/openmoko-merges again John Lee
2008-12-22 12:11 ` Koen Kooi [this message]
2008-12-24 4:33 ` John Lee
2009-01-05 9:07 ` John Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gio04p$i9p$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.