* Please review john_lee/openmoko-merges again
@ 2008-12-22 10:09 John Lee
2008-12-22 12:11 ` Koen Kooi
0 siblings, 1 reply; 4+ messages in thread
From: John Lee @ 2008-12-22 10:09 UTC (permalink / raw)
To: openembedded-devel
Hi,
I have reduced this to just 5 commits. Most of them should be okay
except I'm not sure about this one:
commit 4d6693ebd979092a747a66cb1828b8b4af452b28
Author: Erin Yueh <erin_yueh@openmoko.com>
Date: Tue Dec 2 13:57:18 2008 +0800
obexpush_1.0.0.bb: add opd_args file to append arguments for starting
opd
Please review and comment, thank you!
Regards,
John
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Please review john_lee/openmoko-merges again
2008-12-22 10:09 Please review john_lee/openmoko-merges again John Lee
@ 2008-12-22 12:11 ` Koen Kooi
2008-12-24 4:33 ` John Lee
0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2008-12-22 12:11 UTC (permalink / raw)
To: openembedded-devel
On 22-12-08 11:09, John Lee wrote:
> Hi,
>
> I have reduced this to just 5 commits. Most of them should be okay
> except I'm not sure about this one:
>
> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
> Author: Erin Yueh<erin_yueh@openmoko.com>
> Date: Tue Dec 2 13:57:18 2008 +0800
>
> obexpush_1.0.0.bb: add opd_args file to append arguments for starting
> opd
>
> Please review and comment, thank you!
I don't think pointing a daemon to a user homedir is acceptable
behaviour, much less pointing it /home/root.
Would /var/tmp/obexpush be an acceptable path?
regards,
Koen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Please review john_lee/openmoko-merges again
2008-12-22 12:11 ` Koen Kooi
@ 2008-12-24 4:33 ` John Lee
2009-01-05 9:07 ` John Lee
0 siblings, 1 reply; 4+ messages in thread
From: John Lee @ 2008-12-24 4:33 UTC (permalink / raw)
To: openembedded-devel
On Mon, Dec 22, 2008 at 01:11:05PM +0100, Koen Kooi wrote:
> On 22-12-08 11:09, John Lee wrote:
>> Hi,
>>
>> I have reduced this to just 5 commits. Most of them should be okay
>> except I'm not sure about this one:
>>
>> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
>> Author: Erin Yueh<erin_yueh@openmoko.com>
>> Date: Tue Dec 2 13:57:18 2008 +0800
>>
>> obexpush_1.0.0.bb: add opd_args file to append arguments for starting
>> opd
>>
>> Please review and comment, thank you!
>
> I don't think pointing a daemon to a user homedir is acceptable
> behaviour, much less pointing it /home/root.
>
> Would /var/tmp/obexpush be an acceptable path?
Branch updated to use /var/obexpush as suggested in other mail.
Due to the Christmas vacation I will wait until next year to push
these. Please review. :)
- John
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Please review john_lee/openmoko-merges again
2008-12-24 4:33 ` John Lee
@ 2009-01-05 9:07 ` John Lee
0 siblings, 0 replies; 4+ messages in thread
From: John Lee @ 2009-01-05 9:07 UTC (permalink / raw)
To: openembedded-devel
On Wed, Dec 24, 2008 at 12:33:59PM +0800, John Lee wrote:
> On Mon, Dec 22, 2008 at 01:11:05PM +0100, Koen Kooi wrote:
> > On 22-12-08 11:09, John Lee wrote:
> >> Hi,
> >>
> >> I have reduced this to just 5 commits. Most of them should be okay
> >> except I'm not sure about this one:
> >>
> >> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
> >> Author: Erin Yueh<erin_yueh@openmoko.com>
> >> Date: Tue Dec 2 13:57:18 2008 +0800
> >>
> >> obexpush_1.0.0.bb: add opd_args file to append arguments for starting
> >> opd
> >>
> >> Please review and comment, thank you!
> >
> > I don't think pointing a daemon to a user homedir is acceptable
> > behaviour, much less pointing it /home/root.
> >
> > Would /var/tmp/obexpush be an acceptable path?
>
> Branch updated to use /var/obexpush as suggested in other mail.
> Due to the Christmas vacation I will wait until next year to push
> these. Please review. :)
Pushed to org.openembedded.dev. Could someone please delete
john_lee/openmoko-merges ?
- John
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-05 9:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-22 10:09 Please review john_lee/openmoko-merges again John Lee
2008-12-22 12:11 ` Koen Kooi
2008-12-24 4:33 ` John Lee
2009-01-05 9:07 ` John Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.