Please review john_lee/openmoko-merges again

Please review john_lee/openmoko-merges again

[John Lee]

Hi,

I have reduced this to just 5 commits.  Most of them should be okay
except I'm not sure about this one:

commit 4d6693ebd979092a747a66cb1828b8b4af452b28
Author: Erin Yueh <erin_yueh@openmoko.com>
Date:   Tue Dec 2 13:57:18 2008 +0800

    obexpush_1.0.0.bb: add opd_args file to append arguments for starting
    opd

Please review and comment, thank you!


Regards,
John

Re: Please review john_lee/openmoko-merges again

[Koen Kooi]

On 22-12-08 11:09, John Lee wrote:
> Hi,
>
> I have reduced this to just 5 commits.  Most of them should be okay
> except I'm not sure about this one:
>
> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
> Author: Erin Yueh<erin_yueh@openmoko.com>
> Date:   Tue Dec 2 13:57:18 2008 +0800
>
>      obexpush_1.0.0.bb: add opd_args file to append arguments for starting
>      opd
>
> Please review and comment, thank you!

I don't think pointing a daemon to a user homedir is acceptable 
behaviour, much less pointing it /home/root.

Would /var/tmp/obexpush be an acceptable path?

regards,

Koen

Re: Please review john_lee/openmoko-merges again

[John Lee]

On Mon, Dec 22, 2008 at 01:11:05PM +0100, Koen Kooi wrote:
> On 22-12-08 11:09, John Lee wrote:
>> Hi,
>>
>> I have reduced this to just 5 commits.  Most of them should be okay
>> except I'm not sure about this one:
>>
>> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
>> Author: Erin Yueh<erin_yueh@openmoko.com>
>> Date:   Tue Dec 2 13:57:18 2008 +0800
>>
>>      obexpush_1.0.0.bb: add opd_args file to append arguments for starting
>>      opd
>>
>> Please review and comment, thank you!
>
> I don't think pointing a daemon to a user homedir is acceptable  
> behaviour, much less pointing it /home/root.
>
> Would /var/tmp/obexpush be an acceptable path?

Branch updated to use /var/obexpush as suggested in other mail.
Due to the Christmas vacation I will wait until next year to push
these.  Please review.  :)


- John

Re: Please review john_lee/openmoko-merges again

[John Lee]

On Wed, Dec 24, 2008 at 12:33:59PM +0800, John Lee wrote:
> On Mon, Dec 22, 2008 at 01:11:05PM +0100, Koen Kooi wrote:
> > On 22-12-08 11:09, John Lee wrote:
> >> Hi,
> >>
> >> I have reduced this to just 5 commits.  Most of them should be okay
> >> except I'm not sure about this one:
> >>
> >> commit 4d6693ebd979092a747a66cb1828b8b4af452b28
> >> Author: Erin Yueh<erin_yueh@openmoko.com>
> >> Date:   Tue Dec 2 13:57:18 2008 +0800
> >>
> >>      obexpush_1.0.0.bb: add opd_args file to append arguments for starting
> >>      opd
> >>
> >> Please review and comment, thank you!
> >
> > I don't think pointing a daemon to a user homedir is acceptable  
> > behaviour, much less pointing it /home/root.
> >
> > Would /var/tmp/obexpush be an acceptable path?
> 
> Branch updated to use /var/obexpush as suggested in other mail.
> Due to the Christmas vacation I will wait until next year to push
> these.  Please review.  :)

Pushed to org.openembedded.dev.  Could someone please delete
john_lee/openmoko-merges ?


- John