All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MokoTouch
@ 2009-10-26 20:25 David Lanzendörfer
  2009-10-26 20:43 ` Marcin Juszkiewicz
  2009-11-05 20:01 ` Michael 'Mickey' Lauer
  0 siblings, 2 replies; 7+ messages in thread
From: David Lanzendörfer @ 2009-10-26 20:25 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 171 bytes --]

Hi folks
I'd like to have mokotouch-recipes added to OE.

greatings
	leviathan
-- 
David Lanzendörfer
OpenSourceSupport GmbH
Junior system engineer and supporter

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: add-mokotouch.patch --]
[-- Type: text/x-patch; charset="UTF-8"; name="add-mokotouch.patch", Size: 13159 bytes --]

commit ca215a1df93741a136a482c9f0af5bdad06bbd7a
Author: David Lanzendörfer <david.lanzendoerfer@o2s.ch>
Date:   Mon Oct 26 19:36:17 2009 +0100

    Added mokotouch recipes

diff --git a/recipes/mokotouch/mokotouch-apps-customtableview_2.bb b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
new file mode 100644
index 0000000..e380af7
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/CustomTableView
+${OE_QMAKE_QMAKE} CustomTableView.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/CustomTableView.app
+cp "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/usr/local/MokoTouch/Apps/CustomTableView.app"
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/CustomTableView.app/libCustomTableView.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -fs /usr/local/MokoTouch/Apps/CustomTableView.app/libCustomTableView.so.1.0.0 /usr/lib/libCustomTableView.so.1.0.0
+ln -fs /usr/local/MokoTouch/Apps/CustomTableView.app/libCustomTableView.so.1.0.0 /usr/lib/libCustomTableView.so.1.0
+ln -fs /usr/local/MokoTouch/Apps/CustomTableView.app/libCustomTableView.so.1.0.0 /usr/lib/libCustomTableView.so.1
+ln -fs /usr/local/MokoTouch/Apps/CustomTableView.app/libCustomTableView.so.1.0.0 /usr/lib/libCustomTableView.so
+}
diff --git a/recipes/mokotouch/mokotouch-apps-helloworld_2.bb b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
new file mode 100644
index 0000000..f4d1fa8
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/HelloWorld
+${OE_QMAKE_QMAKE} HelloWorld.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/HelloWorld.app
+cp ${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0 ${D}/usr/local/MokoTouch/Apps/HelloWorld.app/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/HelloWorld.app/libHelloWorld.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -sf /usr/local/MokoTouch/Apps/HelloWorld.app/libHelloWorld.so.1.0.0 /usr/lib/libHelloWorld.so.1.0.0
+ln -sf /usr/local/MokoTouch/Apps/HelloWorld.app/libHelloWorld.so.1.0.0 /usr/lib/libHelloWorld.so.1.0
+ln -sf /usr/local/MokoTouch/Apps/HelloWorld.app/libHelloWorld.so.1.0.0 /usr/lib/libHelloWorld.so.1
+ln -sf /usr/local/MokoTouch/Apps/HelloWorld.app/libHelloWorld.so.1.0.0 /usr/lib/libHelloWorld.so
+}
diff --git a/recipes/mokotouch/mokotouch-apps-homescreen_2.bb b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
new file mode 100644
index 0000000..b134c2c
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/Homescreen
+${OE_QMAKE_QMAKE} Homescreen.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/Homescreen.app
+cp ${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0 ${D}/usr/local/MokoTouch/Apps/Homescreen.app/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/Homescreen.app/libHomescreen.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -sf /usr/local/MokoTouch/Apps/Homescreen.app/libHomescreen.so.1.0.0 /usr/lib/libHomescreen.so.1.0.0
+ln -sf /usr/local/MokoTouch/Apps/Homescreen.app/libHomescreen.so.1.0.0 /usr/lib/libHomescreen.so.1.0
+ln -sf /usr/local/MokoTouch/Apps/Homescreen.app/libHomescreen.so.1.0.0 /usr/lib/libHomescreen.so.1
+ln -sf /usr/local/MokoTouch/Apps/Homescreen.app/libHomescreen.so.1.0.0 /usr/lib/libHomescreen.so
+}
diff --git a/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
new file mode 100644
index 0000000..0c39c57
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/TestKeyboard
+${OE_QMAKE_QMAKE} TestKeyboard.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/TestKeyboard.app
+cp ${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0 ${D}/usr/local/MokoTouch/Apps/TestKeyboard.app/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/TestKeyboard.app/libTestKeyboard.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -sf /usr/local/MokoTouch/Apps/TestKeyboard.app/libTestKeyboard.so.1.0.0 /usr/lib/libTestKeyboard.so.1.0.0
+ln -sf /usr/local/MokoTouch/Apps/TestKeyboard.app/libTestKeyboard.so.1.0.0 /usr/lib/libTestKeyboard.so.1.0
+ln -sf /usr/local/MokoTouch/Apps/TestKeyboard.app/libTestKeyboard.so.1.0.0 /usr/lib/libTestKeyboard.so.1
+ln -sf /usr/local/MokoTouch/Apps/TestKeyboard.app/libTestKeyboard.so.1.0.0 /usr/lib/libTestKeyboard.so
+}
diff --git a/recipes/mokotouch/mokotouch-apps-testtableview_2.bb b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
new file mode 100644
index 0000000..829476c
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/TestTableView
+${OE_QMAKE_QMAKE} TestTableView.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/TestTableView.app
+cp ${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0 ${D}/usr/local/MokoTouch/Apps/TestTableView.app/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/TestTableView.app/libTestTableView.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -sf /usr/local/MokoTouch/Apps/TestTableView.app/libTestTableView.so.1.0.0 /usr/lib/libTestTableView.so.1.0.0
+ln -sf /usr/local/MokoTouch/Apps/TestTableView.app/libTestTableView.so.1.0.0 /usr/lib/libTestTableView.so.1.0
+ln -sf /usr/local/MokoTouch/Apps/TestTableView.app/libTestTableView.so.1.0.0 /usr/lib/libTestTableView.so.1
+ln -sf /usr/local/MokoTouch/Apps/TestTableView.app/libTestTableView.so.1.0.0 /usr/lib/libTestTableView.so
+}
diff --git a/recipes/mokotouch/mokotouch-apps-webmobile_2.bb b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
new file mode 100644
index 0000000..d81c2b1
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-coreservices-mokotouch"
+RDEPENDS += "mokotouch-coreservices-mokotouch"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Apps/WebMobile
+${OE_QMAKE_QMAKE} WebMobile.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Apps
+mkdir ${D}/usr/local/MokoTouch/Apps/WebMobile.app
+cp ${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0 ${D}/usr/local/MokoTouch/Apps/WebMobile.app/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Apps/WebMobile.app/libWebMobile.so.1.0.0"
+
+PACKAGES = "${PN}"
+
+pkg_postinst(){
+#!/bin/sh
+ln -sf /usr/local/MokoTouch/Apps/WebMobile.app/libWebMobile.so.1.0.0 /usr/lib/libWebMobile.so.1.0.0
+ln -sf /usr/local/MokoTouch/Apps/WebMobile.app/libWebMobile.so.1.0.0 /usr/lib/libWebMobile.so.1.0
+ln -sf /usr/local/MokoTouch/Apps/WebMobile.app/libWebMobile.so.1.0.0 /usr/lib/libWebMobile.so.1
+ln -sf /usr/local/MokoTouch/Apps/WebMobile.app/libWebMobile.so.1.0.0 /usr/lib/libWebMobile.so
+}
diff --git a/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
new file mode 100644
index 0000000..8594cc2
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
@@ -0,0 +1,34 @@
+require mokotouch.inc
+
+DEPENDS += "mokotouch-frameworks-uikit"
+RDEPENDS += "mokotouch-frameworks-uikit"
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/CoreServices/MokoTouch
+${OE_QMAKE_QMAKE} MokoTouch.pro
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/bin/
+
+cp qte.env ${D}/usr/local/MokoTouch/
+cp ${S}/MokoTouch/CoreServices/MokoTouch/BUILD/Service/MokoTouch ${D}/usr/local/MokoTouch/bin/
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/qte.env /usr/local/MokoTouch/bin/MokoTouch"
+
+PACKAGES = "${PN}"
diff --git a/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
new file mode 100644
index 0000000..787c26e
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
@@ -0,0 +1,41 @@
+require mokotouch.inc
+
+PV = "2"
+PR = "r1"
+
+do_configure(){
+echo "Do nothing"
+}
+
+do_compile(){
+echo "Using qmake in location: ${OE_QMAKE_QMAKE}"
+cd ${S}/MokoTouch/Frameworks/UIKit/
+${OE_QMAKE_QMAKE} UIKit.pro
+make
+}
+
+do_install(){
+mkdir ${D}/usr
+mkdir ${D}/usr/local
+mkdir ${D}/usr/local/MokoTouch
+mkdir ${D}/usr/local/MokoTouch/Frameworks
+cp -R "${S}/MokoTouch/Frameworks/UIKit/UIKit" "${D}/usr/local/MokoTouch/Frameworks/"
+cp "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/usr/local/MokoTouch/Frameworks/"
+}
+
+do_stage() {
+cp "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" ${STAGING_LIBDIR}
+ln -fs ${STAGING_LIBDIR}/libUIKit.so.1.0.0 ${STAGING_LIBDIR}/libUIKit.so.1.0
+ln -fs ${STAGING_LIBDIR}/libUIKit.so.1.0.0 ${STAGING_LIBDIR}/libUIKit.so.1
+ln -fs ${STAGING_LIBDIR}/libUIKit.so.1.0.0 ${STAGING_LIBDIR}/libUIKit.so
+}
+
+pkg_postinst_${PN}(){
+#!/bin/sh
+ln -fs /usr/local/MokoTouch/Frameworks/UIKit.framework/libUIKit.so.1.0.0 /usr/lib/libUIKit.so.1.0.0 
+ln -fs /usr/local/MokoTouch/Frameworks/UIKit.framework/libUIKit.so.1.0.0 /usr/lib/libUIKit.so.1.0 
+ln -fs /usr/local/MokoTouch/Frameworks/UIKit.framework/libUIKit.so.1.0.0 /usr/lib/libUIKit.so.1
+ln -fs /usr/local/MokoTouch/Frameworks/UIKit.framework/libUIKit.so.1.0.0 /usr/lib/libUIKit.so
+}
+
+FILES_${PN} = "/usr/local/MokoTouch/Frameworks/libUIKit.so.1.0.0 /usr/local/MokoTouch/Frameworks/UIKit/*"
diff --git a/recipes/mokotouch/mokotouch.inc b/recipes/mokotouch/mokotouch.inc
new file mode 100644
index 0000000..cfc13e0
--- /dev/null
+++ b/recipes/mokotouch/mokotouch.inc
@@ -0,0 +1,18 @@
+DESCRIPTION = "MokoTouch a finger friendly QT4-based iphone like GUI for OpenMoko"
+HOMEPAGE = "http://th30z.netsons.org/mokotouch/"
+SECTION = "openmoko/applications"
+LICENSE = "GPL"
+DEPENDS = "gstreamer qt4-x11-free"
+RDEPENDS = "gstreamer qt4-x11-free"
+
+PV = "2"
+PR = "r1"
+
+SRC_URI = "http://th30z.netsons.org/mokotouch/data/mokotouch-2-aug-2009.tar.bz2"
+
+S = "${WORKDIR}/MokoTouch-Project"
+D = "${WORKDIR}/image"
+
+EXTRA_QMAKEVARS_POST += "INCLUDEPATH+=${OE_QMAKE_INCDIR_QT}/Qt"
+
+inherit autotools qt4x11 distutils-base pkgconfig lib_package

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-10-26 20:25 [PATCH] MokoTouch David Lanzendörfer
@ 2009-10-26 20:43 ` Marcin Juszkiewicz
  2009-10-26 20:55   ` Koen Kooi
  2009-11-05 20:01 ` Michael 'Mickey' Lauer
  1 sibling, 1 reply; 7+ messages in thread
From: Marcin Juszkiewicz @ 2009-10-26 20:43 UTC (permalink / raw)
  To: openembedded-devel

Dnia poniedziałek, 26 października 2009 o 21:25:48 David Lanzendörfer 
napisał(a):
> I'd like to have mokotouch-recipes added to OE.
 
1. use "install -d" instead of "mkdir"
2. use "install" instead of "cp"
3. learn about DEPENDS and RDEPENDS and fix use of them
4. use "oe_runmake" instead of "make"
5. do not set PACKAGES
6. build to ${prefix} not /usr/local/
7. get rid of ugly symlinking of libraries
8. move common stuff to mokotouch.inc
9. consider changing a way of building mokotouch-* to do all from one recipe

Now I reject thinking about pushing that into repository.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-10-26 20:43 ` Marcin Juszkiewicz
@ 2009-10-26 20:55   ` Koen Kooi
  0 siblings, 0 replies; 7+ messages in thread
From: Koen Kooi @ 2009-10-26 20:55 UTC (permalink / raw)
  To: openembedded-devel

On 26-10-09 21:43, Marcin Juszkiewicz wrote:
> Dnia poniedziałek, 26 października 2009 o 21:25:48 David Lanzendörfer
> napisał(a):
>> I'd like to have mokotouch-recipes added to OE.
>
> 1. use "install -d" instead of "mkdir"
> 2. use "install" instead of "cp"
> 3. learn about DEPENDS and RDEPENDS and fix use of them
> 4. use "oe_runmake" instead of "make"
> 5. do not set PACKAGES
> 6. build to ${prefix} not /usr/local/
> 7. get rid of ugly symlinking of libraries
> 8. move common stuff to mokotouch.inc
> 9. consider changing a way of building mokotouch-* to do all from one recipe

10. learn about qmake bbclasses

regards,

Koen




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-10-26 20:25 [PATCH] MokoTouch David Lanzendörfer
  2009-10-26 20:43 ` Marcin Juszkiewicz
@ 2009-11-05 20:01 ` Michael 'Mickey' Lauer
  2009-11-05 22:16   ` David Lanzendörfer
  1 sibling, 1 reply; 7+ messages in thread
From: Michael 'Mickey' Lauer @ 2009-11-05 20:01 UTC (permalink / raw)
  To: openembedded-devel

Dear David,

let me encourage you to submit an updated patchset that takes into
account the reviewer's comments.

Cheers,

:M:





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-11-05 20:01 ` Michael 'Mickey' Lauer
@ 2009-11-05 22:16   ` David Lanzendörfer
  2009-11-05 22:22     ` Marcin Juszkiewicz
  0 siblings, 1 reply; 7+ messages in thread
From: David Lanzendörfer @ 2009-11-05 22:16 UTC (permalink / raw)
  To: mickey, openembedded-devel


[-- Attachment #1.1: Type: Text/Plain, Size: 322 bytes --]

> Dear David,
Hi Mickey

> let me encourage you to submit an updated patchset that takes into
> account the reviewer's comments.
Here is the corrected patch, which will bring the bitbake recipes for 
MokoTouch into OE.
I hope this will be somehow usefull for some of you.

> Cheers,
dito :)

> :M:
leviathan

[-- Attachment #1.2: add-mokotouch.patch --]
[-- Type: text/x-patch, Size: 9852 bytes --]

commit dff8d20ceb4c304ba3140deefb80310ee92219b1
Author: David Lanzendörfer <david.lanzendoerfer@o2s.ch>
Date:   Thu Nov 5 23:11:19 2009 +0100

    Added MokoTouch recipes (http://th30z.netsons.org/mokotouch/)

diff --git a/recipes/mokotouch/mokotouch-apps-customtableview_2.bb b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
new file mode 100644
index 0000000..da9ff61
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-customtableview_2.bb
@@ -0,0 +1,24 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/CustomTableView
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} CustomTableView.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/CustomTableView
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1.0.0"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1.0"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so.1"
+install "${S}/MokoTouch/Apps/CustomTableView/BUILD/App/libCustomTableView.so.1.0.0" "${D}/${libdir}/libCustomTableView.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-helloworld_2.bb b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
new file mode 100644
index 0000000..0d42682
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
@@ -0,0 +1,24 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/HelloWorld
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} HelloWorld.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/HelloWorld
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1.0.0"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1.0"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so.1"
+install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0" "${D}/${libdir}/libHelloWorld.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-homescreen_2.bb b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
new file mode 100644
index 0000000..b58f278
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-homescreen_2.bb
@@ -0,0 +1,23 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/Homescreen
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} Homescreen.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/Homescreen
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1.0.0"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1.0"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so.1"
+install "${S}/MokoTouch/Apps/Homescreen/BUILD/App/libHomescreen.so.1.0.0" "${D}/${libdir}/libHomescreen.so"
+}
diff --git a/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
new file mode 100644
index 0000000..6b6fb25
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testkeyboard_2.bb
@@ -0,0 +1,24 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/TestKeyboard
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} TestKeyboard.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/TestKeyboard
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1.0.0"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1.0"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so.1"
+install "${S}/MokoTouch/Apps/TestKeyboard/BUILD/App/libTestKeyboard.so.1.0.0" "${D}/${libdir}/libTestKeyboard.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-testtableview_2.bb b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
new file mode 100644
index 0000000..247b051
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-testtableview_2.bb
@@ -0,0 +1,24 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/TestTableView
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} TestTableView.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/TestTableView
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1.0.0"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1.0"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so.1"
+install "${S}/MokoTouch/Apps/TestTableView/BUILD/App/libTestTableView.so.1.0.0" "${D}/${libdir}/libTestTableView.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-apps-webmobile_2.bb b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
new file mode 100644
index 0000000..ec1b8f2
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-apps-webmobile_2.bb
@@ -0,0 +1,24 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-coreservices-mokotouch"
+
+do_configure(){
+cd ${S}/MokoTouch/Apps/WebMobile
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} WebMobile.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Apps/WebMobile
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1.0.0"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1.0"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so.1"
+install "${S}/MokoTouch/Apps/WebMobile/BUILD/App/libWebMobile.so.1.0.0" "${D}/${libdir}/libWebMobile.so"
+}
+
diff --git a/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
new file mode 100644
index 0000000..4796d25
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-coreservices-mokotouch_2.bb
@@ -0,0 +1,25 @@
+require mokotouch.inc
+
+DEPENDS = "mokotouch-frameworks-uikit"
+
+do_configure(){
+cd ${S}/MokoTouch/CoreServices/MokoTouch
+rm UIKit.framework
+ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
+${OE_QMAKE_QMAKE} MokoTouch.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/CoreServices/MokoTouch
+oe_runmake
+}
+
+do_install(){
+install -d ${D}/${sysconfdir}
+install -d ${D}/${bindir}
+
+install qte.env ${D}/${sysconfdir}/mokotouch.env
+install "${S}/MokoTouch/CoreServices/MokoTouch/BUILD/Service/MokoTouch" "${D}/${bindir}/MokoTouch"
+}
+
+FILES_${PN} = "${bindir}/MokoTouch ${sysconfdir}/mokotouch.env"
diff --git a/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
new file mode 100644
index 0000000..cbb3908
--- /dev/null
+++ b/recipes/mokotouch/mokotouch-frameworks-uikit_2.bb
@@ -0,0 +1,26 @@
+require mokotouch.inc
+
+do_configure(){
+cd ${S}/MokoTouch/Frameworks/UIKit/
+${OE_QMAKE_QMAKE} UIKit.pro
+}
+
+do_compile(){
+cd ${S}/MokoTouch/Frameworks/UIKit/
+oe_runmake
+}
+
+do_install(){
+install -d "${D}/${libdir}"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1.0.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so.1"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${D}/${libdir}/libUIKit.so"
+}
+
+do_stage() {
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1.0.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1.0"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so.1"
+install "${S}/MokoTouch/Frameworks/UIKit/BUILD/libs/libUIKit.so.1.0.0" "${STAGING_LIBDIR}/libUIKit.so"
+}
diff --git a/recipes/mokotouch/mokotouch.inc b/recipes/mokotouch/mokotouch.inc
new file mode 100644
index 0000000..95cb176
--- /dev/null
+++ b/recipes/mokotouch/mokotouch.inc
@@ -0,0 +1,16 @@
+DESCRIPTION = "MokoTouch a finger friendly QT4-based iphone like GUI for OpenMoko"
+HOMEPAGE = "http://th30z.netsons.org/mokotouch/"
+SECTION = "openmoko/applications"
+LICENSE = "GPL"
+DEPENDS = "gstreamer qt4-x11-free"
+
+PR = "r1"
+
+SRC_URI = "http://th30z.netsons.org/mokotouch/data/mokotouch-2-aug-2009.tar.bz2"
+
+S = "${WORKDIR}/MokoTouch-Project"
+D = "${WORKDIR}/image"
+
+EXTRA_QMAKEVARS_POST += "INCLUDEPATH+=${OE_QMAKE_INCDIR_QT}/Qt"
+
+inherit autotools qt4x11 distutils-base pkgconfig lib_package

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-11-05 22:16   ` David Lanzendörfer
@ 2009-11-05 22:22     ` Marcin Juszkiewicz
  2010-04-08  9:35       ` Stefan Schmidt
  0 siblings, 1 reply; 7+ messages in thread
From: Marcin Juszkiewicz @ 2009-11-05 22:22 UTC (permalink / raw)
  To: openembedded-devel

Dnia czwartek, 5 listopada 2009 o 23:16:19 David Lanzendörfer napisał(a):

> +++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
> @@ -0,0 +1,24 @@
> +require mokotouch.inc
> +
> +DEPENDS = "mokotouch-coreservices-mokotouch"
> +
> +do_configure(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +rm UIKit.framework
> +ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
> +${OE_QMAKE_QMAKE} HelloWorld.pro
> +}
> +
> +do_compile(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +oe_runmake
> +}
> +
> +do_install(){
> +install -d "${D}/${libdir}"
> +install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so" +}

My version of that recipe:

=============================
require mokotouch.inc

MTCOMPONENT = "HelloWorld"
=============================

Rest of code should be in mokotouch.inc as you only change component name in 
all recipes. Each and each repeats same errors:

- no setting of ${S} but use of "cd somewhere to make it build"
- big duplication of code
- no use of qmake* bbclasses which remove need of do_configure/do_compile in
  your recipes
- again waste of space by strange installation of libraries (fix loader to use
  *.so maybe and skip all *.so.1.0.0 stuff?)

Still nack from me.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz





^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MokoTouch
  2009-11-05 22:22     ` Marcin Juszkiewicz
@ 2010-04-08  9:35       ` Stefan Schmidt
  0 siblings, 0 replies; 7+ messages in thread
From: Stefan Schmidt @ 2010-04-08  9:35 UTC (permalink / raw)
  To: openembedded-devel

Hello.

On Thu, 2009-11-05 at 23:22, Marcin Juszkiewicz wrote:
> 
> My version of that recipe:
> 
> =============================
> require mokotouch.inc
> 
> MTCOMPONENT = "HelloWorld"
> =============================
> 
> Rest of code should be in mokotouch.inc as you only change component name in 
> all recipes. Each and each repeats same errors:
> 
> - no setting of ${S} but use of "cd somewhere to make it build"
> - big duplication of code
> - no use of qmake* bbclasses which remove need of do_configure/do_compile in
>   your recipes
> - again waste of space by strange installation of libraries (fix loader to use
>   *.so maybe and skip all *.so.1.0.0 stuff?)
> 
> Still nack from me.

I agree. David, would you make the changes Marcin pointed out?

regards
Stefan Schmidt



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2010-04-08  9:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-26 20:25 [PATCH] MokoTouch David Lanzendörfer
2009-10-26 20:43 ` Marcin Juszkiewicz
2009-10-26 20:55   ` Koen Kooi
2009-11-05 20:01 ` Michael 'Mickey' Lauer
2009-11-05 22:16   ` David Lanzendörfer
2009-11-05 22:22     ` Marcin Juszkiewicz
2010-04-08  9:35       ` Stefan Schmidt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.