All of lore.kernel.org
 help / color / mirror / Atom feed
* package VDR for OE
@ 2009-12-12 11:48 Paul Menzel
  2009-12-12 17:33 ` Henning Heinold
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2009-12-12 11:48 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 2168 bytes --]

Dear OE hackers,


I am trying to write a recipe for The Video Disc Recorder (VDR) [1] and
get it into OE.

Unfortunately I have never done this and I also do not know much about
things related to compiling.

I tried to follow [2] and [3] and came up with the following which is
not much as you can see and in addition does not work yet.

The problem I am facing is, that in the Makefile of VDR [4] there is

        […]
        LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype
        -lfontconfig
        INCLUDES = -I/usr/include/freetype
        […]

so that the path `/usr/include/freetype/` is passed to the make command
which of course fails trying to cross compile the program.

        CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include/freetype2
        cc1plus: internal compiler error: in add_path, at c-incpath.c:425

Now, if I understand it correctly by looking at other recipes there is
EXTRA_OEMAKE = "" where I should be able to set the INCLUDEPATH to the
OE build environment. Is that correct.

Could you please also tell me what the recipe variable name is for libs?


Thank you,

Paul


[1] http://www.tvdr.de
[2] http://wiki.openmoko.org/wiki/BitBake_recipe
[3] http://docs.openembedded.org/usermanual/html/recipes_directories.html
[4] http://git.gekrumbel.de/vdr.git?p=vdr.git;a=blob;f=Makefile;h=703b801f623d16d9f3e872716a2646d908f35273;hb=ea01358b3bca9d55402ba632c95cdd6458abfdb3


diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@ sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b77834321
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+
 [ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e

[-- Attachment #1.2: vdr_1.7.10.bb --]
[-- Type: text/plain, Size: 511 bytes --]

DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver program using Linux and DVB technologies. It allows one to record MPEG2 streams, as well as output the stream to TV. It is also possible to watch DVDs (hardware accelerated) with some comfort and use an IR remote control."
AUTHOR = "Klaus Schmidinger"
LICENSE = "GPLv2"
HOMEPAGE = "http://www.tvdr.de"

DEPENDS = "fontconfig freetype gettext libcap jpeg"

SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2"


EXTRA_OEMAKE = ""

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-12 11:48 package VDR for OE Paul Menzel
@ 2009-12-12 17:33 ` Henning Heinold
  2009-12-13 13:46   ` Paul Menzel
  0 siblings, 1 reply; 16+ messages in thread
From: Henning Heinold @ 2009-12-12 17:33 UTC (permalink / raw)
  To: openembedded-devel

On Sat, Dec 12, 2009 at 12:48:40PM +0100, Paul Menzel wrote:
> Dear OE hackers,
> 
> 
> I am trying to write a recipe for The Video Disc Recorder (VDR) [1] and
> get it into OE.
> 
> Unfortunately I have never done this and I also do not know much about
> things related to compiling.
> 
> I tried to follow [2] and [3] and came up with the following which is
> not much as you can see and in addition does not work yet.
> 
> The problem I am facing is, that in the Makefile of VDR [4] there is
> 
>         […]
>         LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype
>         -lfontconfig
>         INCLUDES = -I/usr/include/freetype
>         […]
> 
> so that the path `/usr/include/freetype/` is passed to the make command
> which of course fails trying to cross compile the program.
> 
>         CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include/freetype2
>         cc1plus: internal compiler error: in add_path, at c-incpath.c:425
> 
> Now, if I understand it correctly by looking at other recipes there is
> EXTRA_OEMAKE = "" where I should be able to set the INCLUDEPATH to the
> OE build environment. Is that correct.
> 
> Could you please also tell me what the recipe variable name is for libs?
> 
> 
> Thank you,
> 
> Paul

What buildsystem is vdr using autotools or handmade Makefiles?

for autotools just do
inherit autotools

for handmade Makefiles

make a Patch which patches the Makefile and sets the include path to our staginginclude-Path

Bye Henning



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-12 17:33 ` Henning Heinold
@ 2009-12-13 13:46   ` Paul Menzel
  2009-12-13 14:18     ` Petr Štetiar
  2009-12-13 16:34     ` package VDR for OE Koen Kooi
  0 siblings, 2 replies; 16+ messages in thread
From: Paul Menzel @ 2009-12-13 13:46 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 4724 bytes --]

Am Samstag, den 12.12.2009, 18:33 +0100 schrieb Henning Heinold:
> On Sat, Dec 12, 2009 at 12:48:40PM +0100, Paul Menzel wrote:
> > I am trying to write a recipe for The Video Disc Recorder (VDR) [1] and
> > get it into OE.
> > 
> > Unfortunately I have never done this and I also do not know much about
> > things related to compiling.
> > 
> > I tried to follow [2] and [3] and came up with the following which is
> > not much as you can see and in addition does not work yet.
> > 
> > The problem I am facing is, that in the Makefile of VDR [4] there is
> > 
> >         […]
> >         LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype
> >         -lfontconfig
> >         INCLUDES = -I/usr/include/freetype
> >         […]
> > 
> > so that the path `/usr/include/freetype/` is passed to the make command
> > which of course fails trying to cross compile the program.
> > 
> >         CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include/freetype2
> >         cc1plus: internal compiler error: in add_path, at c-incpath.c:425
> > 
> > Now, if I understand it correctly by looking at other recipes there is
> > EXTRA_OEMAKE = "" where I should be able to set the INCLUDEPATH to the
> > OE build environment. Is that correct.
> > 
> > Could you please also tell me what the recipe variable name is for libs?
>
> What buildsystem is vdr using autotools or handmade Makefiles?

VDR uses a handmade Makefile.

[…]

> for handmade Makefiles
> 
> make a Patch which patches the Makefile and sets the include path to
> our staginginclude-Path

Thank you! I tried this

        +-INCLUDES = -I/usr/include/freetype2
        ++INCLUDES = -I${STAGING_INCDIR}/freetype2

but the `${STAGING_INCDIR}` was not expanded. The result is the
following.

        INCLUDES = -I${STAGING_INCDIR}freetype2

Using an absolute path worked.

Could you please point out my mistake?

Furthermore is there a better way for upstream to set things up so that
no patching is needed? Or is autotools needed for this?

What else do I need to do to get VDR accepted into OE?


Thanks,

Paul

--

The upstream Makefile needs to be patched to use the headers from the staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |    9 +++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@ sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+
 [ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..f41bd26
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = -I/srv/oe/angstrom-dev/staging/armv7a-angstrom-linux-gnueabi/usr/include/freetype2
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..662c883
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,9 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver program using Linux and DVB technologies. It allows one to record MPEG2 streams, as well as output the stream to TV. It is also possible to watch DVDs (hardware accelerated) with some comfort and use an IR remote control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
-- 
1.6.5.4

[-- Attachment #1.2: 0001-Package-VDR.patch --]
[-- Type: text/x-patch, Size: 2779 bytes --]

From e683a269ba07faaaee916e1c2b7d70b61d39b3c1 Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sat, 12 Dec 2009 10:17:52 +0100
Subject: [PATCH 1/1] Package VDR.

The upstream Makefile needs to be patched to use the headers from the staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |    9 +++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@ sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+
 [ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..f41bd26
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = -I/srv/filme/oe/angstrom-dev/staging/armv7a-angstrom-linux-gnueabi/usr/include/freetype2
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..662c883
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,9 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver program using Linux and DVB technologies. It allows one to record MPEG2 streams, as well as output the stream to TV. It is also possible to watch DVDs (hardware accelerated) with some comfort and use an IR remote control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
-- 
1.6.5.4


[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 13:46   ` Paul Menzel
@ 2009-12-13 14:18     ` Petr Štetiar
  2009-12-13 15:45       ` Paul Menzel
  2009-12-13 16:34     ` package VDR for OE Koen Kooi
  1 sibling, 1 reply; 16+ messages in thread
From: Petr Štetiar @ 2009-12-13 14:18 UTC (permalink / raw)
  To: openembedded-devel

Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:

> Thank you! I tried this
> 
>         +-INCLUDES = -I/usr/include/freetype2
>         ++INCLUDES = -I${STAGING_INCDIR}/freetype2
> 
> but the `${STAGING_INCDIR}` was not expanded. The result is the
> following.
> 
>         INCLUDES = -I${STAGING_INCDIR}freetype2
> 
> Using an absolute path worked.
> 
> Could you please point out my mistake?

Maybe, it's because you don't have STAGING_INCDIR variable available in
do_compile() step. If I were you, I would grep for STAGING_INCDIR variable in
other recipes: grep -R STAGING_INCDIR recipes/* and you should get idea how to
use it. Hint, change :

INCLUDES = -I${STAGING_INCDIR}freetype2

to 

INCLUDES = ${CFLAGS}

and in your recipe do:

CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"

> Furthermore is there a better way for upstream to set things up so that
> no patching is needed? Or is autotools needed for this?

No for this hardcoded paths.

> +--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
> ++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
> +@@ -21,7 +21,7 @@
> + BINDIR   = $(PREFIX)/bin
> + LOCDIR   = ./locale
> + LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
> +-INCLUDES = -I/usr/include/freetype2
> ++INCLUDES = -I/srv/oe/angstrom-dev/staging/armv7a-angstrom-linux-gnueabi/usr/include/freetype2

Maybe you've overlooked that, but it's unacceptable hardcoded path...

-- ynezz



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 14:18     ` Petr Štetiar
@ 2009-12-13 15:45       ` Paul Menzel
  2009-12-14 19:13         ` Paul Menzel
                           ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Paul Menzel @ 2009-12-13 15:45 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 4317 bytes --]

Am Sonntag, den 13.12.2009, 15:18 +0100 schrieb Petr Štetiar:
> Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:

[…]

> Maybe, it's because you don't have STAGING_INCDIR variable available in
> do_compile() step. If I were you, I would grep for STAGING_INCDIR variable in
> other recipes: grep -R STAGING_INCDIR recipes/* and you should get idea how to
> use it. Hint, change :
> 
> INCLUDES = -I${STAGING_INCDIR}freetype2
> 
> to 
> 
> INCLUDES = ${CFLAGS}
> 
> and in your recipe do:
> 
> CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"

Great. That worked.

> > Furthermore is there a better way for upstream to set things up so that
> > no patching is needed? Or is autotools needed for this?

I am still asking if upstream could change something to make the
Makefile cross compilable by default.

> No for this hardcoded paths.
> 
> > +--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
> > ++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
> > +@@ -21,7 +21,7 @@
> > + BINDIR   = $(PREFIX)/bin
> > + LOCDIR   = ./locale
> > + LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
> > +-INCLUDES = -I/usr/include/freetype2
> > ++INCLUDES = -I/srv/oe/angstrom-dev/staging/armv7a-angstrom-linux-gnueabi/usr/include/freetype2
> 
> Maybe you've overlooked that, but it's unacceptable hardcoded path...

Of course I put this in, because I did not get `${STAGING_INCDIR}` to
expand. I changed it now thanks to your help.


Thank you,

Paul


--
From bb3ddb5df2b506f67ebcc9f1ed9f09d80c16e1bf Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sat, 12 Dec 2009 10:17:52 +0100
Subject: [PATCH 1/1] Package VDR.

The upstream Makefile needs to be patched to use the headers from the
staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |   11 +++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@
sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+

[ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch
b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..418f2d9
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = ${CFLAGS}
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..d9bcfb4
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,11 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver
program using Linux and DVB technologies. It allows one to record MPEG2
streams, as well as output the stream to TV. It is also possible to
watch DVDs (hardware accelerated) with some comfort and use an IR remote
control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
+
+CFLAGS_append += " -I${STAGING_INCDIR}/freetype2"
-- 
1.6.5.4

[-- Attachment #1.2: 0001-Package-VDR.patch --]
[-- Type: text/x-patch, Size: 2758 bytes --]

From bb3ddb5df2b506f67ebcc9f1ed9f09d80c16e1bf Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sat, 12 Dec 2009 10:17:52 +0100
Subject: [PATCH 1/1] Package VDR.

The upstream Makefile needs to be patched to use the headers from the staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |   11 +++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@ sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+
 [ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..418f2d9
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = ${CFLAGS}
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..d9bcfb4
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,11 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver program using Linux and DVB technologies. It allows one to record MPEG2 streams, as well as output the stream to TV. It is also possible to watch DVDs (hardware accelerated) with some comfort and use an IR remote control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
+
+CFLAGS_append += " -I${STAGING_INCDIR}/freetype2"
-- 
1.6.5.4


[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 13:46   ` Paul Menzel
  2009-12-13 14:18     ` Petr Štetiar
@ 2009-12-13 16:34     ` Koen Kooi
  2009-12-13 18:05       ` Paul Menzel
  1 sibling, 1 reply; 16+ messages in thread
From: Koen Kooi @ 2009-12-13 16:34 UTC (permalink / raw)
  To: openembedded-devel

On 13-12-09 14:46, Paul Menzel wrote:
> Am Samstag, den 12.12.2009, 18:33 +0100 schrieb Henning Heinold:
>> On Sat, Dec 12, 2009 at 12:48:40PM +0100, Paul Menzel wrote:
>>> I am trying to write a recipe for The Video Disc Recorder (VDR) [1] and
>>> get it into OE.
>>>
>>> Unfortunately I have never done this and I also do not know much about
>>> things related to compiling.
>>>
>>> I tried to follow [2] and [3] and came up with the following which is
>>> not much as you can see and in addition does not work yet.
>>>
>>> The problem I am facing is, that in the Makefile of VDR [4] there is
>>>
>>>          […]
>>>          LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype
>>>          -lfontconfig
>>>          INCLUDES = -I/usr/include/freetype
>>>          […]
>>>
>>> so that the path `/usr/include/freetype/` is passed to the make command
>>> which of course fails trying to cross compile the program.
>>>
>>>          CROSS COMPILE Badness: /usr/include in INCLUDEPATH: /usr/include/freetype2
>>>          cc1plus: internal compiler error: in add_path, at c-incpath.c:425
>>>
>>> Now, if I understand it correctly by looking at other recipes there is
>>> EXTRA_OEMAKE = "" where I should be able to set the INCLUDEPATH to the
>>> OE build environment. Is that correct.
>>>
>>> Could you please also tell me what the recipe variable name is for libs?
>>
>> What buildsystem is vdr using autotools or handmade Makefiles?
>
> VDR uses a handmade Makefile.
>
> […]
>
>> for handmade Makefiles
>>
>> make a Patch which patches the Makefile and sets the include path to
>> our staginginclude-Path
>
> Thank you! I tried this
>
>          +-INCLUDES = -I/usr/include/freetype2
>          ++INCLUDES = -I${STAGING_INCDIR}/freetype2
>
> but the `${STAGING_INCDIR}` was not expanded. The result is the
> following.
>
>          INCLUDES = -I${STAGING_INCDIR}freetype2
>
> Using an absolute path worked.
>
> Could you please point out my mistake?

AFAIK Makefiles don't use accolades but parens for variables.

regards,

Koen




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 16:34     ` package VDR for OE Koen Kooi
@ 2009-12-13 18:05       ` Paul Menzel
  2009-12-13 18:32         ` Petr Štetiar
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2009-12-13 18:05 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

Am Sonntag, den 13.12.2009, 17:34 +0100 schrieb Koen Kooi:
> On 13-12-09 14:46, Paul Menzel wrote:

[…]

> > Thank you! I tried this
> >
> >          +-INCLUDES = -I/usr/include/freetype2
> >          ++INCLUDES = -I${STAGING_INCDIR}/freetype2
> >
> > but the `${STAGING_INCDIR}` was not expanded. The result is the
> > following.
> >
> >          INCLUDES = -I${STAGING_INCDIR}freetype2
> >
> > Using an absolute path worked.
> >
> > Could you please point out my mistake?
> 
> AFAIK Makefiles don't use accolades but parens for variables.

I see. But

        -INCLUDES = -I/usr/include/freetype2
        +INCLUDES = $(STAGING_INCDIR)/freetype2

did not help and resulted in.

        INCLUDES = $(STAGING_INCDIR)/freetype2

So I guess Petr’s solution is the way to go.


Thanks,

Paul

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 18:05       ` Paul Menzel
@ 2009-12-13 18:32         ` Petr Štetiar
  0 siblings, 0 replies; 16+ messages in thread
From: Petr Štetiar @ 2009-12-13 18:32 UTC (permalink / raw)
  To: openembedded-devel

Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 19:05:15]:

> > AFAIK Makefiles don't use accolades but parens for variables.
> 
> I see. But
> 
>         -INCLUDES = -I/usr/include/freetype2
>         +INCLUDES = $(STAGING_INCDIR)/freetype2
> 
> did not help and resulted in.
> 
>         INCLUDES = $(STAGING_INCDIR)/freetype2

No, I think, that Koen was writing about your general mistake. If there was
STAGING_INCDIR available in the environment, your ${} won't work anyway.
Correct is to use $(), parens in Makefile when accessing variables. It's
nothing about your issue.

-- ynezz



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-13 15:45       ` Paul Menzel
@ 2009-12-14 19:13         ` Paul Menzel
  2009-12-14 20:10           ` Henning Heinold
  2010-01-10 12:40         ` environment variables in Makefile for cross compilation (was: package VDR for OE) Paul Menzel
  2010-01-19  0:22         ` Setting environment variables in recipes and fixing upstream the right way to cross compile? " Paul Menzel
  2 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2009-12-14 19:13 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

Am Sonntag, den 13.12.2009, 16:45 +0100 schrieb Paul Menzel:
> Am Sonntag, den 13.12.2009, 15:18 +0100 schrieb Petr Štetiar:
> > Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:

[…]

> > > Furthermore is there a better way for upstream to set things up so that
> > > no patching is needed? Or is autotools needed for this?
> 
> I am still asking if upstream could change something to make the
> Makefile cross compilable by default.

[…]

Could someone advise me on how to get VDR included officially into OE?
Had someone time already to test the recipe?

Something does not seem right yet. 

        […]
        NOTE: Running task 810 of 831 (ID: 230, /srv/oe/openembedded/recipes/vdr/vdr_1.7.10.bb, do_package)
        cp: cannot stat `/srv/oe/angstrom-dev/work/armv7a-angstrom-linux-gnueabi/vdr-1.7.10-r0/image/*': No such file or directory
        NOTE: Running task 811 of 831 (ID: 235, /srv/oe/openembedded/recipes/vdr/vdr_1.7.10.bb, do_package_write_ipk)
        NOTE: Running task 812 of 831 (ID: 228, /srv/oe/openembedded/recipes/vdr/vdr_1.7.10.bb, do_qa_staging)
        NOTE: Running task 813 of 831 (ID: 6, /srv/oe/openembedded/recipes/softdevice/vdr-softdevice_0.5.0.bb, do_configure)
        Packaged contents of vdr-dbg into /srv/oe/angstrom-dev/deploy/glibc/ipk/armv7a/vdr-dbg_1.7.10-r0.5_armv7a.ipk
        NOTE: Not creating empty archive for vdr-1.7.10-r0.5
        NOTE: Not creating empty archive for vdr-doc-1.7.10-r0.5
        […]

I cannot find `vdr-1.7.10-r0.5_armv7a.ipk` which is probably related to
the above information. I find it strange because there are no other
errors beforehand. Could someone point out the error to me?


Thanks,

Paul

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-14 19:13         ` Paul Menzel
@ 2009-12-14 20:10           ` Henning Heinold
  2009-12-14 20:28             ` Paul Menzel
  0 siblings, 1 reply; 16+ messages in thread
From: Henning Heinold @ 2009-12-14 20:10 UTC (permalink / raw)
  To: openembedded-devel

On Mon, Dec 14, 2009 at 08:13:32PM +0100, Paul Menzel wrote:
> Could someone advise me on how to get VDR included officially into OE?
> Had someone time already to test the recipe?
> 


Please submit your recipe here with git format-patch. I will look into it.

Bye Henning



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-14 20:10           ` Henning Heinold
@ 2009-12-14 20:28             ` Paul Menzel
  2010-01-03 14:15               ` Paul Menzel
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2009-12-14 20:28 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Am Montag, den 14.12.2009, 21:10 +0100 schrieb Henning Heinold:
> On Mon, Dec 14, 2009 at 08:13:32PM +0100, Paul Menzel wrote:
> > Could someone advise me on how to get VDR included officially into OE?
> > Had someone time already to test the recipe?
> 
> Please submit your recipe here with git format-patch. I will look into it.

Thank you. I sent it already on yesterday 16:45 CET [1]. If you do not
have it in your mailbox I can sent the attachment again.


Thanks,

Paul


[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2009-December/015599.html

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: package VDR for OE
  2009-12-14 20:28             ` Paul Menzel
@ 2010-01-03 14:15               ` Paul Menzel
  2010-01-04 21:37                 ` [done] " Paul Menzel
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2010-01-03 14:15 UTC (permalink / raw)
  To: openembedded-devel


[-- Attachment #1.1: Type: text/plain, Size: 3588 bytes --]

Am Montag, den 14.12.2009, 21:28 +0100 schrieb Paul Menzel:
> Am Montag, den 14.12.2009, 21:10 +0100 schrieb Henning Heinold:
> > On Mon, Dec 14, 2009 at 08:13:32PM +0100, Paul Menzel wrote:
> > > Could someone advise me on how to get VDR included officially into OE?
> > > Had someone time already to test the recipe?
> > 
> > Please submit your recipe here with git format-patch. I will look into it.
> 
> Thank you. I sent it already on yesterday 16:45 CET [1]. If you do not
> have it in your mailbox I can sent the attachment again.

Sorry to bother you again. I guess you had and have a lot of other
business to take care of.

I paste the patch into this message and also attach it.


Thanks,

Paul


> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2009-December/015599.html

--
From bb3ddb5df2b506f67ebcc9f1ed9f09d80c16e1bf Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sat, 12 Dec 2009 10:17:52 +0100
Subject: [PATCH 1/1] Package VDR.

The upstream Makefile needs to be patched to use the headers from the
staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |   11 +++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@
sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+

[ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch
b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..418f2d9
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = ${CFLAGS}
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..d9bcfb4
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,11 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver
program using Linux and DVB technologies. It allows one to record MPEG2
streams, as well as output the stream to TV. It is also possible to
watch DVDs (hardware accelerated) with some comfort and use an IR remote
control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
+
+CFLAGS_append += " -I${STAGING_INCDIR}/freetype2"
-- 
1.6.5.4

[-- Attachment #1.2: 0001-Package-VDR.patch --]
[-- Type: text/x-patch, Size: 2758 bytes --]

From bb3ddb5df2b506f67ebcc9f1ed9f09d80c16e1bf Mon Sep 17 00:00:00 2001
From: Paul Menzel <paulepanter@users.sourceforge.net>
Date: Sat, 12 Dec 2009 10:17:52 +0100
Subject: [PATCH 1/1] Package VDR.

The upstream Makefile needs to be patched to use the headers from the staging area.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 conf/checksums.ini               |    4 ++++
 recipes/vdr/files/fixpaths.patch |   11 +++++++++++
 recipes/vdr/vdr_1.7.10.bb        |   11 +++++++++++
 3 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 recipes/vdr/files/fixpaths.patch
 create mode 100644 recipes/vdr/vdr_1.7.10.bb

diff --git a/conf/checksums.ini b/conf/checksums.ini
index 3bf9854..e717f1b 100644
--- a/conf/checksums.ini
+++ b/conf/checksums.ini
@@ -27046,6 +27046,10 @@ sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 md5=d97a8dbc72942c57542f50322b538a48
 sha256=05b473815f9706387a3c5eaeb4da2e492f624e0b7783432179454f9d69bb973c
 
+[ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.10.tar.bz2]
+md5=c74ee966baca1c47ed6b9e2be3d1639b
+sha256=165bfcd811ef92cab50d11a88a76c481e105689438929414d27edfacfb312f52
+
 [ftp://ftp.billsgames.com/unix/x/vectoroids/src/vectoroids-1.1.0.tar.gz]
 md5=c63ce56b09aa7da9a6e95d804e9ee314
 sha256=8d14dd281767e994108abd77c8e67d5a17718d0ad1e34d37e026911d14697b2e
diff --git a/recipes/vdr/files/fixpaths.patch b/recipes/vdr/files/fixpaths.patch
new file mode 100644
index 0000000..418f2d9
--- /dev/null
+++ b/recipes/vdr/files/fixpaths.patch
@@ -0,0 +1,11 @@
+--- vdr/Makefile~fixpaths	2009-10-18 15:59:25.000000000 +0200
++++ vdr/Makefile	2009-12-13 12:28:22.000000000 +0100
+@@ -21,7 +21,7 @@
+ BINDIR   = $(PREFIX)/bin
+ LOCDIR   = ./locale
+ LIBS     = -ljpeg -lpthread -ldl -lcap -lrt -lfreetype -lfontconfig
+-INCLUDES = -I/usr/include/freetype2
++INCLUDES = ${CFLAGS}
+ 
+ PLUGINDIR= ./PLUGINS
+ PLUGINLIBDIR= $(PLUGINDIR)/lib
diff --git a/recipes/vdr/vdr_1.7.10.bb b/recipes/vdr/vdr_1.7.10.bb
new file mode 100644
index 0000000..d9bcfb4
--- /dev/null
+++ b/recipes/vdr/vdr_1.7.10.bb
@@ -0,0 +1,11 @@
+DESCRIPTION = "Video Disk Recorder (VDR) is a digital sat-receiver program using Linux and DVB technologies. It allows one to record MPEG2 streams, as well as output the stream to TV. It is also possible to watch DVDs (hardware accelerated) with some comfort and use an IR remote control."
+AUTHOR = "Klaus Schmidinger"
+LICENSE = "GPLv2"
+HOMEPAGE = "http://www.tvdr.de"
+
+DEPENDS = "fontconfig freetype gettext libcap jpeg"
+
+SRC_URI = "ftp://ftp.tvdr.de/vdr/Developer/${P}.tar.bz2 \
+           file://fixpaths.patch;patch=1"
+
+CFLAGS_append += " -I${STAGING_INCDIR}/freetype2"
-- 
1.6.5.4


[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [done] package VDR for OE
  2010-01-03 14:15               ` Paul Menzel
@ 2010-01-04 21:37                 ` Paul Menzel
  0 siblings, 0 replies; 16+ messages in thread
From: Paul Menzel @ 2010-01-04 21:37 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Am Sonntag, den 03.01.2010, 15:15 +0100 schrieb Paul Menzel:
> Am Montag, den 14.12.2009, 21:28 +0100 schrieb Paul Menzel:
> > Am Montag, den 14.12.2009, 21:10 +0100 schrieb Henning Heinold:
> > > On Mon, Dec 14, 2009 at 08:13:32PM +0100, Paul Menzel wrote:
> > > > Could someone advise me on how to get VDR included officially into OE?
> > > > Had someone time already to test the recipe?
> > > 
> > > Please submit your recipe here with git format-patch. I will look into it.
> > 
> > Thank you. I sent it already on yesterday 16:45 CET [1]. If you do not
> > have it in your mailbox I can sent the attachment again.
> 
> Sorry to bother you again. I guess you had and have a lot of other
> business to take care of.

Henning did tremendous work and finished packaging VDR and committed it
in 97e1b707d6504343f02e683f49eb2cb6db2cc091 [1]. Actually he is the
author. I would never have been able to do this!

Thank you Henning!!! I will spread the word in the community!

I do not know what the patches exactly do, but I will try to get them
upstream.

I will test it as soon as possible on my system.


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=97e1b707d6504343f02e683f49eb2cb6db2cc091

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* environment variables in Makefile for cross compilation (was: package VDR for OE)
  2009-12-13 15:45       ` Paul Menzel
  2009-12-14 19:13         ` Paul Menzel
@ 2010-01-10 12:40         ` Paul Menzel
  2010-01-10 13:00           ` Frans Meulenbroeks
  2010-01-19  0:22         ` Setting environment variables in recipes and fixing upstream the right way to cross compile? " Paul Menzel
  2 siblings, 1 reply; 16+ messages in thread
From: Paul Menzel @ 2010-01-10 12:40 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Am Sonntag, den 13.12.2009, 16:45 +0100 schrieb Paul Menzel:
> Am Sonntag, den 13.12.2009, 15:18 +0100 schrieb Petr Štetiar:
> > Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:
> 
> […]
>  
> > INCLUDES = -I${STAGING_INCDIR}freetype2
> > 
> > to 
> > 
> > INCLUDES = ${CFLAGS}
> > 
> > and in your recipe do:
> > 
> > CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"
> 
> Great. That worked.
> 
> > > Furthermore is there a better way for upstream to set things up so that
> > > no patching is needed? Or is autotools needed for this?
> 
> I am still asking if upstream could change something to make the
> Makefile cross compilable by default.

Is there an environment variable for a handmade Makefile to make it
cross compilable? Or is patching the upstream Makefile inevitable?

[…]


Thanks,

Paul

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: environment variables in Makefile for cross compilation (was: package VDR for OE)
  2010-01-10 12:40         ` environment variables in Makefile for cross compilation (was: package VDR for OE) Paul Menzel
@ 2010-01-10 13:00           ` Frans Meulenbroeks
  0 siblings, 0 replies; 16+ messages in thread
From: Frans Meulenbroeks @ 2010-01-10 13:00 UTC (permalink / raw)
  To: openembedded-devel

2010/1/10 Paul Menzel <paulepanter@users.sourceforge.net>:
> Am Sonntag, den 13.12.2009, 16:45 +0100 schrieb Paul Menzel:
>> Am Sonntag, den 13.12.2009, 15:18 +0100 schrieb Petr Štetiar:
>> > Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:
>>
>> […]
>>
>> > INCLUDES = -I${STAGING_INCDIR}freetype2
>> >
>> > to
>> >
>> > INCLUDES = ${CFLAGS}
>> >
>> > and in your recipe do:
>> >
>> > CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"
>>
>> Great. That worked.
>>
>> > > Furthermore is there a better way for upstream to set things up so that
>> > > no patching is needed? Or is autotools needed for this?
>>
>> I am still asking if upstream could change something to make the
>> Makefile cross compilable by default.
>
> Is there an environment variable for a handmade Makefile to make it
> cross compilable? Or is patching the upstream Makefile inevitable?

You can always have your own makefile in the recipe dir and overwrite
the existing one in a patch.
But personally I prefer patches to makefiles, as you can piggyback on
changes in the original makefile (or worst case, if the patch fails on
a newer version you know that some work is waiting.

Frans
>
> […]
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Setting environment variables in recipes and fixing upstream the right way to cross compile? (was: package VDR for OE)
  2009-12-13 15:45       ` Paul Menzel
  2009-12-14 19:13         ` Paul Menzel
  2010-01-10 12:40         ` environment variables in Makefile for cross compilation (was: package VDR for OE) Paul Menzel
@ 2010-01-19  0:22         ` Paul Menzel
  2 siblings, 0 replies; 16+ messages in thread
From: Paul Menzel @ 2010-01-19  0:22 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

Am Sonntag, den 13.12.2009, 16:45 +0100 schrieb Paul Menzel:
> Am Sonntag, den 13.12.2009, 15:18 +0100 schrieb Petr Štetiar:
> > Paul Menzel <paulepanter@users.sourceforge.net> [2009-12-13 14:46:20]:
> 
> […]
> 
> > Maybe, it's because you don't have STAGING_INCDIR variable available in
> > do_compile() step. If I were you, I would grep for STAGING_INCDIR variable in
> > other recipes: grep -R STAGING_INCDIR recipes/* and you should get idea how to
> > use it. Hint, change :
> > 
> > INCLUDES = -I${STAGING_INCDIR}freetype2
> > 
> > to 
> > 
> > INCLUDES = ${CFLAGS}
> > 
> > and in your recipe do:
> > 
> > CFLAGS_append  += " -I${STAGING_INCDIR}/freetype2"
> 
> Great. That worked.
> 
> > > Furthermore is there a better way for upstream to set things up so that
> > > no patching is needed? Or is autotools needed for this?
> 
> I am still asking if upstream could change something to make the
> Makefile cross compilable by default.

How should the upstream Makefile be changed to be easily cross
compilable. Is my following suggestion correct?

The problem is to find the FreeType headers we have to tell the compiler
where there are, because they are in the subdirectory `freetype` under 
`${STAGING_INCDIR}/freetype2`.

Therefore change upstream Makefile to

        -INCLUDES = /usr/include/freetype2`
        +INCLUDES ?= /usr/include/freetype2`

and export `INCLUDES` [1] in the recipe.

        export INCLUDES = ${STAGING_INCDIR}/freetype2

Would that be preferable to patching `Makefile` in OE and using
`CFLAGS_append`? Maybe other distributions would profit too if upstream
made this change? If yes, I could prepare a patch.

[…]


Thanks,

Paul


[1] http://docs.openembedded.org/usermanual/html/recipes_syntax.html

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2010-01-19  0:24 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-12 11:48 package VDR for OE Paul Menzel
2009-12-12 17:33 ` Henning Heinold
2009-12-13 13:46   ` Paul Menzel
2009-12-13 14:18     ` Petr Štetiar
2009-12-13 15:45       ` Paul Menzel
2009-12-14 19:13         ` Paul Menzel
2009-12-14 20:10           ` Henning Heinold
2009-12-14 20:28             ` Paul Menzel
2010-01-03 14:15               ` Paul Menzel
2010-01-04 21:37                 ` [done] " Paul Menzel
2010-01-10 12:40         ` environment variables in Makefile for cross compilation (was: package VDR for OE) Paul Menzel
2010-01-10 13:00           ` Frans Meulenbroeks
2010-01-19  0:22         ` Setting environment variables in recipes and fixing upstream the right way to cross compile? " Paul Menzel
2009-12-13 16:34     ` package VDR for OE Koen Kooi
2009-12-13 18:05       ` Paul Menzel
2009-12-13 18:32         ` Petr Štetiar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.