[RFC][PATCH] Move udev cache creation after checkroot

* [RFC][PATCH] Move udev cache creation after checkroot
@ 2010-01-12 13:54 Koen Kooi
  2010-01-12 14:04 ` Graeme Gregory
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Koen Kooi @ 2010-01-12 13:54 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

What's your opinion on attached (untested) patch? If there's some
consensus that this is a step in the right direction I'll create a
working & tested patch to commit.

Nota bene: I'm not going to discuss the merits of udev caching, only the
impact of this patch to the current situation.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLTH8oMkyGM64RGpERAqk0AJ4/5rUWj/Ciyfy0lfcDnM1SgqUN9gCeOr9f
QDA6nnADhKgOt6LEQZK+AUA=
=EtI0
-----END PGP SIGNATURE-----

[-- Attachment #2: 0001-udev-141-move-creation-of-etc-dev.tar-to-after-check.patch --]
[-- Type: text/x-patch, Size: 3164 bytes --]

From 1a77c8e64b2ba25e8f08b6b577c59312ed87a9e6 Mon Sep 17 00:00:00 2001
From: Koen Kooi <koen@openembedded.org>
Date: Tue, 12 Jan 2010 14:48:59 +0100
Subject: [PATCH] udev 141: move creation of /etc/dev.tar to after checkroot

* / isn't always mounted rw when udev runs, so lets create /etc/dev.tar after checkroot has run
---
 recipes/udev/udev-141/cache |   18 ++++++++++++++++++
 recipes/udev/udev-141/init  |    8 --------
 recipes/udev/udev_141.bb    |   10 ++++++++--
 3 files changed, 26 insertions(+), 10 deletions(-)
 create mode 100644 recipes/udev/udev-141/cache

diff --git a/recipes/udev/udev-141/cache b/recipes/udev/udev-141/cache
new file mode 100644
index 0000000..4db1466
--- /dev/null
+++ b/recipes/udev/udev-141/cache
@@ -0,0 +1,18 @@
+#!/bin/sh -e
+
+export TZ=/etc/localtime
+
+[ -f /etc/default/udev ] && . /etc/default/udev
+
+echo "Caching udev devnodes"
+
+			if [ "$DEVCACHE" != "" ]; then
+				echo -n "Populating dev cache"
+				(cd /; tar cf $DEVCACHE dev)
+				mv /tmp/uname /etc/udev/saved.uname
+				mv /tmp/cmdline /etc/udev/saved.cmdline
+				mv /tmp/atags /etc/udev/saved.atags
+				echo
+			fi
+
+exit 0
diff --git a/recipes/udev/udev-141/init b/recipes/udev/udev-141/init
index a0bdf40..24ca9d8 100644
--- a/recipes/udev/udev-141/init
+++ b/recipes/udev/udev-141/init
@@ -68,14 +68,6 @@ kill_udevd > "/dev/null" 2>&1
 		else
 			/sbin/udevadm trigger
 			/sbin/udevadm settle
-			if [ "$DEVCACHE" != "" ]; then
-				echo -n "Populating dev cache"
-				(cd /; tar cf $DEVCACHE dev)
-				mv /tmp/uname /etc/udev/saved.uname
-				mv /tmp/cmdline /etc/udev/saved.cmdline
-				mv /tmp/atags /etc/udev/saved.atags
-				echo
-			fi
 		fi
 
 exit 0
diff --git a/recipes/udev/udev_141.bb b/recipes/udev/udev_141.bb
index 00ba971..df5e346 100644
--- a/recipes/udev/udev_141.bb
+++ b/recipes/udev/udev_141.bb
@@ -6,7 +6,7 @@ LICENSE = "GPL"
 # Untested
 DEFAULT_PREFERENCE = "-1"
 
-PR = "r19"
+PR = "r20"
 
 # needed for init.d script
 RDEPENDS_${PN} += "udev-utils"
@@ -24,7 +24,9 @@ SRC_URI += " \
        file://network.sh \
        file://local.rules \
        file://default \
-       file://init"
+       file://init \
+       file://cache \
+"
 
 SRC_URI_append_h2200 = " file://50-hostap_cs.rules "
 PACKAGE_ARCH_h2200 = "h2200"
@@ -70,6 +72,7 @@ do_install () {
 	oe_runmake 'DESTDIR=${D}' INSTALL=install install
 	install -d ${D}${sysconfdir}/init.d
 	install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/udev
+	install -m 0755 ${WORKDIR}/cache ${D}${sysconfdir}/init.d/udev-cache
 
 	install -d ${D}${sysconfdir}/default
 	install -m 0755 ${WORKDIR}/default ${D}${sysconfdir}/default/udev
@@ -112,7 +115,10 @@ do_install_append_bug() {
 	install -m 0644 ${WORKDIR}/bmi_eventpipe.sh ${D}${sysconfdir}/udev/scripts/bmi_eventpipe.sh
 }
 
+# Create the cache after checkroot has run
 pkg_postinst_${PN}_append() {
+update-rc.d $OPT udev-cache start 12 S .
+
 if [ -d $D/lib/udev/rules.d ] ; then
 	echo "$D/lib/udev/rules.d is not a symlink, fixing that"
 	mv $D/lib/udev/rules.d/* $D${sysconfdir}/udev/rules.d/
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 7+ messages in thread