[patch] timer_list should use signed numbers for relative times

[patch] timer_list should use signed numbers for relative times

[Pavel Machek]

Relative times are signed by nature, and timers can (briefly) have
expires in past. Print them as negative numbers.

Signed-off-by: Pavel Machek <pavel@suse.cz>

diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
index 12c5f4c..7f6eaa9 100644
--- a/kernel/time/timer_list.c
+++ b/kernel/time/timer_list.c
@@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS
 	SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
 #endif
 	SEQ_printf(m, "\n");
-	SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n",
+	SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n",
 		(unsigned long long)ktime_to_ns(timer->expires),
 		(unsigned long long)(ktime_to_ns(timer->expires) - now));
 }

 


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [patch] timer_list should use signed numbers for relative times

[Andreas Schwab]

Pavel Machek <pavel@ucw.cz> writes:

> Relative times are signed by nature, and timers can (briefly) have
> expires in past. Print them as negative numbers.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
> index 12c5f4c..7f6eaa9 100644
> --- a/kernel/time/timer_list.c
> +++ b/kernel/time/timer_list.c
> @@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS
>  	SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
>  #endif
>  	SEQ_printf(m, "\n");
> -	SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n",
> +	SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n",
>  		(unsigned long long)ktime_to_ns(timer->expires),
>  		(unsigned long long)(ktime_to_ns(timer->expires) - now));

Perhaps change the cast as well.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [patch] timer_list should use signed numbers for relative times

[Pavel Machek]

Hi!


> > Relative times are signed by nature, and timers can (briefly) have
> > expires in past. Print them as negative numbers.
> >
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >
> > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
> > index 12c5f4c..7f6eaa9 100644
> > --- a/kernel/time/timer_list.c
> > +++ b/kernel/time/timer_list.c
> > @@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS
> >  	SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
> >  #endif
> >  	SEQ_printf(m, "\n");
> > -	SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n",
> > +	SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n",
> >  		(unsigned long long)ktime_to_ns(timer->expires),
> >  		(unsigned long long)(ktime_to_ns(timer->expires) - now));
> 
> Perhaps change the cast as well.

Well, that seems to be absolute time, so %Lu makes some sense...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [patch] timer_list should use signed numbers for relative times

[Andreas Schwab]

Pavel Machek <pavel@ucw.cz> writes:

> Hi!
>
>
>> > Relative times are signed by nature, and timers can (briefly) have
>> > expires in past. Print them as negative numbers.
>> >
>> > Signed-off-by: Pavel Machek <pavel@suse.cz>
>> >
>> > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
>> > index 12c5f4c..7f6eaa9 100644
>> > --- a/kernel/time/timer_list.c
>> > +++ b/kernel/time/timer_list.c
>> > @@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS
>> >  	SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
>> >  #endif
>> >  	SEQ_printf(m, "\n");
>> > -	SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n",
>> > +	SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n",
>> >  		(unsigned long long)ktime_to_ns(timer->expires),
>> >  		(unsigned long long)(ktime_to_ns(timer->expires) - now));
>> 
>> Perhaps change the cast as well.
>
> Well, that seems to be absolute time, so %Lu makes some sense...

I don't understand what this has to do with the cast.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [patch] timer_list should use signed numbers for relative times

[Pavel Machek]

On Tue 2007-11-27 15:19:27, Andreas Schwab wrote:
> Pavel Machek <pavel@ucw.cz> writes:
> 
> > Hi!
> >
> >
> >> > Relative times are signed by nature, and timers can (briefly) have
> >> > expires in past. Print them as negative numbers.
> >> >
> >> > Signed-off-by: Pavel Machek <pavel@suse.cz>
> >> >
> >> > diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c
> >> > index 12c5f4c..7f6eaa9 100644
> >> > --- a/kernel/time/timer_list.c
> >> > +++ b/kernel/time/timer_list.c
> >> > @@ -65,7 +65,7 @@ #ifdef CONFIG_TIMER_STATS
> >> >  	SEQ_printf(m, ", %s/%d", tmp, timer->start_pid);
> >> >  #endif
> >> >  	SEQ_printf(m, "\n");
> >> > -	SEQ_printf(m, " # expires at %Lu nsecs [in %Lu nsecs]\n",
> >> > +	SEQ_printf(m, " # expires at %Lu nsecs [in %Ld nsecs]\n",
> >> >  		(unsigned long long)ktime_to_ns(timer->expires),
> >> >  		(unsigned long long)(ktime_to_ns(timer->expires) - now));
> >> 
> >> Perhaps change the cast as well.
> >
> > Well, that seems to be absolute time, so %Lu makes some sense...
> 
> I don't understand what this has to do with the cast.

Aha, stupid me, yes, you are right, fixed.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html