From: ebiederm@xmission.com (Eric W. Biederman)
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
Netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] wireless extensions: play with netns
Date: Wed, 17 Jun 2009 16:24:58 -0700 [thread overview]
Message-ID: <m1r5xitpdh.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <1245276899.31588.57.camel@johannes.local> (Johannes Berg's message of "Thu\, 18 Jun 2009 00\:14\:59 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2009-06-17 at 13:46 -0700, Eric W. Biederman wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > This makes wireless extensions netns aware.
>> >
>> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>> > ---
>> > Is this ok, or is this racy? I guess what I'm asking is -- will
>> > for_each_net() stop iterating over a netns that is going away before the
>> > pernet exit op is called? If yes, this should be fine.
>>
>> for_each_net requires the rtnl_lock or the net_mutex to be safe.
>> You aren't taking either so your code is racy.
>
> So it looks like I can also use rcu_read_lock(), but there's no
> for_each_net_rcu(), should there be?
I'm not using rcu safe list manipulation. What makes it look like
rcu_read_lock() is safe?
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org (Eric W. Biederman)
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
Netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-BGArkANP9klv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
Alexey Dobriyan
<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] wireless extensions: play with netns
Date: Wed, 17 Jun 2009 16:24:58 -0700 [thread overview]
Message-ID: <m1r5xitpdh.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <1245276899.31588.57.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org> (Johannes Berg's message of "Thu\, 18 Jun 2009 00\:14\:59 +0200")
Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> writes:
> On Wed, 2009-06-17 at 13:46 -0700, Eric W. Biederman wrote:
>> Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> writes:
>>
>> > This makes wireless extensions netns aware.
>> >
>> > Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
>> > ---
>> > Is this ok, or is this racy? I guess what I'm asking is -- will
>> > for_each_net() stop iterating over a netns that is going away before the
>> > pernet exit op is called? If yes, this should be fine.
>>
>> for_each_net requires the rtnl_lock or the net_mutex to be safe.
>> You aren't taking either so your code is racy.
>
> So it looks like I can also use rcu_read_lock(), but there's no
> for_each_net_rcu(), should there be?
I'm not using rcu safe list manipulation. What makes it look like
rcu_read_lock() is safe?
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-06-17 23:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 18:24 [PATCH] wireless extensions: play with netns Johannes Berg
2009-06-17 18:24 ` Johannes Berg
2009-06-17 20:46 ` Eric W. Biederman
2009-06-17 20:46 ` Eric W. Biederman
2009-06-17 20:50 ` Johannes Berg
2009-06-17 21:40 ` [PATCH v2] wireless extensions: make netns aware Johannes Berg
2009-06-17 21:40 ` Johannes Berg
2009-06-17 22:14 ` [PATCH] wireless extensions: play with netns Johannes Berg
2009-06-17 22:14 ` Johannes Berg
2009-06-17 23:24 ` Eric W. Biederman [this message]
2009-06-17 23:24 ` Eric W. Biederman
2009-06-17 23:41 ` Johannes Berg
2009-06-17 23:41 ` Johannes Berg
2009-06-17 23:45 ` Johannes Berg
2009-06-18 0:27 ` Eric W. Biederman
2009-06-18 0:27 ` Eric W. Biederman
2009-06-18 0:35 ` Johannes Berg
2009-06-17 23:54 ` Eric W. Biederman
2009-06-17 23:54 ` Eric W. Biederman
2009-06-18 0:02 ` Johannes Berg
2009-06-18 0:02 ` Johannes Berg
2009-06-18 0:30 ` Eric W. Biederman
2009-06-18 0:30 ` Eric W. Biederman
2009-06-18 0:39 ` Johannes Berg
2009-06-18 0:39 ` Johannes Berg
2009-06-18 1:12 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r5xitpdh.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=adobriyan@gmail.com \
--cc=ebiederm@aristanetworks.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.