All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Edmondson <david.edmondson@oracle.com>
To: zhaolichang <zhaolichang@huawei.com>, qemu-trivial@nongnu.org
Cc: zhaolichang <zhaolichang@huawei.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH RFC 01/14] cris/: fix some comment spelling errors
Date: Wed, 30 Sep 2020 11:49:48 +0100	[thread overview]
Message-ID: <m28scrr12r.fsf@oracle.com> (raw)
In-Reply-To: <20200930095321.2006-2-zhaolichang@huawei.com>

On Wednesday, 2020-09-30 at 17:53:08 +08, zhaolichang wrote:

> I found that there are many spelling errors in the comments of qemu/target/cris.
> I used spellcheck to check the spelling errors and found some errors in the folder.
>
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>

With the correction below...

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  target/cris/helper.c    |  6 +++---
>  target/cris/op_helper.c |  2 +-
>  target/cris/translate.c | 14 +++++++-------
>  3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/target/cris/helper.c b/target/cris/helper.c
> index b5159b8..50419e7 100644
> --- a/target/cris/helper.c
> +++ b/target/cris/helper.c
> @@ -141,7 +141,7 @@ void crisv10_cpu_do_interrupt(CPUState *cs)
>      assert(!(env->pregs[PR_CCS] & PFIX_FLAG));
>      switch (cs->exception_index) {
>      case EXCP_BREAK:
> -        /* These exceptions are genereated by the core itself.
> +        /* These exceptions are generated by the core itself.
>             ERP should point to the insn following the brk.  */
>          ex_vec = env->trap_vector;
>          env->pregs[PRV10_BRP] = env->pc;
> @@ -197,7 +197,7 @@ void cris_cpu_do_interrupt(CPUState *cs)
>  
>      switch (cs->exception_index) {
>      case EXCP_BREAK:
> -        /* These exceptions are genereated by the core itself.
> +        /* These exceptions are generated by the core itself.
>             ERP should point to the insn following the brk.  */
>          ex_vec = env->trap_vector;
>          env->pregs[PR_ERP] = env->pc;
> @@ -256,7 +256,7 @@ void cris_cpu_do_interrupt(CPUState *cs)
>         undefined.  */
>      env->pc = cpu_ldl_code(env, env->pregs[PR_EBP] + ex_vec * 4);
>  
> -    /* Clear the excption_index to avoid spurios hw_aborts for recursive
> +    /* Clear the excption_index to avoid spurious hw_aborts for recursive

"exception_index"

>         bus faults.  */
>      cs->exception_index = -1;
>  
> diff --git a/target/cris/op_helper.c b/target/cris/op_helper.c
> index 6b1e7ae..3c4aacc 100644
> --- a/target/cris/op_helper.c
> +++ b/target/cris/op_helper.c
> @@ -231,7 +231,7 @@ static inline uint32_t evaluate_flags_writeback(CPUCRISState *env,
>  {
>      unsigned int x, z, mask;
>  
> -    /* Extended arithmetics, leave the z flag alone.  */
> +    /* Extended arithmetic, leave the z flag alone.  */
>      x = env->cc_x;
>      mask = env->cc_mask | X_FLAG;
>      if (x) {
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index c312e6f..16b0ef8 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -348,7 +348,7 @@ static void t_gen_cris_mstep(TCGv d, TCGv a, TCGv b, TCGv ccs)
>      tcg_temp_free(t);
>  }
>  
> -/* Extended arithmetics on CRIS.  */
> +/* Extended arithmetic on CRIS.  */
>  static inline void t_gen_add_flag(TCGv d, int flag)
>  {
>      TCGv c;
> @@ -725,7 +725,7 @@ static void cris_alu_op_exec(DisasContext *dc, int op,
>      switch (op) {
>      case CC_OP_ADD:
>          tcg_gen_add_tl(dst, a, b);
> -        /* Extended arithmetics.  */
> +        /* Extended arithmetic.  */
>          t_gen_addx_carry(dc, dst);
>          break;
>      case CC_OP_ADDC:
> @@ -738,7 +738,7 @@ static void cris_alu_op_exec(DisasContext *dc, int op,
>          break;
>      case CC_OP_SUB:
>          tcg_gen_sub_tl(dst, a, b);
> -        /* Extended arithmetics.  */
> +        /* Extended arithmetic.  */
>          t_gen_subx_carry(dc, dst);
>          break;
>      case CC_OP_MOVE:
> @@ -764,7 +764,7 @@ static void cris_alu_op_exec(DisasContext *dc, int op,
>          break;
>      case CC_OP_NEG:
>          tcg_gen_neg_tl(dst, b);
> -        /* Extended arithmetics.  */
> +        /* Extended arithmetic.  */
>          t_gen_subx_carry(dc, dst);
>          break;
>      case CC_OP_LZ:
> @@ -787,7 +787,7 @@ static void cris_alu_op_exec(DisasContext *dc, int op,
>          break;
>      case CC_OP_CMP:
>          tcg_gen_sub_tl(dst, a, b);
> -        /* Extended arithmetics.  */
> +        /* Extended arithmetic.  */
>          t_gen_subx_carry(dc, dst);
>          break;
>      default:
> @@ -3053,12 +3053,12 @@ static unsigned int crisv32_decoder(CPUCRISState *env, DisasContext *dc)
>   * On QEMU care needs to be taken when a branch+delayslot sequence is broken
>   * and the branch and delayslot don't share pages.
>   *
> - * The TB contaning the branch insn will set up env->btarget and evaluate 
> + * The TB containing the branch insn will set up env->btarget and evaluate 
>   * env->btaken. When the translation loop exits we will note that the branch 
>   * sequence is broken and let env->dslot be the size of the branch insn (those
>   * vary in length).
>   *
> - * The TB contaning the delayslot will have the PC of its real insn (i.e no lsb
> + * The TB containing the delayslot will have the PC of its real insn (i.e no lsb
>   * set). It will also expect to have env->dslot setup with the size of the 
>   * delay slot so that env->pc - env->dslot point to the branch insn. This TB 
>   * will execute the dslot and take the branch, either to btarget or just one 
> -- 
> 2.26.2.windows.1

dme.
-- 
Driving at 90 down those country lanes, singing to "Tiny Dancer".


  reply	other threads:[~2020-09-30 14:52 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  9:53 [PATCH RFC 00/14] fix some comment spelling errors zhaolichang
2020-09-30  9:53 ` zhaolichang
2020-09-30  9:53 ` [PATCH RFC 01/14] cris/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:49   ` David Edmondson [this message]
2020-09-30  9:53 ` [PATCH RFC 02/14] ppc/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:50   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 03/14] riscv/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:51   ` David Edmondson
2020-09-30 15:43   ` Alistair Francis
2020-09-30  9:53 ` [PATCH RFC 04/14] rx/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:25   ` Philippe Mathieu-Daudé
2020-09-30 10:51   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 05/14] tricore/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:52   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 06/14] mips/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:23   ` Philippe Mathieu-Daudé
2020-09-30 10:27     ` Philippe Mathieu-Daudé
2020-09-30 10:52   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 07/14] s390x/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:53   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 08/14] m68k/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:26   ` Laurent Vivier
2020-09-30 16:03     ` Philippe Mathieu-Daudé
2020-09-30 16:19       ` Laurent Vivier
2020-09-30 10:54   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 09/14] sh4/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:24   ` Philippe Mathieu-Daudé
2020-09-30 10:54   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 10/14] i386/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:55   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 11/14] avr/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:24   ` Philippe Mathieu-Daudé
2020-09-30 10:55   ` David Edmondson
2020-09-30  9:53 ` [PATCH RFC 12/14] arm/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:56   ` David Edmondson
2020-09-30 16:04   ` Philippe Mathieu-Daudé
2020-09-30  9:53 ` [PATCH RFC 13/14] alpha/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:56   ` David Edmondson
2020-09-30 16:01   ` Philippe Mathieu-Daudé
2020-09-30  9:53 ` [PATCH RFC 14/14] target/: " zhaolichang
2020-09-30  9:53   ` zhaolichang
2020-09-30 10:25   ` Philippe Mathieu-Daudé
2020-09-30 10:56   ` David Edmondson
2020-09-30 10:28 ` [PATCH RFC 00/14] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m28scrr12r.fsf@oracle.com \
    --to=david.edmondson@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhaolichang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.