From: David Edmondson <david.edmondson@oracle.com>
To: zhaolichang <zhaolichang@huawei.com>, qemu-trivial@nongnu.org
Cc: zhaolichang <zhaolichang@huawei.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH RFC 10/14] i386/: fix some comment spelling errors
Date: Wed, 30 Sep 2020 11:55:20 +0100 [thread overview]
Message-ID: <m2imbvpm93.fsf@oracle.com> (raw)
In-Reply-To: <20200930095321.2006-11-zhaolichang@huawei.com>
On Wednesday, 2020-09-30 at 17:53:17 +08, zhaolichang wrote:
> I found that there are many spelling errors in the comments of qemu/target/i386.
> I used spellcheck to check the spelling errors and found some errors in the folder.
>
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> target/i386/cpu.c | 4 ++--
> target/i386/hax-interface.h | 4 ++--
> target/i386/hax-windows.c | 2 +-
> target/i386/kvm.c | 2 +-
> target/i386/machine.c | 6 +++---
> target/i386/translate.c | 8 ++++----
> target/i386/whpx-all.c | 2 +-
> 7 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 3ffd877..23851e5 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -4677,7 +4677,7 @@ static const char *x86_cpu_feature_name(FeatureWord w, int bitnr)
> return name;
> }
>
> -/* Compatibily hack to maintain legacy +-feat semantic,
> +/* Compatibility hack to maintain legacy +-feat semantic,
> * where +-feat overwrites any feature set by
> * feat=on|feat even if the later is parsed after +-feat
> * (i.e. "-x2apic,x2apic=on" will result in x2apic disabled)
> @@ -6896,7 +6896,7 @@ static void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v,
> GuestPanicInformation *panic_info;
>
> if (!cs->crash_occurred) {
> - error_setg(errp, "No crash occured");
> + error_setg(errp, "No crash occurred");
> return;
> }
>
> diff --git a/target/i386/hax-interface.h b/target/i386/hax-interface.h
> index 537ae08..edef4fd 100644
> --- a/target/i386/hax-interface.h
> +++ b/target/i386/hax-interface.h
> @@ -238,7 +238,7 @@ enum exit_status {
> HAX_EXIT_UNKNOWN_VMEXIT,
> /* HALT from guest */
> HAX_EXIT_HLT,
> - /* Reboot request, like because of tripple fault in guest */
> + /* Reboot request, like because of triple fault in guest */
> HAX_EXIT_STATECHANGE,
> /* the vcpu is now only paused when destroy, so simply return to hax */
> HAX_EXIT_PAUSED,
> @@ -295,7 +295,7 @@ struct hax_qemu_version {
> uint32_t min_version;
> } __attribute__ ((__packed__));
>
> -/* The mac specfic interface to qemu, mostly is ioctl related */
> +/* The mac specific interface to qemu, mostly is ioctl related */
> struct hax_tunnel_info {
> uint64_t va;
> uint64_t io_va;
> diff --git a/target/i386/hax-windows.c b/target/i386/hax-windows.c
> index 863c2bc..881089b 100644
> --- a/target/i386/hax-windows.c
> +++ b/target/i386/hax-windows.c
> @@ -174,7 +174,7 @@ int hax_mod_version(struct hax_state *hax, struct hax_module_version *version)
> if (!ret) {
> err = GetLastError();
> if (err == ERROR_INSUFFICIENT_BUFFER || err == ERROR_MORE_DATA) {
> - fprintf(stderr, "hax module verion is too long to hold.\n");
> + fprintf(stderr, "hax module version is too long to hold.\n");
> }
> fprintf(stderr, "Failed to get Hax module version:%lu\n", err);
> return -EFAULT;
> diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> index 9efb07e..fbdbb49 100644
> --- a/target/i386/kvm.c
> +++ b/target/i386/kvm.c
> @@ -1179,7 +1179,7 @@ static int hv_cpuid_check_and_set(CPUState *cs, struct kvm_cpuid2 *cpuid,
> /*
> * Fill in Hyper-V CPUIDs. Returns the number of entries filled in cpuid_ent in
> * case of success, errno < 0 in case of failure and 0 when no Hyper-V
> - * extentions are enabled.
> + * extensions are enabled.
> */
> static int hyperv_handle_properties(CPUState *cs,
> struct kvm_cpuid_entry2 *cpuid_ent)
> diff --git a/target/i386/machine.c b/target/i386/machine.c
> index b1acf7d..90e6139 100644
> --- a/target/i386/machine.c
> +++ b/target/i386/machine.c
> @@ -264,12 +264,12 @@ static int cpu_pre_save(void *opaque)
> * hypervisor, its exception payload (CR2/DR6 on #PF/#DB)
> * should not be set yet in the respective vCPU register.
> * Thus, in case an exception is pending, it is
> - * important to save the exception payload seperately.
> + * important to save the exception payload separately.
> *
> * Therefore, if an exception is not in a pending state
> * or vCPU is not in guest-mode, it is not important to
> * distinguish between a pending and injected exception
> - * and we don't need to store seperately the exception payload.
> + * and we don't need to store separately the exception payload.
> *
> * In order to preserve better backwards-compatible migration,
> * convert a pending exception to an injected exception in
> @@ -1138,7 +1138,7 @@ static int nested_state_post_load(void *opaque, int version_id)
> return -EINVAL;
> }
> if (nested_state->size > max_nested_state_len) {
> - error_report("Recieved unsupported nested state size: "
> + error_report("Received unsupported nested state size: "
> "nested_state->size=%d, max=%d",
> nested_state->size, max_nested_state_len);
> return -EINVAL;
> diff --git a/target/i386/translate.c b/target/i386/translate.c
> index caea6f5..5cdfe0e 100644
> --- a/target/i386/translate.c
> +++ b/target/i386/translate.c
> @@ -893,7 +893,7 @@ static CCPrepare gen_prepare_eflags_z(DisasContext *s, TCGv reg)
> }
>
> /* perform a conditional store into register 'reg' according to jump opcode
> - value 'b'. In the fast case, T0 is guaranted not to be used. */
> + value 'b'. In the fast case, T0 is guaranteed not to be used. */
> static CCPrepare gen_prepare_cc(DisasContext *s, int b, TCGv reg)
> {
> int inv, jcc_op, cond;
> @@ -1026,7 +1026,7 @@ static inline void gen_compute_eflags_c(DisasContext *s, TCGv reg)
> }
>
> /* generate a conditional jump to label 'l1' according to jump opcode
> - value 'b'. In the fast case, T0 is guaranted not to be used. */
> + value 'b'. In the fast case, T0 is guaranteed not to be used. */
> static inline void gen_jcc1_noeob(DisasContext *s, int b, TCGLabel *l1)
> {
> CCPrepare cc = gen_prepare_cc(s, b, s->T0);
> @@ -1043,7 +1043,7 @@ static inline void gen_jcc1_noeob(DisasContext *s, int b, TCGLabel *l1)
> }
>
> /* Generate a conditional jump to label 'l1' according to jump opcode
> - value 'b'. In the fast case, T0 is guaranted not to be used.
> + value 'b'. In the fast case, T0 is guaranteed not to be used.
> A translation block must end soon. */
> static inline void gen_jcc1(DisasContext *s, int b, TCGLabel *l1)
> {
> @@ -6841,7 +6841,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
> if (s->prefix & PREFIX_LOCK) {
> switch (op) {
> case 0: /* bt */
> - /* Needs no atomic ops; we surpressed the normal
> + /* Needs no atomic ops; we suppressed the normal
> memory load for LOCK above so do it now. */
> gen_op_ld_v(s, ot, s->T0, s->A0);
> break;
> diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
> index 5a0f337..661f9c7 100644
> --- a/target/i386/whpx-all.c
> +++ b/target/i386/whpx-all.c
> @@ -1214,7 +1214,7 @@ int whpx_init_vcpu(CPUState *cpu)
> vcpu = g_malloc0(sizeof(struct whpx_vcpu));
>
> if (!vcpu) {
> - error_report("WHPX: Failed to allocte VCPU context.");
> + error_report("WHPX: Failed to allocate VCPU context.");
> return -ENOMEM;
> }
>
> --
> 2.26.2.windows.1
dme.
--
Tell me sweet little lies.
next prev parent reply other threads:[~2020-09-30 14:52 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:53 [PATCH RFC 00/14] fix some comment spelling errors zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 9:53 ` [PATCH RFC 01/14] cris/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:49 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 02/14] ppc/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:50 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 03/14] riscv/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:51 ` David Edmondson
2020-09-30 15:43 ` Alistair Francis
2020-09-30 9:53 ` [PATCH RFC 04/14] rx/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:25 ` Philippe Mathieu-Daudé
2020-09-30 10:51 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 05/14] tricore/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:52 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 06/14] mips/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:23 ` Philippe Mathieu-Daudé
2020-09-30 10:27 ` Philippe Mathieu-Daudé
2020-09-30 10:52 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 07/14] s390x/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:53 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 08/14] m68k/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:26 ` Laurent Vivier
2020-09-30 16:03 ` Philippe Mathieu-Daudé
2020-09-30 16:19 ` Laurent Vivier
2020-09-30 10:54 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 09/14] sh4/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:24 ` Philippe Mathieu-Daudé
2020-09-30 10:54 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 10/14] i386/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:55 ` David Edmondson [this message]
2020-09-30 9:53 ` [PATCH RFC 11/14] avr/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:24 ` Philippe Mathieu-Daudé
2020-09-30 10:55 ` David Edmondson
2020-09-30 9:53 ` [PATCH RFC 12/14] arm/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:56 ` David Edmondson
2020-09-30 16:04 ` Philippe Mathieu-Daudé
2020-09-30 9:53 ` [PATCH RFC 13/14] alpha/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:56 ` David Edmondson
2020-09-30 16:01 ` Philippe Mathieu-Daudé
2020-09-30 9:53 ` [PATCH RFC 14/14] target/: " zhaolichang
2020-09-30 9:53 ` zhaolichang
2020-09-30 10:25 ` Philippe Mathieu-Daudé
2020-09-30 10:56 ` David Edmondson
2020-09-30 10:28 ` [PATCH RFC 00/14] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2imbvpm93.fsf@oracle.com \
--to=david.edmondson@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhaolichang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.