From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] pinctrl: meson: fix gpio request disabling other modes
Date: Tue, 06 Dec 2016 16:47:41 -0800 [thread overview]
Message-ID: <m2bmwoftua.fsf@baylibre.com> (raw)
In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linus.walleij@linaro.org, carlo@caione.org,
linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Beniamino Galvani <b.galvani@gmail.com>
Subject: Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes
Date: Tue, 06 Dec 2016 16:47:41 -0800 [thread overview]
Message-ID: <m2bmwoftua.fsf@baylibre.com> (raw)
In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: meson: fix gpio request disabling other modes
Date: Tue, 06 Dec 2016 16:47:41 -0800 [thread overview]
Message-ID: <m2bmwoftua.fsf@baylibre.com> (raw)
In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com> (Neil Armstrong's message of "Tue, 6 Dec 2016 15:08:16 +0100")
Neil Armstrong <narmstrong@baylibre.com> writes:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2016-12-07 0:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
2016-12-06 14:08 ` Neil Armstrong
2016-12-06 14:08 ` Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman [this message]
2016-12-07 0:47 ` Kevin Hilman
2016-12-07 0:47 ` Kevin Hilman
2016-12-11 21:50 ` Beniamino Galvani
2016-12-11 21:50 ` Beniamino Galvani
2016-12-11 21:50 ` Beniamino Galvani
2016-12-28 12:41 ` Linus Walleij
2016-12-28 12:41 ` Linus Walleij
2016-12-28 12:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bmwoftua.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.