All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins
Date: Mon, 03 Apr 2017 09:07:50 -0700	[thread overview]
Message-ID: <m2d1cta2zt.fsf@baylibre.com> (raw)
In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> The nand_groups table uses different names for the NAND DQS pins than
> the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0).
> This prevents using the NAND DQS pins in the devicetree.
>
> Fix this by ensuring that the GROUP() definition and the
> meson8b_cbus_groups use the same name for these pins.
>
> Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c
> index 76f077f18193..f87ef5a0ee6c 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson8b.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c
> @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = {
>  static const char * const nand_groups[] = {
>  	"nand_io", "nand_io_ce0", "nand_io_ce1",
>  	"nand_io_rb0", "nand_ale", "nand_cle",
> -	"nand_wen_clk", "nand_ren_clk", "nand_dqs0",
> -	"nand_dqs1"
> +	"nand_wen_clk", "nand_ren_clk", "nand_dqs_0",
> +	"nand_dqs_1"
>  };
>  
>  static const char * const nor_groups[] = {

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org,
	carlo@caione.org, linus.walleij@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins
Date: Mon, 03 Apr 2017 09:07:50 -0700	[thread overview]
Message-ID: <m2d1cta2zt.fsf@baylibre.com> (raw)
In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> The nand_groups table uses different names for the NAND DQS pins than
> the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0).
> This prevents using the NAND DQS pins in the devicetree.
>
> Fix this by ensuring that the GROUP() definition and the
> meson8b_cbus_groups use the same name for these pins.
>
> Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c
> index 76f077f18193..f87ef5a0ee6c 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson8b.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c
> @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = {
>  static const char * const nand_groups[] = {
>  	"nand_io", "nand_io_ce0", "nand_io_ce1",
>  	"nand_io_rb0", "nand_ale", "nand_cle",
> -	"nand_wen_clk", "nand_ren_clk", "nand_dqs0",
> -	"nand_dqs1"
> +	"nand_wen_clk", "nand_ren_clk", "nand_dqs_0",
> +	"nand_dqs_1"
>  };
>  
>  static const char * const nor_groups[] = {

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins
Date: Mon, 03 Apr 2017 09:07:50 -0700	[thread overview]
Message-ID: <m2d1cta2zt.fsf@baylibre.com> (raw)
In-Reply-To: <20170401135922.1288-2-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sat, 1 Apr 2017 15:59:21 +0200")

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> The nand_groups table uses different names for the NAND DQS pins than
> the GROUP() definition in meson8b_cbus_groups (nand_dqs_0 vs nand_dqs0).
> This prevents using the NAND DQS pins in the devicetree.
>
> Fix this by ensuring that the GROUP() definition and the
> meson8b_cbus_groups use the same name for these pins.
>
> Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Acked-by: Kevin Hilman <khilman@baylibre.com>

> ---
>  drivers/pinctrl/meson/pinctrl-meson8b.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c
> index 76f077f18193..f87ef5a0ee6c 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson8b.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c
> @@ -739,8 +739,8 @@ static const char * const sdxc_c_groups[] = {
>  static const char * const nand_groups[] = {
>  	"nand_io", "nand_io_ce0", "nand_io_ce1",
>  	"nand_io_rb0", "nand_ale", "nand_cle",
> -	"nand_wen_clk", "nand_ren_clk", "nand_dqs0",
> -	"nand_dqs1"
> +	"nand_wen_clk", "nand_ren_clk", "nand_dqs_0",
> +	"nand_dqs_1"
>  };
>  
>  static const char * const nor_groups[] = {

  reply	other threads:[~2017-04-03 16:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25 18:43 [PATCH 0/1] pinctrl-meson8b: fix the NAND DQS pin definitions Martin Blumenstingl
2017-03-25 18:43 ` Martin Blumenstingl
2017-03-25 18:43 ` Martin Blumenstingl
2017-03-25 18:43 ` [PATCH 1/1] pinctrl: meson: meson8b: fix the NAND DQS pins Martin Blumenstingl
2017-03-25 18:43   ` Martin Blumenstingl
2017-03-25 18:43   ` Martin Blumenstingl
2017-03-28 15:09   ` Kevin Hilman
2017-03-28 15:09     ` Kevin Hilman
2017-03-28 15:09     ` Kevin Hilman
2017-03-28 21:26     ` Martin Blumenstingl
2017-03-28 21:26       ` Martin Blumenstingl
2017-03-28 21:26       ` Martin Blumenstingl
2017-04-01 13:59 ` [PATCH v2 0/2] pinctrl-meson8b: fix the NAND DQS pin definitions Martin Blumenstingl
2017-04-01 13:59   ` Martin Blumenstingl
2017-04-01 13:59   ` Martin Blumenstingl
2017-04-01 13:59   ` [PATCH v2 1/2] pinctrl: meson: meson8b: fix the NAND DQS pins Martin Blumenstingl
2017-04-01 13:59     ` Martin Blumenstingl
2017-04-01 13:59     ` Martin Blumenstingl
2017-04-03 16:07     ` Kevin Hilman [this message]
2017-04-03 16:07       ` Kevin Hilman
2017-04-03 16:07       ` Kevin Hilman
2017-04-07  7:29     ` Linus Walleij
2017-04-07  7:29       ` Linus Walleij
2017-04-07  7:29       ` Linus Walleij
2017-04-01 13:59   ` [PATCH v2 2/2] pinctrl: meson: meson8b: rename the NAND DQS pin definitions Martin Blumenstingl
2017-04-01 13:59     ` Martin Blumenstingl
2017-04-01 13:59     ` Martin Blumenstingl
2017-04-03 16:08     ` Kevin Hilman
2017-04-03 16:08       ` Kevin Hilman
2017-04-03 16:08       ` Kevin Hilman
2017-04-07  7:31     ` Linus Walleij
2017-04-07  7:31       ` Linus Walleij
2017-04-07  7:31       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2d1cta2zt.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.