From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/3] pinctrl: meson: meson-gxl: add the pwm_ao_b pin
Date: Mon, 23 Jan 2017 11:10:18 -0800 [thread overview]
Message-ID: <m2sho91tk5.fsf@baylibre.com> (raw)
In-Reply-To: <20170122210528.892-3-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sun, 22 Jan 2017 22:05:27 +0100")
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> This adds support for the pwm_ao_b pin. Unfortunately the registers for
> the pwm_ao pins are not documented at all. The source for the pwm_ao_b
> pin from this patch is the Khadas VIM GPL kernel source, which sets bit
> 3 and unsets bits 4 and 31 to enable the PWM LEDs.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 25694f7094c7..6ff321a7366d 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -222,6 +222,8 @@ static const unsigned int uart_rts_ao_b_pins[] = { PIN(GPIOAO_3, 0) };
>
> static const unsigned int remote_input_ao_pins[] = {PIN(GPIOAO_7, 0) };
>
> +static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) };
> +
Hmm, the S905 public data sheet[1] shows this as GPIOAO_13.
> static struct meson_pmx_group meson_gxl_periphs_groups[] = {
> GPIO_GROUP(GPIOZ_0, EE_OFF),
> GPIO_GROUP(GPIOZ_1, EE_OFF),
> @@ -418,6 +420,7 @@ static struct meson_pmx_group meson_gxl_aobus_groups[] = {
> GROUP(uart_cts_ao_b, 0, 8),
> GROUP(uart_rts_ao_b, 0, 7),
> GROUP(remote_input_ao, 0, 0),
> + GROUP(pwm_ao_b, 0, 3),
> };
but it does show as ao_reg[3].
Kevin
[1] http://dn.odroid.com/S905/DataSheet/S905_Public_Datasheet_V1.1.4.pdf
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Martin Blumenstingl
<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 2/3] pinctrl: meson: meson-gxl: add the pwm_ao_b pin
Date: Mon, 23 Jan 2017 11:10:18 -0800 [thread overview]
Message-ID: <m2sho91tk5.fsf@baylibre.com> (raw)
In-Reply-To: <20170122210528.892-3-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> (Martin Blumenstingl's message of "Sun, 22 Jan 2017 22:05:27 +0100")
Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> writes:
> This adds support for the pwm_ao_b pin. Unfortunately the registers for
> the pwm_ao pins are not documented at all. The source for the pwm_ao_b
> pin from this patch is the Khadas VIM GPL kernel source, which sets bit
> 3 and unsets bits 4 and 31 to enable the PWM LEDs.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 25694f7094c7..6ff321a7366d 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -222,6 +222,8 @@ static const unsigned int uart_rts_ao_b_pins[] = { PIN(GPIOAO_3, 0) };
>
> static const unsigned int remote_input_ao_pins[] = {PIN(GPIOAO_7, 0) };
>
> +static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) };
> +
Hmm, the S905 public data sheet[1] shows this as GPIOAO_13.
> static struct meson_pmx_group meson_gxl_periphs_groups[] = {
> GPIO_GROUP(GPIOZ_0, EE_OFF),
> GPIO_GROUP(GPIOZ_1, EE_OFF),
> @@ -418,6 +420,7 @@ static struct meson_pmx_group meson_gxl_aobus_groups[] = {
> GROUP(uart_cts_ao_b, 0, 8),
> GROUP(uart_rts_ao_b, 0, 7),
> GROUP(remote_input_ao, 0, 0),
> + GROUP(pwm_ao_b, 0, 3),
> };
but it does show as ao_reg[3].
Kevin
[1] http://dn.odroid.com/S905/DataSheet/S905_Public_Datasheet_V1.1.4.pdf
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pinctrl: meson: meson-gxl: add the pwm_ao_b pin
Date: Mon, 23 Jan 2017 11:10:18 -0800 [thread overview]
Message-ID: <m2sho91tk5.fsf@baylibre.com> (raw)
In-Reply-To: <20170122210528.892-3-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sun, 22 Jan 2017 22:05:27 +0100")
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> This adds support for the pwm_ao_b pin. Unfortunately the registers for
> the pwm_ao pins are not documented at all. The source for the pwm_ao_b
> pin from this patch is the Khadas VIM GPL kernel source, which sets bit
> 3 and unsets bits 4 and 31 to enable the PWM LEDs.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson-gxl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> index 25694f7094c7..6ff321a7366d 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c
> @@ -222,6 +222,8 @@ static const unsigned int uart_rts_ao_b_pins[] = { PIN(GPIOAO_3, 0) };
>
> static const unsigned int remote_input_ao_pins[] = {PIN(GPIOAO_7, 0) };
>
> +static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) };
> +
Hmm, the S905 public data sheet[1] shows this as GPIOAO_13.
> static struct meson_pmx_group meson_gxl_periphs_groups[] = {
> GPIO_GROUP(GPIOZ_0, EE_OFF),
> GPIO_GROUP(GPIOZ_1, EE_OFF),
> @@ -418,6 +420,7 @@ static struct meson_pmx_group meson_gxl_aobus_groups[] = {
> GROUP(uart_cts_ao_b, 0, 8),
> GROUP(uart_rts_ao_b, 0, 7),
> GROUP(remote_input_ao, 0, 0),
> + GROUP(pwm_ao_b, 0, 3),
> };
but it does show as ao_reg[3].
Kevin
[1] http://dn.odroid.com/S905/DataSheet/S905_Public_Datasheet_V1.1.4.pdf
next prev parent reply other threads:[~2017-01-23 19:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 21:05 [PATCH 0/3] meson-gx: add pwm_AO_ab Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` [PATCH 1/3] ARM64: dts: meson-gx: add the missing pwm_AO_ab node Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` [PATCH 2/3] pinctrl: meson: meson-gxl: add the pwm_ao_b pin Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-23 19:10 ` Kevin Hilman [this message]
2017-01-23 19:10 ` Kevin Hilman
2017-01-23 19:10 ` Kevin Hilman
2017-01-23 19:12 ` Kevin Hilman
2017-01-23 19:12 ` Kevin Hilman
2017-01-23 19:12 ` Kevin Hilman
2017-01-26 14:41 ` Linus Walleij
2017-01-26 14:41 ` Linus Walleij
2017-01-26 14:41 ` Linus Walleij
2017-01-22 21:05 ` [PATCH 3/3] ARM64: dts: " Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-22 21:05 ` Martin Blumenstingl
2017-01-27 19:02 ` [PATCH 0/3] meson-gx: add pwm_AO_ab Kevin Hilman
2017-01-27 19:02 ` Kevin Hilman
2017-01-27 19:02 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sho91tk5.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.