From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()
Date: Tue, 16 Aug 2016 08:12:45 -0500 [thread overview]
Message-ID: <m2shu497si.fsf@baylibre.com> (raw)
In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200")
Daniel Wagner <wagi@monom.org> writes:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
> reinit_completion()
> ...
> /* Start the transfer */
> ...
> wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Daniel Wagner <wagi@monom.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Tim Kryger <tim.kryger@linaro.org>, Ray Jui <rjui@broadcom.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
linux-kernel@vger.kernel.org,
Beniamino Galvani <b.galvani@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()
Date: Tue, 16 Aug 2016 08:12:45 -0500 [thread overview]
Message-ID: <m2shu497si.fsf@baylibre.com> (raw)
In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200")
Daniel Wagner <wagi@monom.org> writes:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
> reinit_completion()
> ...
> /* Start the transfer */
> ...
> wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v0 4/4] i2c: meson: Use complete() instead of complete_all()
Date: Tue, 16 Aug 2016 08:12:45 -0500 [thread overview]
Message-ID: <m2shu497si.fsf@baylibre.com> (raw)
In-Reply-To: <1470225791-16613-5-git-send-email-wagi@monom.org> (Daniel Wagner's message of "Wed, 3 Aug 2016 14:03:11 +0200")
Daniel Wagner <wagi@monom.org> writes:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> meson_i2c_xfer_msg()
> reinit_completion()
> ...
> /* Start the transfer */
> ...
> wait_for_completion_timeout()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Kevin Hilman <khilman@baylibre.com>
next prev parent reply other threads:[~2016-08-16 13:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 12:03 [PATCH v0 0/4] Use complete() instead of complete_all() Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` [PATCH v0 1/4] i2c: bcm-iproc: " Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 16:36 ` Ray Jui
2016-08-03 16:36 ` Ray Jui
2016-08-03 16:36 ` Ray Jui
2016-08-03 16:36 ` Ray Jui
2016-08-03 12:03 ` [PATCH v0 2/4] i2c: bcm-kona: " Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 16:38 ` Ray Jui
2016-08-03 16:38 ` Ray Jui
2016-08-03 16:38 ` Ray Jui
2016-08-03 16:38 ` Ray Jui
2016-08-05 4:16 ` Tim Kryger
2016-08-05 4:16 ` Tim Kryger
2016-08-05 4:16 ` Tim Kryger
2016-08-03 12:03 ` [PATCH v0 3/4] i2c: brcmstb: " Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 16:00 ` Kamal Dasu
2016-08-03 16:00 ` Kamal Dasu
2016-08-03 16:00 ` Kamal Dasu
2016-08-03 12:03 ` [PATCH v0 4/4] i2c: meson: " Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-03 12:03 ` Daniel Wagner
2016-08-16 13:12 ` Kevin Hilman [this message]
2016-08-16 13:12 ` Kevin Hilman
2016-08-16 13:12 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2shu497si.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.