All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hajime Tazaki <thehajime@gmail.com>
To: broonie@kernel.org
Cc: ljs@kernel.org, linux-mm@kvack.org, geert@linux-m68k.org,
	daniel@thingy.jp, shuah@kernel.org, kees@kernel.org,
	luto@amacapital.net, wad@chromium.org, jackmanb@google.com,
	liuhangbin@gmail.com, rbm@suse.com,
	linux-kselftest@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [RFC PATCH 5/6] selftests: run tests on nommu architecture
Date: Sun, 16 Aug 2026 06:58:36 +0900	[thread overview]
Message-ID: <m2tsovoxkj.wl-thehajime@gmail.com> (raw)
In-Reply-To: <4355a510-2e00-41f7-9bb3-8f6b2d95503b@sirena.org.uk>


Hello Mark,

thank you for your time to review the patch !

On Fri, 14 Aug 2026 23:34:15 +0900,
Mark Brown wrote:
> 
> [1  <text/plain; us-ascii (quoted-printable)>]
> On Fri, Aug 14, 2026 at 01:50:50PM +0100, Lorenzo Stoakes (ARM) wrote:
> 
> > So at this point you're not really running much of the selftests at all,
> > and are only happening to run those that don't do the very basic stuff
> > nommu can't deal with.
> 
> > I think an audit of existing tests to figure out what works with nommu vs
> > what doesn't is really unreasonable again, given nobody tests or seemingly
> > uses these arches.
> 
> > So this patch might beget more nommu carve outs and exceptions and
> > therefore nommu workload and maintenance, which isn't really sustainable.
> 
> > I know I complain about lack of testing on nommu, but at the same time I
> > don't think running arbitrary tests that happen to work on it and who knows
> > if they are valid asserts anyway really fixes things.
> 
> > And given nobody really is doing testing, it's not really a great RoI
> > here...
> 
> Perhaps a good first step here is to start off with getting some public
> CI set up, then build up to getting things running cleanly.  That way
> there'll be visible ongoing coverage which will help motivate getting
> whatever changes integrated, and if the changes are done bit by bit
> there should be clearer explanations for why they make sense on nommu.

thanks,

I'm currently running tests on my personal CI (gh actions) but try to
find a public one to be more visible to others.

> You could perhaps use a skiplist to ignore tests that don't work yet so
> the CI starts off clean?

thanks, that would indeed make nommu tests more cleaner to integrate
as a first step.

-- Hajime



  reply	other threads:[~2026-08-15 21:58 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  6:33 [RFC PATCH 0/6] fix nommu mmap and add nommu kselftests Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 1/6] mm: nommu: fix do_mremap() to correctly update internal states Hajime Tazaki
2026-08-14 11:52   ` Lorenzo Stoakes (ARM)
2026-08-14 22:28     ` Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 2/6] mm: nommu: use vma_is_anonymous() to check if vmas are anonymous Hajime Tazaki
2026-08-14 11:52   ` Lorenzo Stoakes (ARM)
2026-08-14 22:29     ` Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 3/6] mm: nommu: fix an issue on map request to /dev/zero Hajime Tazaki
2026-08-13 12:19   ` Greg Kroah-Hartman
2026-08-13 12:43     ` Daniel Palmer
2026-08-13 13:29       ` Lorenzo Stoakes (ARM)
2026-08-13 13:51         ` Daniel Palmer
2026-08-13 13:58           ` Lorenzo Stoakes (ARM)
2026-08-13 14:06           ` Greg Kroah-Hartman
2026-08-14 12:42         ` Hajime Tazaki
2026-08-14 13:02           ` Lorenzo Stoakes (ARM)
2026-08-17  8:15             ` Hajime Tazaki
2026-08-13 14:02       ` Greg Kroah-Hartman
2026-08-13 14:10         ` Lorenzo Stoakes (ARM)
2026-08-14  9:09           ` Geert Uytterhoeven
2026-08-13 13:22     ` Matthew Wilcox
2026-08-13 13:32       ` Lorenzo Stoakes (ARM)
2026-08-13 13:43         ` Lorenzo Stoakes (ARM)
2026-08-13 14:04       ` Greg Kroah-Hartman
2026-08-14 12:42     ` Hajime Tazaki
2026-08-14 12:37   ` Lorenzo Stoakes (ARM)
2026-08-13  6:33 ` [RFC PATCH 4/6] selftests: fix build errors on alpine linux Hajime Tazaki
2026-08-14  9:34   ` Pedro Falcato
2026-08-14 12:44     ` Hajime Tazaki
2026-08-14 12:39   ` Lorenzo Stoakes (ARM)
2026-08-14 22:29     ` Hajime Tazaki
2026-08-13  6:34 ` [RFC PATCH 5/6] selftests: run tests on nommu architecture Hajime Tazaki
2026-08-14 12:50   ` Lorenzo Stoakes (ARM)
2026-08-14 14:34     ` Mark Brown
2026-08-15 21:58       ` Hajime Tazaki [this message]
2026-08-15 21:58     ` Hajime Tazaki
2026-08-13  6:34 ` [RFC PATCH 6/6] selftests/mm: add nommu mmap and mremap behavior tests Hajime Tazaki
2026-08-14 13:28   ` Lorenzo Stoakes (ARM)
2026-08-14 22:35     ` Hajime Tazaki
2026-08-14 11:24 ` [RFC PATCH 0/6] fix nommu mmap and add nommu kselftests Lorenzo Stoakes (ARM)
2026-08-14 11:26   ` Lorenzo Stoakes (ARM)
2026-08-14 22:27   ` Hajime Tazaki
2026-08-15 11:53     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2tsovoxkj.wl-thehajime@gmail.com \
    --to=thehajime@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniel@thingy.jp \
    --cc=geert@linux-m68k.org \
    --cc=jackmanb@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-um@lists.infradead.org \
    --cc=liuhangbin@gmail.com \
    --cc=ljs@kernel.org \
    --cc=luto@amacapital.net \
    --cc=rbm@suse.com \
    --cc=shuah@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.