All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hajime Tazaki <thehajime@gmail.com>
To: ljs@kernel.org
Cc: linux-mm@kvack.org, geert@linux-m68k.org, daniel@thingy.jp,
	shuah@kernel.org, kees@kernel.org, luto@amacapital.net,
	wad@chromium.org, broonie@kernel.org, jackmanb@google.com,
	liuhangbin@gmail.com, rbm@suse.com,
	linux-kselftest@vger.kernel.org, linux-um@lists.infradead.org
Subject: Re: [RFC PATCH 5/6] selftests: run tests on nommu architecture
Date: Sun, 16 Aug 2026 06:58:01 +0900	[thread overview]
Message-ID: <m2v79boxli.wl-thehajime@gmail.com> (raw)
In-Reply-To: <an8MlE22U3586R42@lucifer>


On Fri, 14 Aug 2026 21:50:50 +0900,
Lorenzo Stoakes (ARM) wrote:
> 
> Not really loving this as mentioned on the cover letter.
> 
> I'm sympathetic to making things work if it's not invasive, but now you've
> essentially asking new test authors be aware of this to some degree.

It is not intentional that new test authors should have to think about
NOMMU=1.  If there are no option specified it should be as what
the current kselftest is and it it's not, it's a design failure of mine.

> And making the harness - which is the defacto way of writing tests - now
> simply not work there is a bit crazy.
> 
> I'd ideally like to see _all_ tests use the harness.

I also think so but if NOMMU tests is implemented using the harness
test, this patchset would be invasive.  This one is very small patch
which tries to:

- add ability to run tests on nommu
- with minimum modifications and not breaking any existing usage of
  kselftest

which are, I guess, what you're suggesting.

> Also a bunch of the tests already do forking as part of the testing:
> 
> $ cd tools/testing/selftests/mm
> $ rg -l "fork\(" | wc -l
> 17
> 
> So at this point you're not really running much of the selftests at all,
> and are only happening to run those that don't do the very basic stuff
> nommu can't deal with.

the current situation is exactly what you described. `TARGETS=mm` is
able to only build with NOMMU=1, but onlyis runnable with nommu_*_test
(I need to specify `-t nommu_mmap_test -t nommu_mremap_test` to pass
tests from a run.

Now I'm thinking to create a different target (e.g., `TARGETS=mm/nommu`)
to make it more clear for this situation.

Existing tests even in selftests/mm should not involve these new tests
which has such limitation.

> I think an audit of existing tests to figure out what works with nommu vs
> what doesn't is really unreasonable again, given nobody tests or seemingly
> uses these arches.
> 
> So this patch might beget more nommu carve outs and exceptions and
> therefore nommu workload and maintenance, which isn't really sustainable.

I can understand but without tests we cannot easily detect regressions
in future.  Like when you applied broad changes into mm and try to
apply also to nommu.c, I believe these tests are also useful to verify
the extension, especially if the changes are not trivial.

# sorry, this might be too obvious for you..

> I know I complain about lack of testing on nommu, but at the same time I
> don't think running arbitrary tests that happen to work on it and who knows
> if they are valid asserts anyway really fixes things.

agree.
I think (current) nommu isn't ready to run arbitrary tests of mm.

> And given nobody really is doing testing, it's not really a great RoI
> here...

At least myself, for the moment, has an interest.

> ...OTOH I suppose it's a minimal change we can largely ignore as long as
> this doesn't lead to additional work/auditing from anybody but nommu
> enthusiasts.
> 
> But I'm just not sure that will be the case :(

again, this (not breaking existing model) is my intention so, this
should be the case, and if it's not it should be addressed in this
series.

> (I'm amazed we support a mode in linux that can't fork() in 2026 :)

I concur.

> > ---
> >  Documentation/dev-tools/kselftest.rst       | 12 ++++++++++++
> >  tools/testing/selftests/kselftest/runner.sh |  9 +++++++--
> >  tools/testing/selftests/kselftest_harness.h |  4 ++++
> >  tools/testing/selftests/lib.mk              |  8 ++++++++
> >  4 files changed, 31 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> > index 64c0ec7428a2..800b2b688aff 100644
> > --- a/Documentation/dev-tools/kselftest.rst
> > +++ b/Documentation/dev-tools/kselftest.rst
> > @@ -230,6 +230,18 @@ section::
> >
> >  .. _tar's auto-compress: https://www.gnu.org/software/tar/manual/html_node/gzip.html#auto_002dcompress
> >
> > +Build and test on nommu target
> > +==============================
> > +
> > +If you (cross-)build kselftests for nommu targets, or run tests on nommu targets, use

-- Hajime


  parent reply	other threads:[~2026-08-15 21:58 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13  6:33 [RFC PATCH 0/6] fix nommu mmap and add nommu kselftests Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 1/6] mm: nommu: fix do_mremap() to correctly update internal states Hajime Tazaki
2026-08-14 11:52   ` Lorenzo Stoakes (ARM)
2026-08-14 22:28     ` Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 2/6] mm: nommu: use vma_is_anonymous() to check if vmas are anonymous Hajime Tazaki
2026-08-14 11:52   ` Lorenzo Stoakes (ARM)
2026-08-14 22:29     ` Hajime Tazaki
2026-08-13  6:33 ` [RFC PATCH 3/6] mm: nommu: fix an issue on map request to /dev/zero Hajime Tazaki
2026-08-13 12:19   ` Greg Kroah-Hartman
2026-08-13 12:43     ` Daniel Palmer
2026-08-13 13:29       ` Lorenzo Stoakes (ARM)
2026-08-13 13:51         ` Daniel Palmer
2026-08-13 13:58           ` Lorenzo Stoakes (ARM)
2026-08-13 14:06           ` Greg Kroah-Hartman
2026-08-14 12:42         ` Hajime Tazaki
2026-08-14 13:02           ` Lorenzo Stoakes (ARM)
2026-08-17  8:15             ` Hajime Tazaki
2026-08-13 14:02       ` Greg Kroah-Hartman
2026-08-13 14:10         ` Lorenzo Stoakes (ARM)
2026-08-14  9:09           ` Geert Uytterhoeven
2026-08-13 13:22     ` Matthew Wilcox
2026-08-13 13:32       ` Lorenzo Stoakes (ARM)
2026-08-13 13:43         ` Lorenzo Stoakes (ARM)
2026-08-13 14:04       ` Greg Kroah-Hartman
2026-08-14 12:42     ` Hajime Tazaki
2026-08-14 12:37   ` Lorenzo Stoakes (ARM)
2026-08-13  6:33 ` [RFC PATCH 4/6] selftests: fix build errors on alpine linux Hajime Tazaki
2026-08-14  9:34   ` Pedro Falcato
2026-08-14 12:44     ` Hajime Tazaki
2026-08-14 12:39   ` Lorenzo Stoakes (ARM)
2026-08-14 22:29     ` Hajime Tazaki
2026-08-13  6:34 ` [RFC PATCH 5/6] selftests: run tests on nommu architecture Hajime Tazaki
2026-08-14 12:50   ` Lorenzo Stoakes (ARM)
2026-08-14 14:34     ` Mark Brown
2026-08-15 21:58       ` Hajime Tazaki
2026-08-15 21:58     ` Hajime Tazaki [this message]
2026-08-13  6:34 ` [RFC PATCH 6/6] selftests/mm: add nommu mmap and mremap behavior tests Hajime Tazaki
2026-08-14 13:28   ` Lorenzo Stoakes (ARM)
2026-08-14 22:35     ` Hajime Tazaki
2026-08-14 11:24 ` [RFC PATCH 0/6] fix nommu mmap and add nommu kselftests Lorenzo Stoakes (ARM)
2026-08-14 11:26   ` Lorenzo Stoakes (ARM)
2026-08-14 22:27   ` Hajime Tazaki
2026-08-15 11:53     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2v79boxli.wl-thehajime@gmail.com \
    --to=thehajime@gmail.com \
    --cc=broonie@kernel.org \
    --cc=daniel@thingy.jp \
    --cc=geert@linux-m68k.org \
    --cc=jackmanb@google.com \
    --cc=kees@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-um@lists.infradead.org \
    --cc=liuhangbin@gmail.com \
    --cc=ljs@kernel.org \
    --cc=luto@amacapital.net \
    --cc=rbm@suse.com \
    --cc=shuah@kernel.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.