All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Add error message for loading snapshot without VM state
Date: Tue, 01 Mar 2011 11:19:16 +0100	[thread overview]
Message-ID: <m31v2rgn2z.fsf@trasno.org> (raw)
In-Reply-To: <1298972982-7609-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 1 Mar 2011 10:49:42 +0100")

Kevin Wolf <kwolf@redhat.com> wrote:
> It already fails, but it didn't tell the user why.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  savevm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index a50fd31..6e026a8 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1996,6 +1996,8 @@ int load_vmstate(const char *name)
>      if (ret < 0) {
>          return ret;
>      } else if (sn.vm_state_size == 0) {
> +        error_report("This is a disk-only snapshot. Revert to it offline "
> +            "using qemu-img.");
>          return -EINVAL;
>      }

Reviewed-by: Juan Quintela <quintela@redhat.com>

      reply	other threads:[~2011-03-01 10:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01  9:49 [Qemu-devel] [PATCH] Add error message for loading snapshot without VM state Kevin Wolf
2011-03-01 10:19 ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31v2rgn2z.fsf@trasno.org \
    --to=quintela@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.