* [Qemu-devel] [PATCH] Add error message for loading snapshot without VM state
@ 2011-03-01 9:49 Kevin Wolf
2011-03-01 10:19 ` [Qemu-devel] " Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2011-03-01 9:49 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf
It already fails, but it didn't tell the user why.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
savevm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/savevm.c b/savevm.c
index a50fd31..6e026a8 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1996,6 +1996,8 @@ int load_vmstate(const char *name)
if (ret < 0) {
return ret;
} else if (sn.vm_state_size == 0) {
+ error_report("This is a disk-only snapshot. Revert to it offline "
+ "using qemu-img.");
return -EINVAL;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] Add error message for loading snapshot without VM state
2011-03-01 9:49 [Qemu-devel] [PATCH] Add error message for loading snapshot without VM state Kevin Wolf
@ 2011-03-01 10:19 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2011-03-01 10:19 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
Kevin Wolf <kwolf@redhat.com> wrote:
> It already fails, but it didn't tell the user why.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> savevm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index a50fd31..6e026a8 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1996,6 +1996,8 @@ int load_vmstate(const char *name)
> if (ret < 0) {
> return ret;
> } else if (sn.vm_state_size == 0) {
> + error_report("This is a disk-only snapshot. Revert to it offline "
> + "using qemu-img.");
> return -EINVAL;
> }
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-01 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-01 9:49 [Qemu-devel] [PATCH] Add error message for loading snapshot without VM state Kevin Wolf
2011-03-01 10:19 ` [Qemu-devel] " Juan Quintela
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.