From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: remove unused code in delay.S
Date: Wed, 16 Sep 2009 00:47:34 +0200 [thread overview]
Message-ID: <m33a6nddvd.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1253053609.3273.139.camel@linux-1lbu> (Steve Chen's message of "Tue, 15 Sep 2009 17:26:49 -0500")
Steve Chen <schen@mvista.com> writes:
> If I know for sure that these are the processors that need that block of
> code, your suggestion makes perfect sense. Unfortunately, I don't know.
Then I wouldn't write "Accurate delays". "Different", maybe.
"Accurate", we don't know.
> My primary goals are
>
> 1. Put a stop to this thread (so far I have failed miserably)
> 2. Document that block of code.
> 3. If it makes someone's life easier.. it would be a bonus.
Uncertain comments don't make life easier. Just write what's certain,
or nothing if nothing is.
--
Krzysztof Halasa
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Halasa <khc@pm.waw.pl>
To: Steve Chen <schen@mvista.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jamie Lokier <jamie@shareable.org>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: remove unused code in delay.S
Date: Wed, 16 Sep 2009 00:47:34 +0200 [thread overview]
Message-ID: <m33a6nddvd.fsf@intrepid.localdomain> (raw)
In-Reply-To: <1253053609.3273.139.camel@linux-1lbu> (Steve Chen's message of "Tue, 15 Sep 2009 17:26:49 -0500")
Steve Chen <schen@mvista.com> writes:
> If I know for sure that these are the processors that need that block of
> code, your suggestion makes perfect sense. Unfortunately, I don't know.
Then I wouldn't write "Accurate delays". "Different", maybe.
"Accurate", we don't know.
> My primary goals are
>
> 1. Put a stop to this thread (so far I have failed miserably)
> 2. Document that block of code.
> 3. If it makes someone's life easier.. it would be a bonus.
Uncertain comments don't make life easier. Just write what's certain,
or nothing if nothing is.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-09-15 22:47 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 21:05 [PATCH] arm: remove unused code in delay.S Felipe Contreras
2009-09-13 21:05 ` Felipe Contreras
2009-09-13 21:28 ` Marek Vasut
2009-09-13 21:28 ` Marek Vasut
2009-09-13 23:00 ` Russell King - ARM Linux
2009-09-13 23:00 ` Russell King - ARM Linux
2009-09-14 0:21 ` Jamie Lokier
2009-09-14 0:21 ` Jamie Lokier
2009-09-14 8:10 ` Russell King - ARM Linux
2009-09-14 8:10 ` Russell King - ARM Linux
2009-09-14 12:58 ` Felipe Contreras
2009-09-14 12:58 ` Felipe Contreras
2009-09-14 14:00 ` Russell King - ARM Linux
2009-09-14 14:00 ` Russell King - ARM Linux
2009-09-14 14:38 ` Felipe Contreras
2009-09-14 14:38 ` Felipe Contreras
2009-09-14 14:40 ` Russell King - ARM Linux
2009-09-14 14:40 ` Russell King - ARM Linux
2009-09-14 15:14 ` Felipe Contreras
2009-09-14 15:14 ` Felipe Contreras
2009-09-14 15:21 ` Russell King - ARM Linux
2009-09-14 15:21 ` Russell King - ARM Linux
2009-09-14 15:50 ` Felipe Contreras
2009-09-14 15:50 ` Felipe Contreras
2009-09-14 16:25 ` Marek Vasut
2009-09-14 16:25 ` Marek Vasut
2009-09-14 16:54 ` Felipe Contreras
2009-09-14 16:54 ` Felipe Contreras
2009-09-14 15:36 ` Wolfram Sang
2009-09-14 15:36 ` Wolfram Sang
2009-09-14 16:06 ` Felipe Contreras
2009-09-14 16:06 ` Felipe Contreras
2009-09-14 16:24 ` Wolfram Sang
2009-09-14 16:24 ` Wolfram Sang
2009-09-15 10:37 ` Pavel Machek
2009-09-15 10:37 ` Pavel Machek
2009-09-15 10:47 ` Felipe Contreras
2009-09-15 10:47 ` Felipe Contreras
2009-09-15 10:49 ` Pavel Machek
2009-09-15 10:49 ` Pavel Machek
2009-09-15 11:20 ` Felipe Contreras
2009-09-15 11:20 ` Felipe Contreras
2009-09-15 12:29 ` Steve Chen
2009-09-15 12:29 ` Steve Chen
2009-09-15 13:41 ` Marek Vasut
2009-09-15 13:41 ` Marek Vasut
2009-09-15 16:30 ` Steve Chen
2009-09-15 16:30 ` Steve Chen
2009-09-15 18:58 ` Felipe Contreras
2009-09-15 18:58 ` Felipe Contreras
2009-09-15 19:44 ` Steve Chen
2009-09-15 19:44 ` Steve Chen
2009-09-15 20:39 ` Marek Vasut
2009-09-15 20:39 ` Marek Vasut
2009-09-15 21:04 ` Krzysztof Halasa
2009-09-15 21:04 ` Krzysztof Halasa
2009-09-15 22:26 ` Steve Chen
2009-09-15 22:26 ` Steve Chen
2009-09-15 22:47 ` Krzysztof Halasa [this message]
2009-09-15 22:47 ` Krzysztof Halasa
2009-09-16 8:26 ` Steve Chen
2009-09-16 8:26 ` Steve Chen
2009-09-16 12:30 ` Krzysztof Halasa
2009-09-16 12:30 ` Krzysztof Halasa
2009-09-16 14:49 ` Steve Chen
2009-09-16 14:49 ` Steve Chen
2009-09-16 20:21 ` Sergei Shtylyov
2009-09-16 20:21 ` Sergei Shtylyov
2009-09-16 13:47 ` Russell King - ARM Linux
2009-09-16 13:47 ` Russell King - ARM Linux
2009-09-17 19:32 ` Jamie Lokier
2009-09-17 19:32 ` Jamie Lokier
2009-09-17 19:41 ` Russell King - ARM Linux
2009-09-17 19:41 ` Russell King - ARM Linux
2009-09-17 21:29 ` [PATCH v2] " Steve Chen
2009-09-17 21:29 ` Steve Chen
2009-09-17 21:37 ` Jamie Lokier
2009-09-17 21:37 ` Jamie Lokier
2009-09-17 22:25 ` Steve Chen
2009-09-17 22:25 ` Steve Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33a6nddvd.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.